[felixlaga]

Problem

glab mr accept is glab's alias for glab mr merge (glab docs list it under Aliases). When an agent merges with glab mr accept, the GitLab close-command pattern does not match. So T3 does not refresh the thread's linked merge request right away. It stays open until the next sync sweep, and settlement reads the branch from its one-minute cache instead of the host.

Change

The GitLab changeRequestCloseCommand pattern now matches accept next to merge and close.

Scope and approval

This is a very small fix for an obvious bug: a documented spelling of the merge command is missed. No behaviour changes for other commands. I searched issues and PRs for "glab mr accept", "changeRequestCloseCommand", "glab alias merge" and "merge command detection" and found nothing.

Verification

• New case GitLab CLI commands > recognizes shell merges and closes, including glab's accept alias in packages/source-control-gitlab/src/shared/definition.test.ts.
• vp test run packages/source-control-gitlab/src/shared/definition.test.ts with the fix: 9 passed.
• Same command with only definition.ts reverted to main: AssertionError: glab mr accept 7 --yes: expected false to be true.
• I also tried glab mr accept 7 --yes as a row in the close-command table in apps/server/src/orchestration-v2/PullRequestSyncReactor.test.ts. With the fix, the reactor reads the link fresh. I kept the committed test at the definition layer, the lowest one that fails on main.
• vp run check:changed passes.

Not checked: a live glab mr accept against a real GitLab merge request.

Written by Claude Opus 5.5 (claude-opus-5-5) in the Claude Code harness, run from T3 Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 923afa0

Macroscope's review found this PR approvable — Recognizes glab mr accept as a merge command so linked merge-request state refreshes promptly. Existing settlement settings and safeguards remain unchanged, and the change does not execute merges itself.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The GitLab close-command pattern now recognizes glab mr accept in addition to merge and close. Tests verify those matches and confirm that glab mr view does not match.

Changes: GitLab close-command matching

Layer / File(s)	Summary
Extend and test close-command matching packages/source-control-gitlab/src/shared/definition.ts, packages/source-control-gitlab/src/shared/definition.test.ts	The command pattern now matches glab mr accept. Tests cover merge, accept, and close as matches, and view as a non-match.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

• pingdotgg/t3code#23996: Adds the GitLab changeRequestCloseCommand and uses it to refresh links.

Suggested labels: bugfix, size:XS

Suggested reviewers: tonybynmp4

Merge Risk: Minimal · up to 923af

The accept alias triggers merge-request refresh; no material merge risk remains.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly describes the GitLab command detection change.
Description check		The description covers the problem, change, scope, and verification. It also identifies the unchecked live test and the agent used.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 83a3674
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: ba5d8d32-72cc-4a81-8726-44fcec9aebf1

Commits

Reviewing files that changed from the base of the PR and between 83a3674 and 923afa0.

Files selected for processing: 2

• packages/source-control-gitlab/src/shared/definition.test.ts
• packages/source-control-gitlab/src/shared/definition.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.