You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(web): terminal links keep route and pnpm paths in one piece - #30603
After the first slash, a relative path in the terminal only accepts letters, digits and ._-, so a link breaks at @ + $ [ ] ( ). These are ordinary names in Next.js, SvelteKit, TanStack Router and pnpm stack traces. Since #30526 only real paths become links, so the file itself gets no link at all: hovering it does nothing and it can't be opened.
Segments after the first slash in FILE_PATH_PATTERN now also accept $ + @, a closed [x] or [[x]], and (x) when a slash follows. All four lines above become one link. The first segment is unchanged, so $HOME/x and @user/thing behave as on main.
Parentheses need the slash so src/foo.ts(3,10): error still ends at the file.
Hover cost. Hover detection runs this on every frame. ] needs its [ because a loose run of ] reaches the quadratic loop in trimClosingDelimiters: simply adding [ ] to the character class took a/b plus 8,000 ] from 0.09 ms to 819 ms. As written it stays at 0.09 ms. Through the real extractTerminalLinks on 14 adversarial lines (runs of each new character, unclosed and repeated groups, deep nesting), time grows linearly up to 80k characters, and the worst line takes 7.7 ms against 9.3 ms for the worst on main. Two shapes were already slow and cost the same on main and here, so I left them alone: /]]]]… through the absolute path branch, and a line holding thousands of separate links.
One scope edge. Non-file tokens such as pkg/name@1.2.3 and obj/arr[0] now match whole. Neither is a real file on main or here, and since #30526 a match only becomes a link if it exists, so they stay unlinked.
Scope and approval
A very small fix for an obvious bug, so no prior issue: one pattern in one file, no new link types, and the same punctuation #28637 added to chat file links. No open pull request changes terminal-links.ts. Only the web terminal (web and desktop) uses this parser; mobile has no copy.
Verification
vp test run src/terminal-links.test.ts in apps/web: the 4 new rows fail on main (4 failed, 54 passed) and pass with the fix (58 passed).
vp lint, the web typecheck and vp run check:changed upstream/main pass.
In a dev server's terminal (web, T3's Browser panel on macOS), in a throwaway project holding these real files, with the pointer on the line. Images are the terminal's canvas pixels. On main the pointer stayed the default on the file part and on the whole pnpm line; with the fix all four lines give a pointer and a full underline.
Before, on main, only the src/app folder underlines on the [id] line:
After, the whole path underlines:
Before, on main, nothing on the pnpm line underlines:
After, the whole path underlines:
Cmd+click on the [id] and pnpm lines with the fix: the server's trace shows shell.openInEditor succeeding and launching the editor at src/app/[id]/page.tsx:3:10 and node_modules/.pnpm/react@18.3.1/node_modules/react/index.js:12:5.
Not checked: the packaged desktop app (same web terminal surface) and Windows. I confirmed the click from the launch trace, not by looking at the editor window.
Macroscope's review found this PR approvable — Terminal links now preserve route-directory syntax and pnpm package paths rather than splitting them. The change is limited to path recognition and retains existing path-opening permission checks.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
The terminal file path pattern now matches additional filename characters and bracketed or parenthesized route segments. Relative-path tests include examples for these paths and nested pnpm package paths.
FILE_PATH_PATTERN now accepts $, +, and @, bracketed segments, and parenthesized segments before a path separator. Relative-path tests cover these cases, nested pnpm paths, and a $id segment.
No actionable merge-blocking risk remains from the reviewed changes.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: terminal links in the web app now keep Next.js-style route segments and pnpm paths together as one link. It follows the conventional commit format and matches the raw …
Description check
The description follows the template. It has Problem, Change, Scope and approval, and Verification sections. The Problem section gives the failing terminal text and the reproduction table. The Change …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: terminal links in the web app now keep Next.js-style route segments and pnpm paths together as one link. It follows the conventional commit format and matches the raw summary, which describes the FILE_PATH_PATTERN update and the new test rows for route and pnpm paths.
Full details: Description check
Explanation
The description follows the template. It has Problem, Change, Scope and approval, and Verification sections. The Problem section gives the failing terminal text and the reproduction table. The Change section explains the pattern update and the performance trade-off. The Scope section explains why no prior issue is needed for this small fix and states that no open PR touches the file. The Verification section lists focused test results, lint and typecheck runs, before and after screenshots, and a Cmd+click trace, and it states what was not checked (packaged desktop app and Windows). The template asks for the model and harness used, and the description ends with 'Claude Opus 5.5 via T3 Code', so that item is covered. The Scope section cites approval by reasoning rather than a maintainer comment; the template allows explaining why a very small obvious fix qualifies without a prior issue, so this is acceptable.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 647bd14 and eb85d9f.
Files selected for processing: 2
apps/web/src/terminal-links.test.ts
apps/web/src/terminal-links.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
verified head eb85d9f74f444db39a2c1f2014609e477c8fa66b as-is on linux with the dev web client, playwright from the repository dependencies, and /usr/bin/google-chrome.
reproduced on github/main (3368dd70f2) in a separate worktree after vp i: the four route/pnpm file targets had no link cursor; hovering src/app underlined only that directory.
stopped main's server before starting the exact pr head with vp run dev. created a local git project through the app and ran real codex gpt-6.1-sol turns through the composer on both versions. codex created the files and shell script on main; the pr turn verified the same files and output without edits. no mocks, database fixtures, or replay provider.
ran clear; bash print-paths.sh in the app terminal. all four complete paths now underline and activate. ctrl-click opened each actual file in vscode at the requested line. checked the editor windows, including svelte at line 12, pnpm at line 12, and the dollar route at line 5.
ordinary src/plain.ts:3:2 still opens at line 3, column 2. src/plain.ts(3,10): error opens the file without swallowing the compiler suffix. a missing file remains unlinked and sends no editor request. the https link still gets a link cursor; external navigation was not exercised.
captured client-to-server shell.openInEditor requests from real ctrl-clicks:
blacksmith: all 58 existing terminal-link tests passed. vp run check:changed 647bd148b3fbd7c8b57a10fd41ae6d5fc7b35cc1 passed format, lint, both knip checks, affected typechecks, focused tests, and the selected react compiler check. ci reported 31 successful checks, none pending or failing. no source changes or pushes were needed.
before: hovering the route's first directory links only src/app.
after: the same pointer position underlines the complete route path.
animated terminal hover and ctrl-click recording, using the same real files. the source mp4 was also checked for playback and seeking in t3's browser player.
the pnpm ctrl-click opened the real file at line 12, column 5.
Not verified
packaged electron desktop, native ios/android, macos/windows, remote/relay/tunnel connections, other providers, and external website navigation. this pass used the linux dev web client and local codex proxy. mobile does not use this terminal parser. no performance claim was measured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Problem
After the first slash, a relative path in the terminal only accepts letters, digits and
._-, so a link breaks at@ + $ [ ] ( ). These are ordinary names in Next.js, SvelteKit, TanStack Router and pnpm stack traces. Since #30526 only real paths become links, so the file itself gets no link at all: hovering it does nothing and it can't be opened.mainsrc/app/[id]/page.tsx:3:10src/app,/[id]/page.tsx:3:10src/routes/(app)/+page.svelte:12:4src/routes,/(app)/+page.svelte:12:4node_modules/.pnpm/react@18.3.1/node_modules/react/index.js:12:5node_modules/.pnpm/react,18.3.1/node_modules/react/index.js:12:5app/routes/posts.$id.tsx:5app/routes/postsChange
Segments after the first slash in
FILE_PATH_PATTERNnow also accept$ + @, a closed[x]or[[x]], and(x)when a slash follows. All four lines above become one link. The first segment is unchanged, so$HOME/xand@user/thingbehave as onmain.Parentheses need the slash so
src/foo.ts(3,10): errorstill ends at the file.Hover cost. Hover detection runs this on every frame.
]needs its[because a loose run of]reaches the quadratic loop intrimClosingDelimiters: simply adding[ ]to the character class tooka/bplus 8,000]from 0.09 ms to 819 ms. As written it stays at 0.09 ms. Through the realextractTerminalLinkson 14 adversarial lines (runs of each new character, unclosed and repeated groups, deep nesting), time grows linearly up to 80k characters, and the worst line takes 7.7 ms against 9.3 ms for the worst onmain. Two shapes were already slow and cost the same onmainand here, so I left them alone:/]]]]…through the absolute path branch, and a line holding thousands of separate links.One scope edge. Non-file tokens such as
pkg/name@1.2.3andobj/arr[0]now match whole. Neither is a real file onmainor here, and since #30526 a match only becomes a link if it exists, so they stay unlinked.Scope and approval
A very small fix for an obvious bug, so no prior issue: one pattern in one file, no new link types, and the same punctuation #28637 added to chat file links. No open pull request changes
terminal-links.ts. Only the web terminal (web and desktop) uses this parser; mobile has no copy.Verification
vp test run src/terminal-links.test.tsinapps/web: the 4 new rows fail onmain(4 failed, 54 passed) and pass with the fix (58 passed).vp lint, the web typecheck andvp run check:changed upstream/mainpass.mainthe pointer stayed the default on the file part and on the whole pnpm line; with the fix all four lines give a pointer and a full underline.Before, on
main, only thesrc/appfolder underlines on the[id]line:After, the whole path underlines:
Before, on
main, nothing on the pnpm line underlines:After, the whole path underlines:
[id]and pnpm lines with the fix: the server's trace showsshell.openInEditorsucceeding and launching the editor atsrc/app/[id]/page.tsx:3:10andnode_modules/.pnpm/react@18.3.1/node_modules/react/index.js:12:5.Not checked: the packaged desktop app (same web terminal surface) and Windows. I confirmed the click from the launch trace, not by looking at the editor window.
Claude Opus 5.5 via T3 Code