fix(desktop): stop generating declarations during bundling

[juliusmarminge]

Desktop builds enable declaration output implicitly through the composite tsconfig. The declaration compiler also includes scripts/lib, which sits outside the desktop root, so vp pack leaves 15 generated .d.ts files beside those sources. They can then be picked up by an unrelated commit.

Disable declaration generation in all four desktop pack configurations. These bundles are executables and preloads with no declaration consumers.

Validation in an isolated worktree:

• T3CODE_DESKTOP_DEV=0 vp pack completed all four builds and produced the main process and three preload entry points.
• Confirmed zero .d.ts, .d.cts, or .d.mts files under scripts/lib and apps/desktop afterward.
• vp pack --no-write, targeted lint, and git diff --check passed.

Before: 15 source declarations appeared during desktop bundling. After: runtime bundles build without declaration output. This is a build configuration change, so screenshots are not applicable.

Model: GPT-6. Harness: Codex.

Note

Stop generating declaration for desktop Electron bundles

Sets dts: false on all four CommonJS pack configurations in vite.config.ts: the main Electron bundle, the preload bundle, and the two preview preload bundles. JavaScript output and source maps are unchanged.

^{Macroscope summarized fb928c3.}

Summary by CodeRabbit

• Chores
  • Adjusted desktop application packaging configuration to prevent declaration files from being generated for Electron bundles.

[macroscopeapp]

Approvability

Verdict: Approved at fb928c3

Macroscope's review found this PR approvable — This is a narrowly scoped desktop build cleanup that prevents declaration artifacts from being emitted while leaving executable bundles, source maps, and the separate typecheck unchanged. Its impact is confined to build output rather than product runtime behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

[macroscopeapp]

All clear

^{Posted via Macroscope — Effect Service Conventions}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.6 KiB	+6 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	0 B (0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.6 KiB	6.6 KiB	+6 B (+0.1%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	57.1 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.6 KiB	+32 B (+0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.1 KiB	+3 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+29 B (+0.4%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.9 KiB	+44 B (+0.1%)	66.4 KiB	✅
Claude	Live turn messages	9	10	+1 (+11.1%)	21	✅

Baseline: b5f7fa0 · PR result: fb928c3 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.9 KiB
• Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: e9069e1c-ae55-4480-b775-4bf9de196879

📥 Commits

Reviewing files that changed from the base of the PR and between b5f7fa0 and fb928c3.

📒 Files selected for processing (1)

• apps/desktop/vite.config.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

The desktop Vite configuration disables TypeScript declaration generation for the main Electron bundle and three preload bundles.

Changes

Electron build configuration

Layer / File(s)	Summary
Disable declaration generation apps/desktop/vite.config.ts	The main, preload, preview picker preload, and preview PIP preload configurations set dts: false.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to fb928

Desktop bundles will stop emitting TypeScript declaration files while retaining the main and preload runtime bundles. The change is ready to merge.

Suggested reviewers: bil0000

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: disabling declaration generation during desktop bundling.
Description check	✅ Passed	The description explains what changed, why it changed, the validation performed, and why UI evidence is not applicable. It is sufficiently complete for the template, although it does not include an ex…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-desktop-bundle-declarations

---

_{Comment @coderabbitai help to get the list of available commands.}