Skip to content

fix(web): remove excess sidebar thread spacing - #10569

Open
maria-rcks wants to merge 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/fix-sidebar-gap
Open

fix(web): remove excess sidebar thread spacing#10569
maria-rcks wants to merge 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/fix-sidebar-gap

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

the sidebar gap below "all projects" grew to 21 css pixels after #9731 added top padding and invisible drag markers; #10464 added another marker. remove the extra padding and cancel the zero-height markers' flex gaps, restoring the original 10px spacing while keeping drag targets measurable.

verified the spacing in the real web client in dark and light themes, project filtering and reset, and pointer-event drags into pinned and back into the empty active section with persisted state checks. 203 existing sidebar logic/drag tests, web typecheck, and scoped lint pass (existing lint warnings only); this shared sidebar serves web and desktop, while mobile has a separate sidebar.

before, dark:

before: extra gap below all projects in dark theme

after, dark:

after: restored sidebar spacing in dark theme

before, light:

before: extra gap below all projects in light theme

after, light:

after: restored sidebar spacing in light theme

model: gpt-5.6-sol. harness: codex.

@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 7, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2f37a9a

Macroscope's review found this PR approvable — The change is limited to three Tailwind class adjustments in the existing sidebar, removing excess padding and correcting one-pixel spacing around drag markers. Its impact is confined to sidebar layout geometry without introducing new capability or broader production behavior.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 609440f0-d906-4681-9247-72b92984bf16

📥 Commits

Reviewing files that changed from the base of the PR and between 0d34579 and 2f37a9a.

📒 Files selected for processing (1)
  • apps/web/src/components/Sidebar.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The sidebar thread list removes top padding. Sortable placeholder and drag-boundary markers add a 1px negative bottom margin.

Changes

Sidebar spacing alignment

Layer / File(s) Summary
Update sidebar spacing classes
apps/web/src/components/Sidebar.tsx
Sortable markers add -mb-px. The thread list removes pt-2.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 2f37a

The sidebar restores the intended spacing below All projects while retaining drag targets; no current merge-blocking risk remains.

Suggested reviewers: juliusmarminge, t3dotgg, utkarshusername

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: removing excess spacing in the web sidebar.
Description check ✅ Passed The description explains the spacing problem, the implementation, scope, verification steps, test results, and includes before/after screenshots for the UI change. It does not use the template heading…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant