Skip to content

refactor(web): remove unused runtime wrappers and exports - #10225

Merged
juliusmarminge merged 1 commit into
mainfrom
cleanup-web/runtime-internals
Sep 6, 2026
Merged

refactor(web): remove unused runtime wrappers and exports#10225
juliusmarminge merged 1 commit into
mainfrom
cleanup-web/runtime-internals

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 5, 2026

Copy link
Copy Markdown
Member

Knip identified unused hooks, auth wrappers, atoms, and re-export aliases in the web runtime. Remove dead wrappers and keep implementation details private where they still have local callers.

Preserve the bootstrap functions used through the primary-environment barrel, their existing tests, and all exported types and Effect schemas. This rebased revision also makes the newly landed web favicon downscaler private while retaining its local cache caller.

Core UI component modules are unchanged. Their named subcomponents are preserved as complete component sets.

Layer 1 of 4 in the web runtime-export cleanup stack.

Verification at the integrated stack tip: vp run --filter @t3tools/web test passes all 4,052 tests across 333 files. Web typecheck and changed-file lint/format pass. vp run knip:check passes. A negative probe confirmed that a wholly unused components/ui/*.tsx file still fails the file audit.

Model: gpt-6 astra. Harness: Codex in T3 Code.

Note

Add persistent project favicon cache, PR terminal timestamps, and remaining-quota usage display

  • Adds a persistent project favicon cache backed by IndexedDB (web) and the mobile database with native image downscaling. A new createProjectFaviconUrlAtom family replaces the old useAssetUrl hook, retaining the last resolved icon across failures and serving hydrated cache images before remote refresh.
  • Adds optional closedAt and mergedAt fields to pull-request and change-request schemas across all providers (GitHub, GitLab, Bitbucket, Azure DevOps). pullRequestSettles in ThreadSettlementPolicy.ts now uses the state-specific terminal timestamp instead of updatedAt, so metadata updates after a merge or close no longer re-settle a thread.
  • Switches usage-limit displays from "used" to "remaining" quota and time. Both web and mobile refresh paths gain a shared refreshUsage workflow with explicit concurrency guards and abort-on-disconnect behavior.
  • makeEnvironmentThreadState in threads.ts now retains synchronization errors and cached data after terminated loads, does not restart fatal loads on connection notifications, and clears errors only on actual retry.
  • Replaces direct Lucide refresh/loader icons with shared RefreshIcon and Spinner components across many web and mobile settings, chat, and file-preview components. Migrates mobile adaptive color classes to semantic theme tokens (danger, warning, primary, secondary, subtle).
  • Risk: BitbucketPullRequestProvider now always returns null for mergedAt/closedAt instead of deriving from updatedAt; settlement behavior changes for threads whose PR metadata updated after terminal state. The useAssetUrl hook and useProjectFaviconAsset hook are removed—any out-of-tree consumers will break.

Macroscope summarized fba39bb.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.6 KiB 13.6 KiB −14 B (−0.1%) 15.1 KiB
Codex Thread snapshot wire 7.0 KiB 7.0 KiB 0 B (0.0%) 7.3 KiB
Codex Live turn WebSocket wire 6.6 KiB 6.6 KiB −14 B (−0.2%) 7.8 KiB
Codex Live turn WebSocket decoded 57.1 KiB 57.1 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 10 10 0 (0.0%) 21
Claude Total thread wire 13.5 KiB 13.6 KiB +35 B (+0.3%) 15.1 KiB
Claude Thread snapshot wire 7.0 KiB 7.0 KiB −4 B (−0.1%) 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 6.5 KiB +39 B (+0.6%) 7.8 KiB
Claude Live turn WebSocket decoded 57.8 KiB 57.8 KiB +44 B (+0.1%) 66.4 KiB
Claude Live turn messages 8 9 +1 (+12.5%) 21

Baseline: bfba778 · PR result: fba39bb · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge
juliusmarminge marked this pull request as ready for review September 5, 2026 23:25
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The diff is primarily an internal export and dead-code cleanup with no evident new runtime path or product-default change. It directly modifies primary authentication code and removes authentication-related APIs, so human review is required for the sensitive area.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the cleanup-web/runtime-internals branch from c95e524 to fba39bb Compare September 6, 2026 03:32
@juliusmarminge
juliusmarminge changed the base branch from cleanup-web/layout-components to main September 6, 2026 03:32
@juliusmarminge juliusmarminge changed the title refactor(web): remove unused environment runtime wrappers refactor(web): remove unused runtime wrappers and exports Sep 6, 2026
@juliusmarminge
juliusmarminge merged commit fdcc491 into main Sep 6, 2026
35 of 46 checks passed
@juliusmarminge
juliusmarminge deleted the cleanup-web/runtime-internals branch September 6, 2026 05:07
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 6, 2026
## What's Changed
* fix(web): keep timestamp tooltip dates in English by @Lucenx9 in pingdotgg/t3code#10256
* fix(web): let authorized clients scrolling reach settings by @flamboh in pingdotgg/t3code#10080
* fix(web): remember usage page selection by @extoci in pingdotgg/t3code#10189
* fix(server): keep the Antigravity Google sign-in across server restarts by @t3dotgg in pingdotgg/t3code#10244
* fix(antigravity): load user skills from ~/.gemini for every project by @t3dotgg in pingdotgg/t3code#10257
* fix(web): respect reduced motion in shared disclosures by @saphid in pingdotgg/t3code#10258
* feat(marketing): add a Windows 95 landing page by @t3dotgg in pingdotgg/t3code#10286
* refactor(web): remove unused runtime wrappers and exports by @juliusmarminge in pingdotgg/t3code#10225
* refactor(web): keep feature component helpers private by @juliusmarminge in pingdotgg/t3code#10226
* refactor(web): keep app utilities private and remove dead helpers by @juliusmarminge in pingdotgg/t3code#10227
* ci: enforce unused runtime exports in the web app by @juliusmarminge in pingdotgg/t3code#10228
* test(desktop): cover Clerk setup through the service by @juliusmarminge in pingdotgg/t3code#10284
* test(desktop): cover WSL hashes through runtime resolution by @juliusmarminge in pingdotgg/t3code#10285
* test(desktop): cover password store through startup by @juliusmarminge in pingdotgg/t3code#10287
* test(desktop): cover WSL paths through public behavior by @juliusmarminge in pingdotgg/t3code#10289
* test(desktop): exercise WSL cache safety through public scripts by @juliusmarminge in pingdotgg/t3code#10301
* test(web): cover file classification through diff ordering by @juliusmarminge in pingdotgg/t3code#10304
* test(web): focus command palette tests on search behavior by @juliusmarminge in pingdotgg/t3code#10302
* fix(web): add project settings to legacy sidebar project menu by @hwanseoc in pingdotgg/t3code#10021
* test(web): keep Markdown gutter styling private by @juliusmarminge in pingdotgg/t3code#10306
* feat(settings): add shared project defaults and scoped overrides by @maria-rcks in pingdotgg/t3code#9754
* feat(connections): balance new threads across connected machines by @maria-rcks in pingdotgg/t3code#9895
* test(web): keep settings viewport comparison private by @juliusmarminge in pingdotgg/t3code#10307
* fix(web): prevent file tree search focus ring clipping by @GuilhermeVieiraDev in pingdotgg/t3code#10175
* fix(mobile): stop the work log flickering during subagent runs and failing calls by @juliusmarminge in pingdotgg/t3code#10273
* fix(mobile): save linked media from chat by @juliusmarminge in pingdotgg/t3code#10271
* feat(markdown): show the GitHub mark for github.com links by @juliusmarminge in pingdotgg/t3code#10324
* fix(marketing): show a real preview card when t3.codes is shared by @t3dotgg in pingdotgg/t3code#10305


**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260906.1292...v0.0.39-nightly.20260906.1293

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260906.1293
aorwall added a commit to aorwall/t3code that referenced this pull request Sep 7, 2026
Upstream removed ClientTracingLive as an unused export (pingdotgg#10225). The fork's
lib/runtime.ts still installs it, because a Moatless deployment exports client
spans through the delegate this layer carries. Neither file conflicted, so the
merge produced code that does not compile.

Restored with a Fork comment naming the consumer.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
aorwall added a commit to aorwall/t3code that referenced this pull request Sep 7, 2026
Merges 141 upstream commits (`b438447f6..8b2838e`) into the fork,
following the
`fork-upstream-merge` skill. Landed as a merge commit; conflicts
resolved by the
path-policy verdicts in `docs/fork/inventory.json`.

## Merge shape

563 files landed (`git diff --stat HEAD^1 HEAD`) against 563 in the
upstream
range, so no upstream work was dropped. Fork delta 720 files.

## Conflicts

14 files, resolved by concern. The merge commit message names each. Two
are worth
carrying forward:

- Upstream extracted the project action rows into
`ProjectActionsList.tsx`. The
fork's Edit gate now rides an `editable` prop that defaults to
upstream's
  always-editable behavior, so the gate survives the next extraction.
- Upstream moved the `agent-browser-access` setting onto its new
`/settings/projects` page. `settingsSearch.ts` points that item there
and drops
  a fork delta.

## Two things a clean merge did not show

**Upstream can delete an export the fork still imports.** pingdotgg#10225 removed
`ClientTracingLive` as unused. `apps/web/src/lib/runtime.ts` still
installs it,
and neither file conflicted, so the typecheck failed four ways on a
merge git
called clean. Restored with a `// Fork:` comment naming the consumer.

**A green test step can hide a suite that never finished.** `vp run -r
test`
kills the packages still running when one of them fails. A
`@t3tools/desktop`
failure truncated `apps/web` and `@t3tools/mobile` after each had
reported
hundreds of passing files, and `verify.mjs` counted any package with
labeled
output as tested. Four failing web tests went unreported. The check now
keys on
the closing `Test Files` line and runs every unfinished package alone.

## Unsupported methods

`unsupported-methods.mjs` reports 0 ADD, 0 DROP, 2 KEEP, against 61
dispatched
backend methods and 131 contract methods.

Getting there took a fix. The backend moved its dispatch from
`crates/t3code/src/lib.rs` to `crates/t3code/src/rpc/dispatch.rs`, where
every
arm is a one-line call into a handler below the match. The script read
the old
path and reported zero dispatched methods, then read the new one and
called
`vcs.switchRef` a DROP, because the `unsupported_exit` that refuses it
had moved
out of the arm. It now tries both paths and follows an arm two calls
deep.

Contract changes: `provider.consumeResetCredit` and
`server.getHostResources`
gained `UnsupportedMethodError`; `server.getUsageSummary` lost it, which
closes
the item the previous merge left open.

## Feature classification

**Usable as-is** — client-only, nothing new on the wire. Sidebar drag
across
sections with destination cues and a named drop action (pingdotgg#9731, pingdotgg#9750,
pingdotgg#10378,
pingdotgg#10453, pingdotgg#10464). Composer behavior: a multiline draft survives timeline
scrolling (pingdotgg#10444), the composer stops collapsing on blur (pingdotgg#10437) and
regains
focus when you tab back (pingdotgg#10463). Panel and preview chrome: resize the
floating
preview from any edge (pingdotgg#10467), toolbar controls stay anchored (pingdotgg#10478),
the
stuck resize cursor clears (pingdotgg#10461), the browser hides as the right
panel closes
(pingdotgg#10385), manual panel choices hold during a turn (pingdotgg#10113). Settings and
accessibility polish (pingdotgg#10177, pingdotgg#10262, pingdotgg#10415, pingdotgg#10258, pingdotgg#10124, pingdotgg#10125,
pingdotgg#10127,
pingdotgg#10128, pingdotgg#10175). Performance (pingdotgg#10413, pingdotgg#10190, pingdotgg#10118). Plus the GitHub
mark on
`github.com` links (pingdotgg#10324), the Tux icon for WSL (pingdotgg#8511), a remembered
usage
page selection (pingdotgg#10189), project settings in the legacy sidebar menu
(pingdotgg#10021),
and text-only preview snapshots (pingdotgg#10232).

**Unsupported in Moatless** — resolves to a refusal, or falls through to
its own
empty state. Each is recorded in `docs/fork/gaps.md`:

- Reset credits through the hub and CLIProxyAPI (pingdotgg#10462, pingdotgg#10395,
pingdotgg#10308).
`provider.consumeResetCredit`, new union entry. `UsageLimits.tsx`
catches the
  refusal and shows "Could not use the reset credit."
- Balancing new threads across connected machines (pingdotgg#9895, pingdotgg#10433,
pingdotgg#10407).
`server.getHostResources`, new union entry. Nothing polls until a user
picks
automatic routing, and the composer then reads "Auto balance
unavailable."
- Onboarding: import grouped by repository (pingdotgg#10493), the shared
multi-computer
  wizard (pingdotgg#10465), agent install without Node or npm (pingdotgg#10402). All ride
  `agentSessions.scan` and `.import`, an existing gap.
- Shared project defaults and scoped overrides (pingdotgg#9754). The page reads,
and every
  write goes through `server.updateSettings`, which the backend does not
  dispatch.
- Two new `orchestration.dispatchCommand` types: `thread.active.reorder`
(pingdotgg#9729)
and `thread.user-input.dismiss` (pingdotgg#10431). Both are ordinary controls, a
sidebar
drag and a Dismiss button, and a dispatched command cannot be refused
per type.
That is the standing _A command cannot be refused_ gap, now 26 members
wide.

**Backend behavior to consider reproducing in Moatless** — upstream
server fixes
whose behavior the fork's client assumes:

- Invalid script IDs no longer crash threads (pingdotgg#10019). The fork ships
project
  scripts, so this one is worth reading first.
- Settlement: settle inactive threads without a PR lookup (pingdotgg#10103), skip
disabled
settlement lookups (pingdotgg#10424), settle threads with unanswered async
questions
  (pingdotgg#10400).
- Interrupted threads stay resumable after a restart (pingdotgg#10421).
- Completed requests stay closed across clients (pingdotgg#10123).
- Placeholder branches are followed after a checkout updates (pingdotgg#10441).
- A thread's PR links without an open client (pingdotgg#10101), and checkpoints
are
  captured before a PR status refresh (pingdotgg#10347).
- Adapters declare their own context compaction (pingdotgg#10112).
- Transcripts with oversized tool records import (pingdotgg#10430), and git
status scans
  are skipped while the index is locked (pingdotgg#9845).
- Usage limits pool per provider across accounts and environments
(pingdotgg#10300). The
client renders what `server.getUsageSummary` returns, so this shows
something
  only if the Moatless payload carries per-account limits.

Mobile, marketing, desktop, provider adapters and release tooling are
not this
fork's surface and are not classified.

## Also fixed here, and not upstream's doing

- Three `browser-*` search items still routed to
`/settings/integrations`, which
the fork owns for its Moatless administration page. A non-administrator
who
  searched for them was redirected away from the result.
- `moatless/listSearch.ts` carried no fork-only declaration.
- `pnpm fmt:check` failed on 294 files, 293 of them orval output. The
generator
  now formats what it writes through an `afterAllFilesWrite` hook.
- `@t3tools/moatless-api` exported `./generated`, a barrel that is never
checked
  in.

## Verification

`inventory-check.mjs` clean. `verify.mjs` green on seven checks:
duplicate-adds,
tripwires, resolution-check, unsupported-methods, `fmt:check` (3876
files),
`lint` and `typecheck`.

`test` is red on one package, and it is the machine.
`@t3tools/desktop`'s
`bundled libsecret helper` shells out to `pkg-config` for `libsecret-1`,
which
this sandbox does not have; it fails the same way when retried alone.
Everything
else passes: `apps/web` 369 files, `t3` 291, `@t3tools/mobile` 149,
`t3code-relay` 27, `@t3tools/client-runtime` 71, plus the smaller
packages.

`spec:check` cannot run in a sandbox: it needs a sibling `moatless`
checkout or a
deployment URL and has neither.

Written by Claude Opus 5 in Claude Code.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---
Moatless task:
https://moatless.soaplabstest.com/tasks/8d348ecf-f9cb-4e65-b96b-6c1054a8ed33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant