feat(mobile): use Android wallpaper colors - #10691
Conversation
There was a problem hiding this comment.
All clear
Posted via Macroscope — Effect Service Conventions
This comment has been minimized.
This comment has been minimized.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR adds a new Material You theme with Android dynamic-color integration across appearance state, previews, terminal styling, and native editor selection controls. Although existing defaults remain unchanged and the feature is user-selected, the cross-layer platform integration and substantial palette/runtime logic warrant human review. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (9)
🚧 Files skipped from review as they are similar to previous changes (1)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughThe mobile app adds Android Material You support. It reads system palettes, converts them into appearance-specific theme variables, applies them to previews and UI, and passes the active primary color to the native editor for selection styling. ChangesMaterial You system colors
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This adds opt-in Android 12+ wallpaper-based system colors while preserving separate saved light and dark themes. The supplied implementation and coverage indicate the setting, appearance switching, previews, and fallback behavior are ready to merge. Sequence Diagram(s)sequenceDiagram
participant AppearanceSettings
participant AppearancePreferencesProvider
participant AndroidSystemColors
participant ThemeConverter
participant NativeEditor
AppearanceSettings->>AppearancePreferencesProvider: select Material You
AppearancePreferencesProvider->>AndroidSystemColors: read light and dark palettes
AndroidSystemColors-->>AppearancePreferencesProvider: return system palettes
AppearancePreferencesProvider->>ThemeConverter: convert palette for each appearance
ThemeConverter-->>AppearancePreferencesProvider: return theme variables
AppearancePreferencesProvider->>NativeEditor: provide active primary color
NativeEditor->>NativeEditor: apply selection styling
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 7.41% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 27 functions across 17 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
f23169c to
59f0112
Compare
59f0112 to
b62ffde
Compare
There was a problem hiding this comment.
All clear
Posted via Macroscope — Effect Service Conventions
## What's Changed * feat(web): accept file drops into sidebar threads by @UtkarshUsername in pingdotgg/t3code#7892 * fix(mcp): keep preview snapshots usable by the agent and let it save them by @t3dotgg in pingdotgg/t3code#10501 * fix(server): stop Windows terminal processes when closing by @SunkenInTime in pingdotgg/t3code#10771 * feat(mobile): use Android wallpaper colors by @juliusmarminge in pingdotgg/t3code#10691 * feat(mobile): add optional Material You layout by @juliusmarminge in pingdotgg/t3code#10692 * feat(web): show project favicon in new-thread project picker by @gsimone in pingdotgg/t3code#10790 * fix(desktop): use official logo in macOS installer by @t3-code[bot] in pingdotgg/t3code#10819 **Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260908.1400...v0.0.41-nightly.20260908.1414 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260908.1414
Android users can select Material You alongside T3 Code, T3 Chat, and the other themes on Android 12+. It uses the live wallpaper palette, with independent light and dark choices. Selecting another theme immediately replaces wallpaper colors. The preview reflects the current Android palette, which refreshes when the app regains focus.
Continues Alex / @PixPMusic's system-color work from #6081, retaining the original author on the ported commit. The optional layout is separate in #10692.
Verified on an Android API 36 emulator with a disposable environment and seeded conversation:
Model: GPT-6 | Harness: Codex in T3 Code
Note
Add
material-youtheme and Android wallpaper colors to mobilematerial-youtheme that derives mobile runtime variables from Android dynamic-color palettes in AppearancePreferencesProvider.tsxT3ComposerEditorViewnative bridge to use the Material You primary color for text selection, cursor, and handle tinting on Android Q+parseColorto convert CSSRRGGBBAAto AndroidAARRGGBBorder so eight-digit colors render with correct opacityThemeAppearanceSectionhides thematerial-youtheme option when the platform does not support system colorsMacroscope summarized b62ffde.
Summary by CodeRabbit