Skip to content

fix(web): show pointer cursors on pull request controls - #11283

Merged
maria-rcks merged 1 commit into
mainfrom
fix/web-pr-pointer-cursors
Sep 11, 2026
Merged

fix(web): show pointer cursors on pull request controls#11283
maria-rcks merged 1 commit into
mainfrom
fix/web-pr-pointer-cursors

Conversation

@shivamhwp

@shivamhwp shivamhwp commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

What changed

Pull request rows, linked CI checks and timeline commits now show a pointer cursor when hovered. Checks without a URL keep the default cursor. The Summary, Timeline and Code tabs already inherit pointer styling from Toggle.

Why

These controls opened a review, check or commit while displaying the ordinary cursor, making their click targets harder to recognize.

Fixes #7606

UI changes

Before

PR row with the default cursor

After

PR row with the pointer cursor

Validation

Verified the live PR row changes from computed cursor default to pointer; screenshots include the actual cursor in an isolated Linux window. Web typecheck passes. Scoped lint has one existing array-index-key warning.

The detail panel returned a GitHub CLI error in this environment, so linked-check and timeline cursor changes were inspected in source but not exercised in that panel. Web and desktop share these components. Mobile uses a separate touch UI. No action handlers, contracts, provider behavior or connection handling changed.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for UI changes

Model: GPT-6. Harness: Codex in T3 Code.

Summary by CodeRabbit

  • Style
    • Updated hover cursors across pull request rows, checks with available links, and timeline commit events to clearly indicate clickable elements.
    • Preserved the default cursor for checks without links.
    • Improved pull request title-row indicators by displaying approval status and check details alongside the title.
    • Approved pull requests now use the approval glyph, while “Changes requested” remains highlighted in amber.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 11, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 3c01874

Macroscope's review found this PR approvable — This three-file change only improves pointer-cursor affordances on existing pull request controls. It does not alter handlers, disabled states, data flow, or other runtime behavior.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6012e1cc-87f9-4821-9156-1741fcda4c69

📥 Commits

Reviewing files that changed from the base of the PR and between f2dd98d and 3c01874.

📒 Files selected for processing (2)
  • apps/web/src/components/pullRequest/PullRequestRow.tsx
  • apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Pull request rows now display approval and checks indicators in the title row. Interactive pull request controls now use pointer cursors. Checks without URLs retain the default cursor.

Changes

Pull request presentation updates

Layer / File(s) Summary
Title-row approval and checks indicators
apps/web/src/components/pullRequest/PullRequestRow.tsx
Approved verdicts use PullRequestApprovalGlyph. The checks popover and verdict display move to the title row.
Clickable control cursor states
apps/web/src/components/pullRequest/PullRequestRow.tsx, apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx, apps/web/src/components/pullRequest/PullRequestTimelineTab.tsx
Pull request rows, checks with URLs, and commit event buttons now use cursor-pointer. Checks without URLs retain cursor-default.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 3c018

The change is limited to pull request presentation and cursor styling, with typecheck passing.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding pointer cursors to pull request controls.
Description check ✅ Passed The description includes the change, rationale, UI screenshots, validation details, issue reference, and checklist. It is focused and matches the pull request objectives.
Linked Issues check ✅ Passed Issue #7606 requires pointer cursors for clickable controls in pull request screens. The reviewed diff adds cursor-pointer to pull request rows, checks that have URLs, and timeline commit buttons. C…
Out of Scope Changes check ✅ Passed The reviewed changes address cursor feedback for the pull request controls named by issue #7606. The focused diff confirms that PullRequestRow.tsx changes only the row utility classes. The other rep…
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/web-pr-pointer-cursors

Comment @coderabbitai help to get the list of available commands.

@shivamhwp
shivamhwp force-pushed the fix/web-pr-pointer-cursors branch from f2dd98d to 3c01874 Compare September 11, 2026 19:27
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 11, 2026 19:27

Dismissing prior approval to re-evaluate 3c01874

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.6 KiB 13.6 KiB 0 B (0.0%) 15.1 KiB
Codex Thread snapshot wire 7.0 KiB 7.0 KiB −2 B (−0.0%) 7.3 KiB
Codex Live turn WebSocket wire 6.5 KiB 6.5 KiB +2 B (+0.0%) 7.8 KiB
Codex Live turn WebSocket decoded 57.0 KiB 57.0 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 8 8 0 (0.0%) 21
Claude Total thread wire 13.6 KiB 13.6 KiB +11 B (+0.1%) 15.1 KiB
Claude Thread snapshot wire 7.1 KiB 7.1 KiB −1 B (−0.0%) 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 6.5 KiB +12 B (+0.2%) 7.8 KiB
Claude Live turn WebSocket decoded 57.8 KiB 57.8 KiB +44 B (+0.1%) 66.4 KiB
Claude Live turn messages 8 9 +1 (+12.5%) 21

Baseline: 7bd7f99 · PR result: 3c01874 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@maria-rcks
maria-rcks merged commit 8711929 into main Sep 11, 2026
24 checks passed
@maria-rcks
maria-rcks deleted the fix/web-pr-pointer-cursors branch September 11, 2026 23:20
aorwall added a commit to aorwall/t3code that referenced this pull request Sep 12, 2026
Merges `upstream/main` at `e81606494` into the fork, from merge base
`02297e3db` — 47 upstream commits.

The theme of this range is scopable settings: upstream made every server
setting addressable at a scope (global / environment / project) with
per-project overrides, which is why 11 of the 15 conflicts are settings
files. The rest is conversation rewind, floating device streams, and a
large batch of message-sync and markdown-streaming perf work.

## Merge stats

- Landed (`HEAD^1..HEAD`): 277 files, 17243+/4783−
- Upstream range (base..`HEAD^2`): 275 files, 17011+/4749−
- Fork delta (`HEAD^2..HEAD`): 756 files, 76559+/2096−

The two file lists reconcile: the 3 extra landed files are
`docs/fork/inventory.json`, `docs/fork/upstream-merge-log.md` and
`docs/fork/gaps.md`; the 1 file in the range that did not land is
`apps/web/src/routes/settings.integrations.tsx`, resolved `ours` per the
`moatless-admin-integrations-route` inventory entry (that route is a
Moatless admin page here, and upstream's embedded-surface settings live
at `/settings/browser`).

All 15 conflicts were resolved by the verdict `preflight.mjs` printed.
No `decide` conflict was left unresolved. Details, including the
owned-concern sweep (no keyword hits) and the unsupported-method
reconciliation (0 ADD, 0 DROP, 2 KEEP, 4 known exceptions), are in the
dated entry in `docs/fork/upstream-merge-log.md`.

Two findings worth naming here:

- **A silent auto-merge failure.** pingdotgg#11285 changed the mini-player target
from a tab id to a source union. Git updated upstream's own assertion in
`PreviewView.test.tsx` and left the fork-only "under the frame
capability" case next to it still asserting the old string. No conflict
marker, no `resolution-check.mjs` finding — only the fork's own test
suite caught it.
- **Stale inventory anchors.** Upstream moved the project Actions
section out of `ProjectSettingsPanel.tsx` into a new
`ProjectActionsSettings.tsx`, which is where `scriptsEditable` is now
derived and where upstream's new writing Reset button is gated. Four
inventory entries were re-pointed in this merge rather than silently
dropping their deltas.

## Usable as-is

Client work the fork can expose with no Moatless backend change:

- Scoped settings UI and the two-select scope picker (pingdotgg#10639, pingdotgg#10636) —
`SettingsScopeContext`, `ScopedSwitch`, `settingKeys`, the `mixed`
state. The reading half works against Moatless today.
- Float device streams over chat, as a source union rather than a tab id
(pingdotgg#11285); recording status on floating previews (pingdotgg#11312); floating
preview using composer margins (pingdotgg#11290).
- PR-page selections into new drafts (pingdotgg#11296);
projects-on-another-machine badge (pingdotgg#11323); Usage opening on Limits
(pingdotgg#11261).
- macOS permission onboarding (pingdotgg#11289); hold-to-quit fix (pingdotgg#11016);
preview keystrokes kept out of the composer (pingdotgg#11354).
- Message-sync and markdown-streaming perf: pingdotgg#11302, pingdotgg#11029, pingdotgg#11211,
pingdotgg#11198, pingdotgg#11196, pingdotgg#11193, pingdotgg#11181, pingdotgg#11206.
- Assorted web/mobile fixes: pingdotgg#11361, pingdotgg#10757, pingdotgg#11357, pingdotgg#10571, pingdotgg#11348,
pingdotgg#11349, pingdotgg#11281, pingdotgg#11188, pingdotgg#11283, pingdotgg#11292, pingdotgg#11187, pingdotgg#11228, pingdotgg#11103, pingdotgg#10612,
pingdotgg#11032, pingdotgg#11233, pingdotgg#11234, pingdotgg#11304, pingdotgg#11240.

## Unsupported in Moatless / needs implementation

- **Conversation rewind** — `thread.conversation.revert` (pingdotgg#11358). A new
member of `DispatchableClientOrchestrationCommand` in
`packages/contracts/src/orchestration.ts`, bringing the fork to 30
command types (28 upstream's, 2 fork-only). Moatless does not dispatch
it, and a client command cannot be refused per-type, so "Edit from here"
on `RevertUserMessageButton` is reachable whenever the turn is idle and
does nothing. Needs backend dispatch.
- **Per-project setting overrides** — the `projectSettingsOverrides`
capability and the 17-key `ProjectSettingsOverrides` record (pingdotgg#11176).
Two pieces are needed: the capability reported by
`/.well-known/t3/environment`, and `server.updateSettings` served at
project scope. Until both land, the capability filter in
`scopedSettings.ts:170` and `ProjectActionsSettings.tsx:72` drops the
write on the client — the control renders, the user toggles it, and
**the write never leaves the browser**. A silent no-op is worse than a
hidden control or an honest refusal; recorded in `docs/fork/gaps.md`.
- **Default thread permissions** — `defaultRuntimeMode` (pingdotgg#11346). Reads
fine, cannot be saved. Same `server.updateSettings` write path as above,
one level deeper, not a separate gap.

## Backend behavior to consider reproducing in Moatless

Upstream server-side work the fork cannot use directly, but that
Moatless would benefit from:

- **Queue messages during context compaction** (pingdotgg#11107,
`ProviderCommandReactor.ts`) — a message sent while compaction is in
flight is currently dropped rather than held.
- **Restore provider history and prompts when rewinding** (pingdotgg#11338,
`CheckpointReactor.ts`) — the counterpart to
`thread.conversation.revert` above; rewinding the thread without
rewinding provider state leaves the two out of sync.
- **Detect file renames in review diffs** (pingdotgg#8086,
`apps/server/src/vcs/GitVcsDriverCore.ts`) — a rename currently reads as
a whole-file delete plus a whole-file add.
- **Preserve qualified Codex model ids** (pingdotgg#9921, `ModelManifest.ts` +
`CodexTextGeneration.ts`).
- **Model defaults** astra-medium / fable-5.1-medium (pingdotgg#11347).

All five are recorded under the runtime-fixes entry in
`docs/fork/gaps.md`.

## Verification

`verify.mjs` (full pass): 7 of 8 checks green — `duplicate-adds`,
`tripwires`, `resolution-check`, `unsupported-methods`, `fmt:check`,
`lint`, `typecheck`.

`test` is red on **`@t3tools/desktop` only**, at
`scripts/browser-secret-native.test.mjs > bundled libsecret helper`:
`Command failed: pkg-config --cflags --libs libsecret-1`. This is the
standing sandbox gap, not a merge regression — the test file's last
commit is `498ab9c39` (pingdotgg#7261, before the merge base), `git diff
--name-only` against both merge parents is empty for it, and `pkg-config
--exists libsecret-1` fails in this environment. It is already an entry
in `docs/fork/gaps.md`. Every other package passes, including
`@t3tools/web` (5079 tests) after the `PreviewView.test.tsx` fix above.

Three typecheck failures the merge introduced were fixed in it:
`SETTINGS_CATEGORY_SCOPES` in `settingsSearch.ts` was missing all 9
fork-only settings paths, and two `filterAvailableSettingsSearchItems`
literals in `settingsSearch.test.ts` were missing the fork's
`forgejoEnabled` field.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---
Moatless task:
https://moatless.soaplabstest.com/tasks/e70b41b3-779d-43b8-8f34-7de516548e7c
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 12, 2026
## What's Changed
* feat(web): show recording status on floating previews by @maria-rcks in pingdotgg/t3code#11312
* fix(desktop): hold-to-quit no longer strands the quit by @maria-rcks in pingdotgg/t3code#11016
* feat(web): mark projects on another machine in project pickers by @maria-rcks in pingdotgg/t3code#11323
* fix(web): show pointer cursors on pull request controls by @shivamhwp in pingdotgg/t3code#11283
* fix(web): themed panel toggles show their disabled state by @flamboh in pingdotgg/t3code#11188
* fix(web): use branch wording in commit dialogs by @shivamhwp in pingdotgg/t3code#11281
* fix(mobile): keep Android file icons on the line with wrapped filenames by @SunkenInTime in pingdotgg/t3code#11234
* fix(codex): preserve qualified model ids in selection and generation by @maria-rcks in pingdotgg/t3code#9921
* feat(desktop): share macOS permission onboarding by @juliusmarminge in pingdotgg/t3code#11289
* fix(test): drain worker broadcasts before restoring browser globals by @maria-rcks in pingdotgg/t3code#11349
* fix(web): disable linked pull requests when none are linked by @maria-rcks in pingdotgg/t3code#11348
* fix(models): default to astra medium and fable 5.1 medium by @maria-rcks in pingdotgg/t3code#11347
* fix(web): align provider settings with shared settings rows by @maria-rcks in pingdotgg/t3code#10571
* feat(settings): configure default permissions for new threads by @maria-rcks in pingdotgg/t3code#11346
* fix: restore provider history and prompts when rewinding by @maria-rcks in pingdotgg/t3code#11338
* fix(web): keep comment actions visible when pr comments are folded by @maria-rcks in pingdotgg/t3code#11357
* feat: rewind conversations while keeping file changes by @maria-rcks in pingdotgg/t3code#11358
* fix(web): keep sidebar scroll position when pinning threads by @saphid in pingdotgg/t3code#10757
* fix(web): remove pr description reactions by @maria-rcks in pingdotgg/t3code#11361
* fix(desktop): keep preview keystrokes out of the composer by @maria-rcks in pingdotgg/t3code#11354


**Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260911.1564...v0.0.41-nightly.20260912.1576

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260912.1576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Pull request screens are missing pointer cursors on clickable elements

2 participants