refactor(server): classify preview toolkit exports - #10281
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small server-internal refactor that hides unused preview implementation symbols while preserving the exported toolkits and the existing standard/snapshot registration paths. No product defaults, runtime schemas, deployment behavior, or static-analysis configuration are changed. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
340a302 to
bde41cd
Compare
bde41cd to
72f32c8
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe preview toolkit narrows its exported API. Individual preview tools remain available internally, and the combined live handler export is removed. ChangesPreview toolkit exports
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Preview toolkit internals are no longer publicly exported while existing toolkit behavior remains unchanged. No current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
72f32c8 to
eb192a3
Compare
eb192a3 to
210288f
Compare
## What's Changed * feat(chat): attach files to question answers by @shivamhwp in pingdotgg/t3code#9871 * feat(desktop): refresh macOS installer with aurora artwork by @saphid in pingdotgg/t3code#10632 * fix(server): give completed turns a full session idle window by @StiensWout in pingdotgg/t3code#10689 * feat(web): add pull request merge defaults by @Bil0000 in pingdotgg/t3code#8088 * fix(usage): keep account columns aligned across limit rows by @juliusmarminge in pingdotgg/t3code#10690 * fix(web): chat text no longer shows through a 1px gap under composer banners by @vitalyiegorov in pingdotgg/t3code#10635 * refactor(server): classify runtime exports by @juliusmarminge in pingdotgg/t3code#10274 * refactor(server): classify orchestration exports by @juliusmarminge in pingdotgg/t3code#10275 * refactor(server): classify service exports by @juliusmarminge in pingdotgg/t3code#10276 * refactor(server): classify telemetry exports by @juliusmarminge in pingdotgg/t3code#10277 * refactor(server): classify provider exports by @juliusmarminge in pingdotgg/t3code#10278 * refactor(server): classify source control exports by @juliusmarminge in pingdotgg/t3code#10279 * refactor(server): classify source control registry API by @juliusmarminge in pingdotgg/t3code#10280 * refactor(server): classify preview toolkit exports by @juliusmarminge in pingdotgg/t3code#10281 * ci(knip): enforce server exports by @juliusmarminge in pingdotgg/t3code#10282 * feat(web): add previous/next turn navigation in minimap by @UtkarshUsername in pingdotgg/t3code#8531 * fix(web): stop the settings sidebar shifting when switching pages by @t3dotgg in pingdotgg/t3code#10705 * fix(web): copy terminal selection with Ctrl+Insert by @iamshadmantaqi in pingdotgg/t3code#8541 * fix(web): show the same project icon in the command palette as everywhere else by @t3dotgg in pingdotgg/t3code#10712 * fix(web): stop sidebar rows flashing and shifting on click by @t3dotgg in pingdotgg/t3code#10713 * refactor(web): pass the project record to ProjectFavicon so icons cannot drift by @t3dotgg in pingdotgg/t3code#10714 ## New Contributors * @iamshadmantaqi made their first contribution in pingdotgg/t3code#8541 **Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260908.1387...v0.0.41-nightly.20260908.1400 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260908.1400
The MCP preview toolkit had 14 unclassified runtime exports. This keeps each tool definition private to its toolkit assembly and removes the unused broad handler layer while retaining the standard and snapshot handler layers used by the server.
This is layer 8 of 9 in the server Knip cleanup stack.
Verification after rebasing onto current main: server typecheck and the server-only Knip export audit pass. Changed-file lint and formatting pass, with one existing lint warning. Focused auth, provider, source-control, preview toolkit, orchestration, and Knip preprocessor tests pass: 90 tests across 9 files. This changes server export visibility and static analysis; screenshots do not apply.
Model: gpt-6 astra. Harness: Codex in T3 Code.
Summary by CodeRabbit