refactor(web): pass the project record to ProjectFavicon so icons cannot drift

[t3dotgg]

Follow-up to #10712. `ProjectFavicon` took five loose props, and any call site could hand it a display label as the title. The automatic icon is derived from the title, so one wrong string changed the icon on that surface only. That is exactly how the command palette drifted from the sidebar.

`ProjectFavicon` now takes one `project` prop typed as a Pick of the project record (environment, workspace root, title, favicon path, icon override). Every call site passes the record itself, so the saved title and icon override always travel together. Sidebar rows, drafts, the chat header, the command palette subtitle, the PR filter menu, and the archive panel drop their per-field plumbing and pass the project through. Sidebar goes from four per-field lookup maps to one.

Behavior is unchanged where a project exists. Rows with no matching project record used to render a generic icon from an empty title. They now render no icon.

Verified with the web typecheck, lint on the touched files, and the favicon, command palette, chat header, and PR filter test files.

Created with Claude Fable 5.1 in Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Refactor
  • Project icons and metadata are now handled consistently using complete project details across chat, sidebars, command menus, pull request filters, and settings.
  • Project breadcrumbs, archived threads, and filter options continue to display the correct project names, paths, and icons.
• Tests
  • Updated project icon coverage to reflect the unified project data handling.

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.6 KiB	−18 B (−0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−2 B (−0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.6 KiB	6.6 KiB	−16 B (−0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	57.1 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.6 KiB	+12 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+2 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.6 KiB	+10 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.9 KiB	+44 B (+0.1%)	66.4 KiB	✅
Claude	Live turn messages	9	10	+1 (+11.1%)	21	✅

Baseline: d7a59c6 · PR result: e05ab14 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.9 KiB
• Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at e05ab14

Macroscope's review found this PR approvable — This is a focused web refactor and low-risk UI consistency fix: ProjectFavicon now receives the canonical project data so saved titles, favicon paths, and icon overrides cannot drift between surfaces. Existing project behavior is preserved aside from correcting mismatched automatic icons, with focused tests covering the component behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 8de29b69-393a-45dd-995c-082a592acc8b

📥 Commits

Reviewing files that changed from the base of the PR and between d7a59c6 and e05ab14.

📒 Files selected for processing (12)

• apps/web/src/components/ChatView.tsx
• apps/web/src/components/CommandPalette.tsx
• apps/web/src/components/LegacySidebar.tsx
• apps/web/src/components/ProjectFavicon.test.tsx
• apps/web/src/components/ProjectFavicon.tsx
• apps/web/src/components/Sidebar.tsx
• apps/web/src/components/ThreadCommandSubtitle.tsx
• apps/web/src/components/chat/ChatHeader.tsx
• apps/web/src/components/pullRequest/PullRequestListFilters.tsx
• apps/web/src/components/settings/ProjectSettingsPanel.tsx
• apps/web/src/components/settings/ProjectsSettings.tsx
• apps/web/src/components/settings/SettingsPanels.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.

---

📝 Walkthrough

Walkthrough

ProjectFavicon now accepts a consolidated project object. Chat, sidebar, command palette, pull request filters, and settings components pass full project records instead of separate metadata fields. Tests use the new typed contract.

Changes

Project metadata consolidation

Layer / File(s)	Summary
Consolidated favicon contract apps/web/src/components/ProjectFavicon.tsx, apps/web/src/components/ThreadCommandSubtitle.tsx, apps/web/src/components/chat/ChatHeader.tsx, apps/web/src/components/ChatView.tsx, apps/web/src/components/ProjectFavicon.test.tsx	ProjectFaviconProject groups project metadata. ProjectFavicon, ThreadCommandSubtitle, and ChatHeader use project objects. Tests update all component calls and assertions.
Sidebar and command-palette wiring apps/web/src/components/Sidebar.tsx, apps/web/src/components/CommandPalette.tsx, apps/web/src/components/LegacySidebar.tsx	Project lookup maps now store full project records. Sidebar rows, tooltips, search results, command-palette items, and workspace resolution use those records.
Filters and settings consumers apps/web/src/components/pullRequest/PullRequestListFilters.tsx, apps/web/src/components/settings/ProjectSettingsPanel.tsx, apps/web/src/components/settings/ProjectsSettings.tsx, apps/web/src/components/settings/SettingsPanels.tsx	Filter options and settings views pass project objects to ProjectFavicon. Archived project records retain the full project shape.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to e05ab

Project favicon rendering now receives cohesive project records across the application, preserving existing behavior for known projects while omitting icons when no project is available. No current merge-blocking risk remains.

Suggested reviewers: saphid, stienswout, juliusmarminge

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 16 functions across 12 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main refactor: passing the project record to ProjectFavicon to prevent icon drift.
Description check	✅ Passed	The description explains what changed, why it changed, affected call sites, behavior differences, and verification steps. It does not include the template headings or checklist, but the required subst…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/project-favicon-object

---

_{Comment @coderabbitai help to get the list of available commands.}