fix(server): settle inactive threads without a PR lookup

[t3dotgg]

A failed or stalled pull request lookup kept inactive threads unsettled, even when they already met the inactivity limit.

Check inactivity before host lookups. Only threads that still need PR state enter the lookup groups. Keep the existing activity timestamp, current settings check, and stale-snapshot guard.

Verified with 25 settlement policy and reactor tests, the server typecheck, and scoped lint and formatting. The new unavailable-host test fails against the original source. A shared-lookup test confirms that the inactive thread settles while the recent thread waits for its host result.

Startup readiness and PR terminal timestamp rules are unchanged.

Created with GPT-6 Astra in Codex.

Note

Settle inactive threads without pull request lookup in ThreadSettlementReactor

• Inactive threads are now settled without reading Git or pull-request host state, so settlement does not wait on host availability or PR lookups.
• Updates ThreadSettlementReactor tests to give recent user-message timestamps to threads that must stay active for PR-related paths, while inactive threads exercise the no-lookup settlement path.
• Added tests verify that inactive linked and branch threads settle without invoking Git or PR operations, and that an inactive thread settles while a shared PR lookup is still pending.
• Behavioral Change: inactive threads are settled before the PR/branch lookup pass runs; callers relying on PR lookup happening for already-inactive threads will see those lookups skipped.

^{Macroscope summarized c152498.}

[macroscopeapp]

Approvability

Verdict: Approved at 6590227

Macroscope's review found this PR approvable — This is a focused server bug fix that reuses the existing inactivity policy to settle eligible threads before network or host-dependent pull-request lookups. Existing lookup behavior remains for threads that still require pull-request state, and targeted tests cover unavailable and delayed lookup scenarios.

No code changes detected at c152498. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.6 KiB	+71 B (+0.5%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	0 B (0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.6 KiB	+71 B (+1.1%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.1 KiB	+88 B (+0.2%)	66.4 KiB	✅
Codex	Live turn messages	8	10	+2 (+25.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.6 KiB	+12 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	0 B (0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.6 KiB	+12 B (+0.2%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	57.9 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 7544d3d · PR result: c152498 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.