fix(server): link thread PRs without an open client - #10101
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR introduces an always-on server reactor that discovers and persists branch pull requests, changes automatic settlement behavior, and propagates new state through migrations, orchestration, web, and mobile clients. Its cross-layer runtime impact and default-on background activity require human review. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
fad79ef to
d8dd9be
Compare
d8dd9be to
0d90c12
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
The startup backfill kept every settled thread without a saved PR link in a retry set until a lookup succeeded. A machine without gh, a logged-out CLI, or a removed remote would run a git spawn per settled branch every minute forever. Real userdata has about 700 such threads. Each settled thread now gets a bounded number of backfill attempts. Skips for a missing project or repository identity count as finished. Unsettled threads and threads with new events are unaffected. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
## What's Changed * feat(usage): pool subscription limits per provider across accounts and environments by @juliusmarminge in pingdotgg/t3code#10300 * chore(web): remove usage limits demo fixtures by @juliusmarminge in pingdotgg/t3code#10330 * fix(web): expose error disclosure state by @saphid in pingdotgg/t3code#10125 * fix(web): name the editor picker accurately by @saphid in pingdotgg/t3code#10124 * fix(web): make task row states readable by @saphid in pingdotgg/t3code#10128 * fix(web): explain hosted connection prerequisites by @saphid in pingdotgg/t3code#10129 * fix(web): name combobox chip removal targets by @saphid in pingdotgg/t3code#10127 * fix(marketing): present the Git workflow as an illustration by @saphid in pingdotgg/t3code#10130 * feat(mobile): pool usage limits across selected environments by @juliusmarminge in pingdotgg/t3code#10334 * fix(release): space automatic nightlies at least six hours apart by @t3dotgg in pingdotgg/t3code#10272 * refactor(web): share bulk thread deletion between sidebars by @t3dotgg in pingdotgg/t3code#10106 * refactor(client): share tool outcome rules by @t3dotgg in pingdotgg/t3code#10122 * refactor(server): share Claude result status and error mapping by @t3dotgg in pingdotgg/t3code#10296 * fix(server): settle inactive threads without a PR lookup by @t3dotgg in pingdotgg/t3code#10103 * fix(ssh): report remote stop failures without losing ownership by @t3dotgg in pingdotgg/t3code#10105 * perf(server): stop scanning old OpenCode parts by @t3dotgg in pingdotgg/t3code#10116 * perf(server): avoid full thread reads on turn start by @t3dotgg in pingdotgg/t3code#10108 * perf(web): skip checkpoint map rebuilds while streaming by @t3dotgg in pingdotgg/t3code#10118 * perf(server): skip plan bodies in thread summaries by @t3dotgg in pingdotgg/t3code#10341 * fix(server): skip disabled provider instances for text generation fallback by @t3dotgg in pingdotgg/t3code#10346 * fix(server): capture checkpoints before refreshing PR status by @t3dotgg in pingdotgg/t3code#10347 * fix(web): keep manual panel choices during a turn by @t3dotgg in pingdotgg/t3code#10113 * fix(threads): keep completed requests closed across clients by @t3dotgg in pingdotgg/t3code#10123 * perf(server): finish runtime messages without full thread reads by @t3dotgg in pingdotgg/t3code#10120 * refactor(server): let adapters declare context compaction by @t3dotgg in pingdotgg/t3code#10112 * fix(server): link thread PRs without an open client by @t3dotgg in pingdotgg/t3code#10101 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260906.1293...v0.0.39-nightly.20260906.1303 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260906.1303
Adopts upstream's manual active-thread ordering (pingdotgg#9729) in place of the fork's own implementation, per Sheehan's call. The decider now emits upstream's `thread.meta-updated` with `activeOrderKey` and its guards (reject deleted/pinned/settled, retain the snooze slot, leave updatedAt alone). The fork's `thread.active-reordered` event is no longer emitted, but its schema, projector, ProjectionPipeline and client reducer cases are deliberately RETAINED: shipped fork databases contain those events and replay must keep decoding them. Conflict resolutions worth remembering: - ProjectionSnapshotQuery: upstream's new `getTurnStartMessage` SELECT omitted the fork's message-correction columns that the shared row schema requires, so every turn start failed to decode (`MissingKey`) and took 14 orchestration tests with it. Added original_text, correction_target_message_id, correction_replacement_text and delivery_state to the SELECT. - ProviderCommandReactor: upstream moved turn-start lookups to the projection and switched the handler to a thread SHELL, which carries only a truncated objectivePreview. The fork's Goal Continuation needs the full Objective, so it re-reads the detail on that path only. `buildSendTurnRequestForThread` also loaded the whole transcript eagerly; it now uses the shell and defers the detail read to the hand-off prelude that actually needs it (this is what upstream's "without loading old message bodies" test asserts). - ProviderRuntimeIngestion: the fork's nullable Continuation messageId flowed into upstream's non-null `getThreadMessageById`; guarded. - OpenCodeAdapter: took upstream's `textPartsByMessageId` and dropped partById/emittedTextByPartId/completedAssistantPartIds (no remaining uses), keeping the fork's turns/context-window/compaction fields. - Migrations: upstream's ProjectionThreadBranchPullRequest appended as fork id 52; upstream's ProjectionThreadsActiveOrderKey NOT registered again — it is byte-identical to the fork's already-shipped id 43. - MessagesTimeline.logic: restored the fork's checkpoint-readiness guard that upstream's relocated copy lacked, so Revert stays hidden until a checkpoint is ready; the two fork tests that drove this through the removed revertTurnCountByUserMessageId prop now build a real ready-checkpoint fixture. - threadCommands: removed duplicate ReorderActiveThreadInput/reorderActiveThread declarations left by a keep-both resolution. - Re-exported helpers upstream's Knip sweep privatized but the fork imports: activeThreadAnchorTimestampMs. - Sidebar.tsx keeps the FORK's drag-and-drop subsystem (drag-to-snooze, overlay ghost, force-settle of a running thread, sidebarActiveThreadSortOrder) over upstream's pingdotgg#9731/pingdotgg#9750 rework; upstream's Sidebar.drag.ts/motion.ts are now referenced only by their own tests. - Guard script: upstream pingdotgg#10101 deleted the client-side ThreadChangeRequestSnapshot atom the linked-PR check pointed at, so the check now follows the badge to its new server-provided source. Verification: all packages typecheck; server orchestration+persistence 603/603, client-runtime 1349/1349, contracts 393/393, web unit 4427 pass. The only web failures are the two fork Goal e2e specs, confirmed failing identically on backup/mtcode-pre-upstream-sync-20260906b. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Merges 141 upstream commits (`b438447f6..8b2838e`) into the fork, following the `fork-upstream-merge` skill. Landed as a merge commit; conflicts resolved by the path-policy verdicts in `docs/fork/inventory.json`. ## Merge shape 563 files landed (`git diff --stat HEAD^1 HEAD`) against 563 in the upstream range, so no upstream work was dropped. Fork delta 720 files. ## Conflicts 14 files, resolved by concern. The merge commit message names each. Two are worth carrying forward: - Upstream extracted the project action rows into `ProjectActionsList.tsx`. The fork's Edit gate now rides an `editable` prop that defaults to upstream's always-editable behavior, so the gate survives the next extraction. - Upstream moved the `agent-browser-access` setting onto its new `/settings/projects` page. `settingsSearch.ts` points that item there and drops a fork delta. ## Two things a clean merge did not show **Upstream can delete an export the fork still imports.** pingdotgg#10225 removed `ClientTracingLive` as unused. `apps/web/src/lib/runtime.ts` still installs it, and neither file conflicted, so the typecheck failed four ways on a merge git called clean. Restored with a `// Fork:` comment naming the consumer. **A green test step can hide a suite that never finished.** `vp run -r test` kills the packages still running when one of them fails. A `@t3tools/desktop` failure truncated `apps/web` and `@t3tools/mobile` after each had reported hundreds of passing files, and `verify.mjs` counted any package with labeled output as tested. Four failing web tests went unreported. The check now keys on the closing `Test Files` line and runs every unfinished package alone. ## Unsupported methods `unsupported-methods.mjs` reports 0 ADD, 0 DROP, 2 KEEP, against 61 dispatched backend methods and 131 contract methods. Getting there took a fix. The backend moved its dispatch from `crates/t3code/src/lib.rs` to `crates/t3code/src/rpc/dispatch.rs`, where every arm is a one-line call into a handler below the match. The script read the old path and reported zero dispatched methods, then read the new one and called `vcs.switchRef` a DROP, because the `unsupported_exit` that refuses it had moved out of the arm. It now tries both paths and follows an arm two calls deep. Contract changes: `provider.consumeResetCredit` and `server.getHostResources` gained `UnsupportedMethodError`; `server.getUsageSummary` lost it, which closes the item the previous merge left open. ## Feature classification **Usable as-is** — client-only, nothing new on the wire. Sidebar drag across sections with destination cues and a named drop action (pingdotgg#9731, pingdotgg#9750, pingdotgg#10378, pingdotgg#10453, pingdotgg#10464). Composer behavior: a multiline draft survives timeline scrolling (pingdotgg#10444), the composer stops collapsing on blur (pingdotgg#10437) and regains focus when you tab back (pingdotgg#10463). Panel and preview chrome: resize the floating preview from any edge (pingdotgg#10467), toolbar controls stay anchored (pingdotgg#10478), the stuck resize cursor clears (pingdotgg#10461), the browser hides as the right panel closes (pingdotgg#10385), manual panel choices hold during a turn (pingdotgg#10113). Settings and accessibility polish (pingdotgg#10177, pingdotgg#10262, pingdotgg#10415, pingdotgg#10258, pingdotgg#10124, pingdotgg#10125, pingdotgg#10127, pingdotgg#10128, pingdotgg#10175). Performance (pingdotgg#10413, pingdotgg#10190, pingdotgg#10118). Plus the GitHub mark on `github.com` links (pingdotgg#10324), the Tux icon for WSL (pingdotgg#8511), a remembered usage page selection (pingdotgg#10189), project settings in the legacy sidebar menu (pingdotgg#10021), and text-only preview snapshots (pingdotgg#10232). **Unsupported in Moatless** — resolves to a refusal, or falls through to its own empty state. Each is recorded in `docs/fork/gaps.md`: - Reset credits through the hub and CLIProxyAPI (pingdotgg#10462, pingdotgg#10395, pingdotgg#10308). `provider.consumeResetCredit`, new union entry. `UsageLimits.tsx` catches the refusal and shows "Could not use the reset credit." - Balancing new threads across connected machines (pingdotgg#9895, pingdotgg#10433, pingdotgg#10407). `server.getHostResources`, new union entry. Nothing polls until a user picks automatic routing, and the composer then reads "Auto balance unavailable." - Onboarding: import grouped by repository (pingdotgg#10493), the shared multi-computer wizard (pingdotgg#10465), agent install without Node or npm (pingdotgg#10402). All ride `agentSessions.scan` and `.import`, an existing gap. - Shared project defaults and scoped overrides (pingdotgg#9754). The page reads, and every write goes through `server.updateSettings`, which the backend does not dispatch. - Two new `orchestration.dispatchCommand` types: `thread.active.reorder` (pingdotgg#9729) and `thread.user-input.dismiss` (pingdotgg#10431). Both are ordinary controls, a sidebar drag and a Dismiss button, and a dispatched command cannot be refused per type. That is the standing _A command cannot be refused_ gap, now 26 members wide. **Backend behavior to consider reproducing in Moatless** — upstream server fixes whose behavior the fork's client assumes: - Invalid script IDs no longer crash threads (pingdotgg#10019). The fork ships project scripts, so this one is worth reading first. - Settlement: settle inactive threads without a PR lookup (pingdotgg#10103), skip disabled settlement lookups (pingdotgg#10424), settle threads with unanswered async questions (pingdotgg#10400). - Interrupted threads stay resumable after a restart (pingdotgg#10421). - Completed requests stay closed across clients (pingdotgg#10123). - Placeholder branches are followed after a checkout updates (pingdotgg#10441). - A thread's PR links without an open client (pingdotgg#10101), and checkpoints are captured before a PR status refresh (pingdotgg#10347). - Adapters declare their own context compaction (pingdotgg#10112). - Transcripts with oversized tool records import (pingdotgg#10430), and git status scans are skipped while the index is locked (pingdotgg#9845). - Usage limits pool per provider across accounts and environments (pingdotgg#10300). The client renders what `server.getUsageSummary` returns, so this shows something only if the Moatless payload carries per-account limits. Mobile, marketing, desktop, provider adapters and release tooling are not this fork's surface and are not classified. ## Also fixed here, and not upstream's doing - Three `browser-*` search items still routed to `/settings/integrations`, which the fork owns for its Moatless administration page. A non-administrator who searched for them was redirected away from the result. - `moatless/listSearch.ts` carried no fork-only declaration. - `pnpm fmt:check` failed on 294 files, 293 of them orval output. The generator now formats what it writes through an `afterAllFilesWrite` hook. - `@t3tools/moatless-api` exported `./generated`, a barrel that is never checked in. ## Verification `inventory-check.mjs` clean. `verify.mjs` green on seven checks: duplicate-adds, tripwires, resolution-check, unsupported-methods, `fmt:check` (3876 files), `lint` and `typecheck`. `test` is red on one package, and it is the machine. `@t3tools/desktop`'s `bundled libsecret helper` shells out to `pkg-config` for `libsecret-1`, which this sandbox does not have; it fails the same way when retried alone. Everything else passes: `apps/web` 369 files, `t3` 291, `@t3tools/mobile` 149, `t3code-relay` 27, `@t3tools/client-runtime` 71, plus the smaller packages. `spec:check` cannot run in a sandbox: it needs a sibling `moatless` checkout or a deployment URL and has neither. Written by Claude Opus 5 in Claude Code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- Moatless task: https://moatless.soaplabstest.com/tasks/8d348ecf-f9cb-4e65-b96b-6c1054a8ed33
Thread PR links depended on client-side logic. Automatic relinking required an open web chat, and web and mobile could show different associations.
The server now discovers and saves PR links for each thread's branch. All clients read those links. Manual links stay separate, and stale lookups cannot overwrite newer changes. Settlement checks for a newer open PR before acting on a merged link.
Automatic branch links require the updated server. The client fallback is removed.
Focused tests and affected package typechecks pass. Targeted lint reports warnings but no errors.
Created with GPT-6 Astra in Codex.
Note
Add server-side thread PR discovery and remove client-side VCS PR resolution
ThreadPullRequestReactorandthread.pull-request.synccommand, allowing PR links without an open client.linkedPullRequestorbranchPullRequestmetadata.048_ProjectionThreadBranchPullRequestaddsbranch_pull_request_jsontoprojection_threads; projection and contract schemas now supportbranchPullRequest.GitManager.branchPullRequestsupports an optionalrefreshflag and derives repository keys for GitHub, GitLab, Bitbucket, and Azure DevOps URLs.thread.pull-request.syncfails withOrchestrationCommandInvariantErrorif the thread is recreated after the command snapshot. Clients cannot open PRs when no server link exists.Macroscope summarized 6760605.