fix(codex): preserve qualified model ids in selection and generation

[maria-rcks]

qualified codex model ids were misclassified and auxiliary generation could dispatch an unqualified id. match known model families for defaults and classification while preserving live provider ids when dispatching.

verified with 37 focused tests, an 11-test manifest rerun, server typecheck, and scoped lint and formatting checks. fake-cli dispatch is covered; a native bedrock account was unavailable.

fixes #9659.

implemented with gpt-6-astra in codex.

---

Note

Medium Risk
Touches model default, legacy classification, and CLI dispatch paths for Codex; wrong family matching could mis-label models or pass the wrong --model, though behavior is covered by focused tests.

Overview
Adds codexModelFamily so Codex can compare model families (e.g. gpt-5.6-luna vs openai.gpt-5.6-luna) without rewriting the provider’s wire slugs.

Default and manifest behavior now family-match for Codex: preferred defaults, legacy/currentModels classification, and manifest chat defaults still flip flags on the live catalog slug (qualified when Bedrock returns it), not an unqualified manifest id.

Auxiliary codex exec text generation takes the instance snapshot’s models and resolves the user’s selection to an exact slug or a family match before passing --model, so commit/title/branch helpers don’t dispatch bare ids when only qualified models exist. CodexDriver wires text generation after the managed snapshot so that list is available.

Tests cover default ranking, manifest classification/defaults, and fake-CLI dispatch for both qualified and unqualified selections.

^{Reviewed by Cursor Bugbot for commit a798389. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix Codex model selection to preserve qualified live model IDs across manifest, provider, and text-generation layers

• Adds codexModelFamily helper in model.ts to strip provider qualification from Codex GPT slugs so qualified and unqualified IDs can be compared by shared family.
• isLegacyModel and applyManifestDefault in ModelManifest.ts now classify and resolve Codex defaults by family, moving the default flag to the qualified live slug while transferring aliases from any prior default.
• applyPreferredCodexDefaultModel in CodexProvider.ts matches preferred defaults by family instead of exact identifier, preserving the selected model's original wire slug.
• makeCodexTextGeneration in CodexTextGeneration.ts resolves the requested model by exact slug, then Codex family, then fallback, and passes the resolved qualified ID to the CLI.
• CodexDriver.ts defers text-generation factory construction until after the managed Codex snapshot exists, so the factory reads the instance's current model list.
• Behavioral Change: makeCodexTextGeneration and applyManifestDefault now dispatch or select a different model ID than the requested unqualified family name when a matching qualified live model exists; callers relying on the unqualified slug being passed through verbatim will see the qualified ID instead.

^{Macroscope summarized a798389.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR changes production Codex model selection by resolving qualified wire IDs and can change which model is marked and used as the default. The generation path also now derives its CLI model argument from the live provider snapshot, warranting human review.

^{You can add or adjust custom eligibility rules. Learn more.}