fix(mobile): harden native header toolbar items

[juliusmarminge]

The Expo 57 upgrade carried four correctness risks in our react-native-screens toolbar patch: placement ID collisions, invalid UIKit search-placement grouping, missing native search callbacks, and dropped mixed toolbar items. This follow-up addresses the findings from #8609.

The patch now gives right, center, and toolbar items distinct event namespaces; filters UIKit search-placement items to the toolbar in both JS and native code; wires text changes to either the native or fallback search field without accumulating duplicate actions; and removes only the custom Mail search item when building the ordinary navigation toolbar.

Review findings addressed:

• Placement ID collisions
• Invalid search placement outside the toolbar
• Missing native search text callback
• Dropped mixed toolbar items

Verification:

• vp run --filter @t3tools/mobile typecheck
• vp run lint:mobile
• vp i --frozen-lockfile
• vp exec expo install --check from apps/mobile
• Final T3CodeDev iOS Simulator build succeeded against the patched native source
• Fresh Metro bundle rendered the app on an iPad Pro 13-inch simulator

Generated with GPT-5.6-sol in T3 Code using the Codex harness.

---

Note

Medium Risk
Changes touch iOS navigation bar/toolbar native code and JS event routing; incorrect wiring could break header buttons or search UX, but scope is limited to the vendored screens patch.

Overview
Updates the react-native-screens@4.26.2 patch (and lockfile patch hash) to fix four header/toolbar regressions called out after the Expo 57 upgrade.

Event IDs: Center and toolbar bar items are now prepared with center and toolbar placements instead of reusing right, so buttonId / menuId values no longer collide across header regions.

Search placement: searchBarPlacement items are dropped in JS unless the placement is toolbar, and native barButtonItemsFromConfigs skips them when allowsSearchBarPlacement is false (header left/right/center); only the navigation toolbar path enables search placement.

Mail search toolbar: Search text changes are wired on a shared resolvedSearchTextField (native search bar or fallback field) with remove-then-add actions so edits do not stack duplicate handlers. Mixed headerToolbarItems lists keep non-mailSearchToolbar entries for the standard toolbar while the custom mail-search chrome still uses the dedicated config.

pnpm-lock.yaml reflects the new patch digest for react-native-screens and dependent resolution entries.

^{Reviewed by Cursor Bugbot for commit c410830. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Harden native header toolbar items in mobile

Updates the pnpm lockfile as part of hardening native header toolbar items on mobile. The lockfile change reflects dependency updates supporting the toolbar fix.

^{Macroscope summarized c410830.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c1590064-c9bf-4962-ae52-7f21fef5e250

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	+13 B (+0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+1 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	+12 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	11	11	0 (0.0%)	21	✅
Claude	Total thread wire	13.4 KiB	13.3 KiB	−16 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−6 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−10 B (−0.2%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	11	11	0 (0.0%)	21	✅

Baseline: 3e6ab36 · PR result: c410830 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

🟡 Medium patches/react-native-screens@4.26.2.patch:754

A prop refresh on a non-top vc replaces its toolbarItems and calls setToolbarHidden:, so a background screen can hide or show the toolbar belonging to the active pushed screen. reuseToolbarItems is deliberately false for non-top controllers, but the subsequent if still applies the update; restrict this block to vc being navctr.topViewController.

Suggested change

	+ if (!reuseToolbarItems) {
	if (!reuseToolbarItems && navctr.topViewController == vc) {

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @patches/react-native-screens@4.26.2.patch around line 754:

A prop refresh on a non-top `vc` replaces its `toolbarItems` and calls `setToolbarHidden:`, so a background screen can hide or show the toolbar belonging to the active pushed screen. `reuseToolbarItems` is deliberately false for non-top controllers, but the subsequent `if` still applies the update; restrict this block to `vc` being `navctr.topViewController`.

[macroscopeapp]

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a localized mobile hardening fix for existing iOS header-toolbar and search event handling, with the lockfile only pinning the updated dependency patch. An unresolved medium-severity finding still identifies a possible non-top-screen toolbar update affecting the active screen.

Not approved because:

• 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}