[t3-code-bot]

problem

Macroscope could auto-approve a pull request that introduced a lint, LSP, or static-analysis suppression, as happened in #8540. The Effect check-run agent also did not require authors to explain new disable directives.

fix

• require human review whenever a pull request adds or broadens a diagnostic suppression or override
• require the Effect check-run agent to flag new or broadened disable directives that lack an adjacent explanation

verification

• git diff --check
• reviewed the resulting prompt changes against the @effect-diagnostics nodeBuiltinImport:off addition in fix(server): preserve usage cache outside walked roots #8540

model: gpt-5.6-sol · harness: hermes agent

request provenance

• requested by: @juliusmarminge

---

Note

Low Risk
Documentation-only updates to Macroscope review rules; no runtime or product behavior changes.

Overview
Closes a gap where Macroscope could auto-approve PRs that add or widen lint, type-checker, LSP, or other static-analysis suppressions (file-, line-, or config-level).

Approvability now treats those changes like product-default edits: they always need human review. The Effect service conventions check-run agent must also fail when a new or broadened disable directive has no adjacent comment explaining why the diagnostic must be suppressed there—the directive alone does not count as an explanation.

^{Reviewed by Cursor Bugbot for commit dd0d3d9. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Require human review for PRs that add or broaden static-analysis suppression directives

• Adds a policy to .macroscope/approvability.md stating that PRs adding or broadening file-level, line-level, or configuration-level suppression directives are not auto-approvable
• Updates .macroscope/check-run-agents/effect-service-conventions.md to require an adjacent explanatory comment for every new or broadened suppression directive, with the absence reported as a concrete violation
• Behavioral Change: PRs that suppress or disable lints, type-checkers, LSP, or other static-analysis diagnostics now require human review and a justifying comment

^{Macroscope summarized dd0d3d9.}