fix(web): stop follow-ups from leaving giant blank space - #8068
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Note 🤖 GPT-5.6 Sol responding on behalf of Theo cursor review |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained vendor patch that fixes temporary web scroll padding cleanup in both module formats, with the lockfile only recording the new patch hash. Its runtime effect is limited to the affected out-of-bounds scroll adjustment path and does not introduce new APIs, workflows, or infrastructure changes. You can add or adjust custom eligibility rules. Learn more. |
## What's Changed * fix(server): bound OpenCode skill discovery output by @Lucenx9 in pingdotgg/t3code#7675 * fix(mobile): persist thread shelf collapse state by @PixPMusic in pingdotgg/t3code#5152 * fix(mobile): restore Android tablet thread controls, clean up header by @PixPMusic in pingdotgg/t3code#5385 * fix(mobile): land the first thread open above the composer on Android by @PollyGlot in pingdotgg/t3code#5585 * fix(server): check out submodules in a new worktree by @Brechard in pingdotgg/t3code#7674 * fix(server): preserve merged PR badges after branch deletion by @tris203 in pingdotgg/t3code#6216 * fix(server): return fresh live pull request reads by @Adamulek123 in pingdotgg/t3code#6472 * fix(web): compare client and server versions as semver, not strings by @spiky02plateau in pingdotgg/t3code#7579 * fix(web): stop follow-ups from leaving giant blank space by @t3dotgg in pingdotgg/t3code#8068 * fix(marketing): stop automatic Vercel deployments on pull requests by @t3dotgg in pingdotgg/t3code#8070 * chore: vouch repeat contributors by @t3dotgg in pingdotgg/t3code#8071 * fix(server): keep the authoritative subagent model when snapshots race task_started by @spiky02plateau in pingdotgg/t3code#7583 * fix(server): honor auto-accept edits for the OpenCode provider by @Rishet11 in pingdotgg/t3code#7100 * fix(server): run the CLI on Node versions without import.meta.main by @CDVolvik in pingdotgg/t3code#7141 * fix(server): recover from provider interrupt failures by @mrmg in pingdotgg/t3code#7412 * fix(server): recreate a thread's worktree before starting a turn by @mackinleysmith in pingdotgg/t3code#7839 * fix(server): thread delete no longer fails on already-removed worktrees by @t3dotgg in pingdotgg/t3code#8076 * fix(web): stop update notices showing through the composer by @t3dotgg in pingdotgg/t3code#8083 ## New Contributors * @spiky02plateau made their first contribution in pingdotgg/t3code#7579 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260824.1175...v0.0.34-nightly.20260824.1176 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260824.1176
Sending a follow-up could leave thousands of pixels of blank space below the thread. Chromium rounds temporary LegendList padding, so the cleanup compared different strings and never removed it.
Store the browser-normalized padding before the cleanup check in both LegendList web builds. The 3,233.83px reproduction now clears, and all 45 focused timeline tests pass.
Built by GPT-5.6 Sol with Codex.
Note
Medium Risk
Touches virtualized list scroll padding and end-anchor sizing via a vendor patch, so leftover space or jumpiness is possible if cleanup still mismatches.
Overview
Fixes a web thread bug where sending a follow-up could leave thousands of pixels of blank space below the list.
Chromium rounds LegendList’s temporary end padding, so cleanup compared a different string and never removed it. The patch now stores the browser-normalized padding after applying it (
react.js/react.mjsScrollAdjust).Also caps anchored end space while tail sizes are still unknown and applies shrinks even before the space is “ready,” so leftover blank height does not stick around.
Reviewed by Cursor Bugbot for commit 5393885. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix blank space in follow-ups by patching
ScrollAdjustin@legendapp/listScrollAdjustin @legendapp__list@3.3.5.patch sotemporaryPaddingRef.currentis set after thecontentNode.style[axis.paddingEndProp]mutation and reads the actual applied value from that style property.temporaryPaddingRef.current.valuenow reflectscontentNode.style[axis.paddingEndProp]rather than the pre-mutation localtemporaryPaddingEnd; any code relying on the old timing or value source may see different padding references.Macroscope summarized 5393885.