Skip to content

feat(web): add pull request list filters - #8809

Merged
maria-rcks merged 27 commits into
pingdotgg:mainfrom
maria-rcks:t3code/improve-pull-request-filters
Sep 1, 2026
Merged

maria-rcks merged 27 commits into
pingdotgg:mainfrom
maria-rcks:t3code/improve-pull-request-filters

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Aug 30, 2026 •

Copy link
Copy Markdown
Collaborator

pull request lists now show summary-style colored labels and per-row additions/deletions, with author and label filters. the author picker stays capped at ten contributors and ranks them by merges in the loaded results. sorting is a separate icon + Sort control; creation-time and change-size choices explicitly apply to the rows shown.

selected labels remain visible and removable when the current state has no matching rows. url labels dedupe case-insensitively.

verified against real pingdotgg/t3code data earlier in this pr: author search narrowed the list to matching rows and loaded change totals sorted strictly by size. the final follow-up passed 101 focused tests and web typecheck.

before feature layout
before feature layout

this capture predates the final narrower icon + Sort trigger, but reflects the shipped row-label and filter-menu treatment.

generated with gpt-5.6-sol in the codex harness.


Note

Low Risk
Mostly UI and client-side ordering; author/label filters extend existing listing filter plumbing and URL/cache keys, so expect harmless refetches after deploy rather than security or data risks.

Overview
The Pull requests page gains author and labels narrowings (URL-backed with the rest of the menu filters), a separate Sort control, and richer list rows.

The Filters menu is reorganized into compact submenus that show the current choice; the trigger shows a count of active narrowings instead of a dot. New Author (searchable radio list, capped at ten, ordered by merges in loaded results) and Labels (multi-select, up to ten) submenus are fed by collectPullRequestListFacets, with an extra list fetch only while the menu is open. Sort options (recently updated, newest/oldest shown, largest/smallest by diff size) reorder client-side over the rows currently displayed and collapse involvement grouping when not on the default.

Rows show the first label with a colored dot and a +N suffix. Label hex colors go through shared pullRequestLabelColor (also used in the detail summary). Project options can show favicons via PullRequestFilterOptionIcon. Tests adjust findLabeledGroup for nested submenu radio groups.

Reviewed by Cursor Bugbot for commit 275bd19. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add author, label, and sort filters to pull request list

  • Adds author and label filter submenus to PullRequestFiltersMenu, with searchable author list ranked by merged count and multi-select label checkboxes
  • Adds sort options (updated, newest, oldest, largest, smallest) to URL search state and a sort control in the list header
  • Introduces collectPullRequestListFacets in pullRequestList.logic.ts to compute author and label facet lists on demand when the filters menu opens
  • Extracts pullRequestLabelColor as a shared color validator and adds PullRequestRowLabels to show the first label with a colored dot and +N indicator on each row
  • Converts existing filter groups (State, Involvement, Draft, Review, Checks, Host, Server, Project) into submenu entries with a numeric active-filter count badge on the trigger
  • Behavioral Change: typed query qualifiers now override menu filter state for author and labels; scopeKey extended to include author and labels for cache separation

Macroscope summarized 275bd19.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant