Skip to content

fix(client-runtime): refresh edited pull request comments - #8094

Open
Bil0000 wants to merge 1 commit into
pingdotgg:mainfrom
Bil0000:t3code/fix-comment-update-stale-text
Open

fix(client-runtime): refresh edited pull request comments#8094
Bil0000 wants to merge 1 commit into
pingdotgg:mainfrom
Bil0000:t3code/fix-comment-update-stale-text

Conversation

@Bil0000

@Bil0000 Bil0000 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Updated pull request comments stayed stale because the successful update command did not refresh the shared activity query. Each PR surface could finish the edit while still rendering the old cached activity.

This change refreshes the exact pull request activity atom after a comment update succeeds. Summary, Timeline, and Code views now receive the updated comment text without a page reload. A client-runtime regression test covers the full command-to-query flow.

Verified with:

  • pnpm exec vp test run packages/client-runtime/src/state/pullRequests.test.ts
  • pnpm exec vp fmt --check packages/client-runtime/src/state/pullRequests.ts packages/client-runtime/src/state/pullRequests.test.ts
  • pnpm exec vp lint --report-unused-disable-directives packages/client-runtime/src/state/pullRequests.ts packages/client-runtime/src/state/pullRequests.test.ts
  • pnpm --filter @t3tools/client-runtime typecheck

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 24bcc514-576a-42ca-a901-7fe91792da6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 24, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at a3cd551

Macroscope's review found this PR approvable — The PR adds a narrowly scoped refresh of the existing pull-request activity query after comment edits, backed by an end-to-end client-runtime regression test. It introduces no schema, security, infrastructure, or broader workflow changes.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant