perf(desktop): cut macOS signing calls by 81% - #8093
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR changes macOS production packaging by removing platform-specific files, changing staged runtime dependencies, and routing signed builds through a custom batched signing hook. Because it affects signed artifact contents and release signing/notarization behavior rather than only build-time performance, the changes warrant human review. You can add or adjust custom eligibility rules. Learn more. |
## What's Changed * feat(web): settle and restore threads with a keyboard shortcut by @t3dotgg in pingdotgg/t3code#8089 * perf(desktop): cut macOS signing calls by 81% by @t3dotgg in pingdotgg/t3code#8093 * feat: link pull requests to threads by @t3dotgg in pingdotgg/t3code#8160 * feat(web): safely attach HEIC photos as JPEG images by @t3dotgg in pingdotgg/t3code#8161 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260825.1181...v0.0.34-nightly.20260825.1182 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260825.1182
Recent macOS releases spend 87 to 97 seconds on signing and notarization. Electron Builder signs files one at a time and packages dependencies that the Mac does not need.
Use batched macOS code signing, keep only server dependencies that remain outside the bundle, and remove Windows terminal binaries. Add detailed signing and notarization logs so the next signed release shows where Apple processing time goes.
Measured in a real unsigned macOS CI build with ad-hoc signatures:
The non-publishing macOS validation run completed in 2 minutes 7 seconds without Apple credentials.
Linux and Windows packaging do not change.
Built with GPT-5.6 Sol in the Codex harness.