test: remove low-signal test files - #8397
Conversation
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The PR removes eight test-only files containing 14 low-signal assertions across mobile, server, web, and shared code, while leaving production sources and runtime entry points unchanged. Its only material effect is reduced regression coverage and test-maintenance surface. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
## What's Changed * fix(grok): improve skills, plans, usage, and turn reliability by @t3dotgg in pingdotgg/t3code#8358 * fix(server): recover stale Codex approval callbacks by @luckyPipewrench in pingdotgg/t3code#5195 * test(server): remove duplicate missing worktree test by @t3-code[bot] in pingdotgg/t3code#8252 * fix(server): replay all un-applied events during projection bootstrap by @krutftw in pingdotgg/t3code#7538 * test: remove low-signal test files by @t3-code[bot] in pingdotgg/t3code#8397 * test: prune trivial error and layout tests by @t3-code[bot] in pingdotgg/t3code#8400 * Fix Android adaptive launcher icon by @colonelpanic8 in pingdotgg/t3code#4332 * feat(web): split provider settings into list and editor by @t3dotgg in pingdotgg/t3code#8380 * fix(codex): accept Codex 0.150 account plans by @gsimone in pingdotgg/t3code#8447 * fix(tooling): allow ignored-only staged changes by @juliusmarminge in pingdotgg/t3code#8468 * fix(mobile): keep iOS home header stable by @juliusmarminge in pingdotgg/t3code#8467 * fix(web): stop showing red x summaries for ordinary tool failures by @t3dotgg in pingdotgg/t3code#8395 * fix(mobile): refine Git action toast glass styling by @juliusmarminge in pingdotgg/t3code#8399 * fix(desktop): allow preview automation in agent-created threads by @t3dotgg in pingdotgg/t3code#8483 * test(web): remove redundant cache key test by @t3-code[bot] in pingdotgg/t3code#8484 * fix(release): move nightly schedule to minute 38 by @t3dotgg in pingdotgg/t3code#8509 * fix(web): stabilize the provider settings editor by @t3dotgg in pingdotgg/t3code#8472 * fix(web): open GitHub pull requests in browser when loading fails by @t3dotgg in pingdotgg/t3code#8507 * fix(codex): show sub-agent models by @t3dotgg in pingdotgg/t3code#8502 * feat(analytics): report connected client platforms by @t3dotgg in pingdotgg/t3code#8481 * feat(server): accept PDF, ZIP, and other file uploads up to 50MB by @t3dotgg in pingdotgg/t3code#8235 * feat(web): toggle a thread's pin from the keyboard by @ipanasenko in pingdotgg/t3code#8440 * fix(web): add back button to project settings by @StiensWout in pingdotgg/t3code#8168 * refactor(mobile): compile semantic themes for Uniwind by @juliusmarminge in pingdotgg/t3code#7327 * fix(desktop): Cache Runtime locally on WSL Filesystem, dramatically improving launch times by @ikifar2012 in pingdotgg/t3code#5769 * fix(mobile): show OpenCode model sources in picker by @juliusmarminge in pingdotgg/t3code#8573 * fix(clients): honor project default models in new threads by @anirudhsama in pingdotgg/t3code#6011 * fix(mobile): show file actions on Android by @none23 in pingdotgg/t3code#8215 * fix(connect): explain DPoP connection failures by @extoci in pingdotgg/t3code#8351 * feat(web): make the sidebar project filter a searchable combobox by @SunkenInTime in pingdotgg/t3code#5931 * fix(server): a draft can retry its first send after a failed bootstrap by @shivamhwp in pingdotgg/t3code#8226 * fix(desktop): stop hidden previews draining battery by @Bil0000 in pingdotgg/t3code#8567 * fix(desktop): oauth popups open from the browser preview by @walid-baharwal in pingdotgg/t3code#8435 * fix(web): keep long task drawers usable on small screens by @shivamhwp in pingdotgg/t3code#8313 * fix(opencode): handle child approvals, stops, and model catalogs by @t3dotgg in pingdotgg/t3code#8480 * fix: make thread auto-settling opt-in by @shivamhwp in pingdotgg/t3code#8321 * fix(web): stop session activity timing test from blocking releases by @t3dotgg in pingdotgg/t3code#8585 * fix(mobile): show composer menus when starting a task by @juliusmarminge in pingdotgg/t3code#8587 * fix(web): show the configured stash shortcut by @UtkarshUsername in pingdotgg/t3code#8437 * feat(web): add toggleable confirmation before unpinning a thread by @UtkarshUsername in pingdotgg/t3code#7313 * fix: restore automatic thread settling defaults by @t3dotgg in pingdotgg/t3code#8596 * fix(mobile): restore composer glass and rounded shadows by @juliusmarminge in pingdotgg/t3code#8597 ## New Contributors * @luckyPipewrench made their first contribution in pingdotgg/t3code#5195 * @krutftw made their first contribution in pingdotgg/t3code#7538 * @colonelpanic8 made their first contribution in pingdotgg/t3code#4332 * @ikifar2012 made their first contribution in pingdotgg/t3code#5769 * @walid-baharwal made their first contribution in pingdotgg/t3code#8435 **Full Changelog**: pingdotgg/t3code@v0.0.35...v0.0.36 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.36
* fix(grok): improve skills, plans, usage, and turn reliability (pingdotgg#8358) Co-authored-by: Dara Adedeji <daraadedeji07@gmail.com> Co-authored-by: Ahmed Besic <ahmed-besic@users.noreply.github.com> Co-authored-by: Michael Brown <michaeltbrown.mtb@gmail.com> Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com> Co-authored-by: Guilherme Barros <gbarros1095@gmail.com> Co-authored-by: PC <pc@localhost> Co-authored-by: 1xpixi <157762409+1xpixi@users.noreply.github.com> * fix(server): recover stale Codex approval callbacks (pingdotgg#5195) * test(server): remove duplicate missing worktree test (pingdotgg#8252) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> * fix(server): replay all un-applied events during projection bootstrap (pingdotgg#7538) Co-authored-by: Theo Browne <me@t3.gg> * test: remove low-signal test files (pingdotgg#8397) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> * test: prune trivial error and layout tests (pingdotgg#8400) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> * Fix Android adaptive launcher icon (pingdotgg#4332) Co-authored-by: Yash Singh <saiansh2525@gmail.com> * feat(web): split provider settings into list and editor (pingdotgg#8380) * fix(codex): accept Codex 0.150 account plans (pingdotgg#8447) * fix(tooling): allow ignored-only staged changes (pingdotgg#8468) * fix(mobile): keep iOS home header stable (pingdotgg#8467) Co-authored-by: Julius Marminge <julius@mac.lan> * fix(web): stop showing red x summaries for ordinary tool failures (pingdotgg#8395) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(mobile): refine Git action toast glass styling (pingdotgg#8399) * fix(desktop): allow preview automation in agent-created threads (pingdotgg#8483) * test(web): remove redundant cache key test (pingdotgg#8484) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> * fix(release): move nightly schedule to minute 38 Recent scheduled nightlies have been delayed or skipped. Move the nightly cron from minute 7 to minute 38. Keep the existing three-hour interval. This tests a different point in each three-hour window without claiming it will fix GitHub schedule delivery. Authored by GPT-5.6 Sol with the Codex harness. * fix(web): stabilize the provider settings editor (pingdotgg#8472) * fix(web): open GitHub pull requests in browser when loading fails (pingdotgg#8507) * fix(codex): show sub-agent models (pingdotgg#8502) * feat(analytics): report connected client platforms (pingdotgg#8481) * feat(server): accept PDF, ZIP, and other file uploads up to 50MB (pingdotgg#8235) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(web): toggle thread pin from the keyboard Add a mod+shift+p shortcut that pins or unpins the active thread. Ignore the shortcut during terminal focus and when the server does not support thread pinning. * fix(web): add back button to project settings (pingdotgg#8168) * refactor(mobile): compile semantic themes for Uniwind (pingdotgg#7327) Co-authored-by: codex <codex@users.noreply.github.com> * fix(desktop): Cache Runtime locally on WSL Filesystem, dramatically improving launch times (pingdotgg#5769) Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> * fix(mobile): show OpenCode model sources in picker (pingdotgg#8573) Co-authored-by: Julius Marminge <julius@mac.lan> * fix(clients): honor project default models in new threads (pingdotgg#6011) Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com> * fix(mobile): show file actions on Android (pingdotgg#8215) Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com> * fix(connect): explain DPoP connection failures (pingdotgg#8351) Co-authored-by: Julius Marminge <julius0216@outlook.com> * feat(web): make the sidebar project filter a searchable combobox (pingdotgg#5931) * fix(server): a draft can retry its first send after a failed bootstrap (pingdotgg#8226) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(desktop): stop hidden previews draining battery (pingdotgg#8567) * fix(desktop): oauth popups open from the browser preview (pingdotgg#8435) Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix(web): keep long task drawers usable on small screens (pingdotgg#8313) * fix(opencode): handle child approvals, stops, and model catalogs (pingdotgg#8480) * fix: make thread auto-settling opt-in (pingdotgg#8321) * fix(web): stop session activity timing test from blocking releases (pingdotgg#8585) * fix(mobile): show composer menus when starting a task (pingdotgg#8587) Co-authored-by: Julius Marminge <julius@mac.lan> * fix(web): show the configured stash shortcut (pingdotgg#8437) Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com> * feat(web): add toggleable confirmation before unpinning a thread (pingdotgg#7313) Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com> * fix: restore automatic thread settling defaults (pingdotgg#8596) * fix(mobile): restore composer glass and rounded shadows (pingdotgg#8597) Co-authored-by: Julius Marminge <julius@mac.lan> * Remove Messages Glass Lab experiment (pingdotgg#8599) * chore(release): prepare v0.0.36 --------- Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Dara Adedeji <daraadedeji07@gmail.com> Co-authored-by: Ahmed Besic <ahmed-besic@users.noreply.github.com> Co-authored-by: Michael Brown <michaeltbrown.mtb@gmail.com> Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com> Co-authored-by: Guilherme Barros <gbarros1095@gmail.com> Co-authored-by: PC <pc@localhost> Co-authored-by: 1xpixi <157762409+1xpixi@users.noreply.github.com> Co-authored-by: Josh <gitlucky@pipelab.org> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Tradi3 <56069280+krutftw@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Ivan Malison <IvanMalison@gmail.com> Co-authored-by: Yash Singh <saiansh2525@gmail.com> Co-authored-by: Gianmarco <gianmarcosimone89@gmail.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Julius Marminge <julius@mac.lan> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Illia Panasenko <hello@ipanasenko.me> Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Co-authored-by: codex <codex@users.noreply.github.com> Co-authored-by: Matheson Steplock <ikifar2012@users.noreply.github.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> Co-authored-by: Anirudh Coontoor <anirudh@gosupernova.live> Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com> Co-authored-by: Nick Anisimov <n.anisimov.23@gmail.com> Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com> Co-authored-by: Dara Adedeji <76637177+SunkenInTime@users.noreply.github.com> Co-authored-by: Bilal Bakr <62337003+Bil0000@users.noreply.github.com> Co-authored-by: Muhammad Waleed <114993336+walid-baharwal@users.noreply.github.com>
Range: a3a8cbd..f6f2be3, 9 commits, 64 files, +4793/-625. Shape: mostly one-sided. 13 files touched by both sides, 2 conflicts, both in the same subsystem (ProviderCommandReactor). Upstream's bulk is the Grok ACP work (pingdotgg#8358, ~1,700 lines across GrokAdapter/GrokProvider/GrokSkills/ AcpRuntimeModel/XAiAcpExtension), a usage contract widening for Grok (v4 -> v5), and 15 deleted low-signal test files (pingdotgg#8397, pingdotgg#8400, pingdotgg#8252). CONFLICTS AND RESOLUTIONS 1. apps/server/src/orchestration/Layers/ProviderCommandReactor.ts Upstream pingdotgg#5195 and the fork made the SAME fix independently, byte-identical: `detail.includes("unknown pending codex approval request")` plus lowercasing `Cause.pretty`. Only the fork's explanatory comment conflicted. Resolved to HEAD (comment kept); the shared code merged either way. 2. apps/server/src/orchestration/Layers/ProviderCommandReactor.test.ts A SPLICE, not a choice. Git paired upstream's retargeted test header with the fork's unrelated "continues as a new turn ... (user-input)" test header, over a shared `const harness = await createHarness(); const now = ...` preamble; the body below the markers is the fork's. Head and tail describe different subjects — the documented tell. Resolved to HEAD. Upstream did not add a test here: it RETARGETED its single "surfaces stale provider approval request failures" case from the permission phrasing to the Codex one. The fork had already turned that same test into an `it.each` over all three phrasings, INCLUDING upstream's exact new detail string. The fork's version is a strict superset, so nothing is owed. INVARIANTS (docs/fork/README.md) — all 12 re-probed against the merged tree 1 migrations 49 entries, ids unique + monotonic, max 50, 34 still burned 2 fork patch @effect/platform-node@4.0.0-beta.103 still pinned, 16 patches 3 sidebar Sidebar.tsx default, LegacySidebar behind useLegacySidebarEnabled 4 deletions ContextWindowMeter{.tsx,.test.tsx} absent; MessagesTimeline's three dropped helpers absent (3 hits are the FORK comments); ComposerPendingUserInputPanel has 0 Collapsible 4b send state 4 `isSendBlocked=` in ChatComposer.tsx 5 steer test absent (the single grep hit is the FORK comment marking it) 5b footer SidebarLocalModels + SidebarResourceQueue inside SidebarUtilityMenu 5c boot BootTurnReconciler.ts present; reconcileProviderSessions absent (FORK note at serverRuntimeStartup.ts:305) 6 projects 4 `/projects/$projectKey` call sites, dialog intact 7 stop ladder STOP_INTERRUPT_GRACE + INTERRUPT_REQUEST_GRACE both live, interruptTurn and stopSessionInternal still separate rungs 8 interrupt 4 `hasLiveSessionForThread` in ProviderCommandReactor.ts 9 entrypoint test still realpaths the temp root 10 meter logic ContextWindowMeter.logic.ts present; both rejected exports absent 11 markdown ChatMarkdown.tsx carries both environmentId and fileEnvironmentId Also verified by hand, since a clean automerge cannot: the fork's four edits to GrokAdapter.ts survived upstream's 597-line rewrite intact — the identity-guarded `sessions.delete`, the `!stopped` filter in `listSessions`, `refreshAccountUsage` and `withdrawQueuedTurn`. SWEEPS (union of both sides, 671 files, 13 two-sided) resurrected 0 fork-loss 0 both-kept 0 dropped 3 The 3 dropped are the deliberate rejection above: upstream's renamed `it(...)` header, its `detail:` line (the fork carries the same string as an `it.each` table row, so the text differs) and its `method: "item/requestApproval/decision"` fixture field, which nothing in the matcher reads. 18 files reported ABSENT from the result: 15 are upstream's own test deletions, 3 are the fork's deliberate ones (ContextWindowMeter.tsx, its test, and serverRuntimeStartup.reconcile.test.ts under invariant 5c). `--upstream-deleted` run as well: 364 lines / 52 files, every one upstream rewording or replacing its own text (0.0.34 -> 0.0.35 version bumps, usage v4 -> v5, the Grok expansions, doc rewrites). No fork reference to a removed thing. GATE pnpm install: lockfile unchanged by the merge. pnpm run verify (fmt:check -> typecheck -> lint -> test): EXIT=0 (read from the log, not the task notification). 14 test blocks, 10,201 passed, 10 skipped, 0 failed. Baseline at 5d4cd0b was 10,170, so +31. Arithmetic checked per file rather than by netting totals, because a netted total is exactly what hid four destroyed tests in a previous session. Test DECLARATIONS across all 2,526 fork test files: 18,268 -> 18,297 (+29), and every file that lost any is accounted for — upstream's 15 deletions plus GitVcsDriverCore.test.ts 76 -> 75, which is pingdotgg#8252 removing one duplicate. NO fork test file lost a declaration. The residual +2 between declarations and executed tests is `.each` expansion the declaration regex cannot see.
this removes eight complete test files that added maintenance cost without protecting a useful regression boundary.
removals
URLconstructor through a direct re-exportno production code changed. this removes 14 tests and 135 lines across eight files.
verification
before deletion:
vp test run <eight removed files>passed, 8 files and 14 testsafter deletion:
vp test run packages/client-runtime/src/state/assets.test.ts apps/web/src/components/ui/button.test.tsxpassed, 2 files and 7 testsgit diff --cached --checkpassedgenerated by gpt-5.6-sol with hermes agent.
request provenance
Note
Low Risk
Test-only deletions with no runtime behavior changes; regression coverage drops only for previously low-signal assertions.
Overview
Removes eight entire test files (~135 lines, 14 tests) across
mobile,server,web, andsharedwith no production code changes.The deleted suites were mostly brittle or low-value: static React markup assertions on Tailwind/class names (
StartTruncatedPath, toggle-group), trivial constant/mapping checks (mobileBranding,Attributes,themePreview), a thinURLwrapper test (assetUrls), random ID format checks (previewAutomationClientId), and a string-matching guard onmain.tsx/package.jsonforreact-grabimports.Production helpers and components are unchanged; only test maintenance surface is reduced.
Reviewed by Cursor Bugbot for commit cdaa8fc. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Remove low-signal test files across mobile, server, web, and shared packages
Deletes 8 test files that covered pure mapping functions, simple ID generation, and structural assertions with limited regression value. Affected files span
mobileBranding,Attributesnormalization,assetUrls,StartTruncatedPath,previewAutomationClientId,toggle-group,reactGrabBoundary, andthemePreview.Macroscope summarized cdaa8fc.