[Yash-Singh1]

The V1 cutover integration test imports the removed effect/Crypto module, breaking server test collection and CI on main.

Use effect/crypto/Digest, Digest.sha256, and NodeCrypto.layerDigest to compute the same SHA-256 file checksum with the pinned Effect API.

Validation: reproduced the missing-module failure before the fix; the cutover integration test and vp run check:changed pass after the fix, including affected typechecks and adjacent tests.

Model: gpt-6.1-sol. Harness: Codex in T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 9cb90ed

Macroscope's review found this PR approvable — This repair is confined to an ignored integration-test path and updates its checksum API usage. No material production behavior or product-default change is indicated.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The legacy cutover integration test now computes file SHA-256 values with the Digest service and NodeCrypto.layerDigest.

Changes: Legacy cutover test

Layer / File(s)	Summary
Update file hashing in test apps/server/src/orchestration-v2/legacy/LegacyV1Cutover.integration.test.ts	sha256File now uses Digest.sha256 and digestHex with NodeCrypto.layerDigest, replacing the Crypto digest call, hex encoder, and Effect.orDie wrapper.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

• pingdotgg/t3code#30501: Moves server crypto call sites to Effect crypto services, including Digest and updated NodeCrypto layers.

Suggested labels: size:XS

Suggested reviewers: saphid, macroscopeapp

Merge Risk: Minimal · up to 9cb90

The cutover test uses the current digest API. No merge-blocking risk is identified.

Pre-merge checks: 3 · 1

Failed checks: 1 inconclusive

Check name	Status	Explanation	Resolution
Description check		The description covers the problem (the removed effect/Crypto import breaking server test collection and CI on main), the change (switch to effect/crypto/Digest, Digest.sha256, and NodeCrypto.layerDig…	Add a Scope and approval section. Either link the triaged issue or the maintainer-approved discussion, or explain why this small, focused fix of an obvious CI-breaking bug qualifies without a prior issue. Consider restructuring the descript…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title names the actual change: the cutover test's import of the removed effect/Crypto module is repaired to unblock main CI. It is specific, follows conventional commit form, and matches the raw s…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the actual change: the cutover test's import of the removed effect/Crypto module is repaired to unblock main CI. It is specific, follows conventional commit form, and matches the raw summary and the PR objectives.

Full details: Description check

Explanation

The description covers the problem (the removed effect/Crypto import breaking server test collection and CI on main), the change (switch to effect/crypto/Digest, Digest.sha256, and NodeCrypto.layerDigest), and verification (the failure was reproduced before the fix, and the cutover test and vp run check:changed pass after it). It also lists the model and harness, as the template asks. The Scope and approval section is missing. The template asks for a linked triaged issue or maintainer approval, or an explanation of why a very small, focused fix of an obvious bug qualifies without one. The author should add that explanation or a link. The description also does not follow the template's section headings (Problem, Change, Scope and approval, Verification).

Resolution

Add a Scope and approval section. Either link the triaged issue or the maintainer-approved discussion, or explain why this small, focused fix of an obvious CI-breaking bug qualifies without a prior issue. Consider restructuring the description under the template's headings: Problem, Change, Scope and approval, and Verification. The Verification section should state the specific test results and anything that was not checked.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: t3/fix-main-ci-failures
• File: .coderabbit.config.ts
• Commit: 9cb90ed
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 68e41254-d4bc-4bd9-b39a-bbd4234ecd26

Commits

Reviewing files that changed from the base of the PR and between e66c316 and 9cb90ed.

Files selected for processing: 1

• apps/server/src/orchestration-v2/legacy/LegacyV1Cutover.integration.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	21.5 KiB	21.5 KiB	0 B (0.0%)	24.4 KiB	✅
Codex	Live turn messages	1	1	0 (0.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.9 KiB	21.9 KiB	0 B (0.0%)	24.4 KiB	✅
Claude	Live turn messages	1	1	0 (0.0%)	8	✅

Baseline: 09eb653 · PR result: 9cb90ed · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.