[TonybynMp4]

Problem

GitLab author names in the merge request header and on comments were plain text, because the GitLab definition's authorProfileUrl returned null. GitHub names have linked to profiles since #9627. Closes #30417.

Change

authorProfileUrl now returns <origin>/<username>, resolved against the repository or merge request URL the web client already passes, so self-managed instances and ports work.

Bots link too. GitHub returns null for [bot] logins because those profiles 404. GitLab bot users, such as project access token bots, have real profile pages, so there's nothing to skip.

Scope and approval

One line in the GitLab definition plus a test. The web header and comment author labels already render the link and the "Open profile" tooltip from this function. Mobile doesn't link authors today. Tracked in #30417.

Verification

• New test fails on main and passes here: a user and a project bot both link to their profile, on gitlab.com and on a self-managed host with a port.
• vp run check:changed passes: format, lint, knip, typecheck (11 packages), tests.
• Manual, web dev build against TonybynMp4/git-ansible!5. All 8 author labels link to gitlab.com/TonybynMp4. The display name in the tooltip is blurred in the captures.

Before	After
plain name, tooltip without "Open profile"	underlined link, tooltip with "Open profile"

Fixed by Claude Opus 5.5 in Claude Code, running inside T3 Code.

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

GitLab author names can link to profile URLs. The URL is built from the repository URL and URL-encoded login. Tests cover regular and bot accounts.

Changes: GitLab author profile links

Layer / File(s)	Summary
Generate and test profile URLs packages/source-control-gitlab/src/shared/definition.ts, packages/source-control-gitlab/src/shared/definition.test.ts	authorProfileUrl builds a profile URL from the repository URL and URL-encoded login. Tests check a regular author and a bot account, including the scheme and port for an internal repository URL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge, macroscopeapp

Merge Risk: Minimal · up to 1caa3

The change provides GitLab profile links for regular and bot authors without an established merge-blocking risk.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "fix(gitlab): author names link to GitLab profiles" names the main change. The changeset makes GitLab's authorProfileUrl return a profile URL built from the origin and username, so author na…
Description check		The description follows the repository template. It has Problem, Change, Scope and approval, and Verification sections, and each section has specific content. The Problem section explains the cause (a…
Linked Issues check		Issue #30417 requires that GitLab author names link to the author's profile, that the tooltip ends with "Open profile", and that bot users link too. At head 1caa37a, `packages/source-control-gitlab/…
Out of Scope Changes check		The whole-PR diff against merge base b183048 changes only two files: packages/source-control-gitlab/src/shared/definition.ts (the authorProfileUrl implementation with a comment) and `packages/so…

Full details: Title check

Explanation

The title "fix(gitlab): author names link to GitLab profiles" names the main change. The changeset makes GitLab's authorProfileUrl return a profile URL built from the origin and username, so author names link to profiles. It is a conventional commit title in plain language, with no file lists, emojis, or vague terms.

Full details: Description check

Explanation

The description follows the repository template. It has Problem, Change, Scope and approval, and Verification sections, and each section has specific content. The Problem section explains the cause (authorProfileUrl returned null) and links the tracking issue #30417. The Change section explains the new URL behavior and why bot links are included. The Scope section describes the one-line change plus test and cites the issue. The Verification section lists the new test, the check:changed run, and a manual check with before and after images. The Scope section cites a triaged issue (#30417) but does not include an explicit maintainer approval comment, which the template asks for. The template also asks the author to end with the model and harness used. The description states that Claude Opus 5.5 in Claude Code, running inside T3 Code, did the work. Those points are minor gaps, so the check passes.

Full details: Linked Issues check

Explanation

Issue #30417 requires that GitLab author names link to the author's profile, that the tooltip ends with "Open profile", and that bot users link too. At head 1caa37a, packages/source-control-gitlab/src/shared/definition.ts replaces authorProfileUrl: () => null with (login, repositoryUrl) => new URL(/${encodeURIComponent(login)}, repositoryUrl).toString(). This yields <origin>/<username> on the repository host and port. The code does not skip bot logins, which matches the issue, since GitLab bot profiles return 200. The same GitHub pattern already supplies the link and tooltip, so the existing web consumers should render them for GitLab. The new test in definition.test.ts asserts a regular user URL on gitlab.com and a bot URL on http://gitlab.internal:8080. Mobile behavior is not in the issue scope. The web rendering and tooltip were not re-read in this review. That part rests on the shared consumer and the author's manual check, which is reported in the PR description but was not independently verified here.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff against merge base b183048 changes only two files: packages/source-control-gitlab/src/shared/definition.ts (the authorProfileUrl implementation with a comment) and packages/source-control-gitlab/src/shared/definition.test.ts (one new test case). Both directly implement or verify the linked issue #30417. No mobile, web, or unrelated provider code is changed. The GitLab change mirrors the existing GitHub definition's authorProfileUrl pattern.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: b183048
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 131cc3cc-da0b-439f-b3f5-5952c24f9843

Commits

Reviewing files that changed from the base of the PR and between b183048 and 1caa37a.

Files selected for processing: 2

• packages/source-control-gitlab/src/shared/definition.test.ts
• packages/source-control-gitlab/src/shared/definition.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

[macroscopeapp]

Approvability

Verdict: Approved at 1caa37a

Macroscope's review found this PR approvable — GitLab author names, including bots, now link to profiles on the repository’s host. The change is limited to user-initiated navigation and does not affect stored data or access permissions.

^{You can add or adjust custom eligibility rules. Learn more.}

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified head 1caa37adeab41ba0242429725671609d0add6c9f against github/main at b113eb0209, using separate checkouts and one dev server at a time on linux. playwright drove /usr/bin/google-chrome. projects and real codex gpt-6.1-sol turns were created through the web app against a clone of gitlab-org/cli; no mocked responses or seeded data.

• main: the human author on gitlab-org/cli!2681 and dependency bot on !4312 rendered as plain text, with no profile links.
• pr: both headers render links to the correct gitlab profiles and show "Open profile" in their tooltips. clicking each opens its real profile page. links use a new tab and noopener noreferrer.
• nearby behavior: merge request descriptions, checks and code file lists still load. the github author links on this pr still resolve to https://github.com/TonybynMp4.
• blacksmith: all eight gitlab definition tests passed. vp run check:changed b183048a823815175fd6991691f2acec456ea176 passed format, lint, knip, affected typechecks and tests after fetching the pr's base history. no code changes were needed.

human author before:

human author after:

dependency bot before:

dependency bot after:

Not verified

gitlab comment author links and authenticated lists: this vm has no gitlab login. public merge request details are readable through the real glab adapter, but comment requests return 401 and lists cannot resolve a viewer. that existing limitation is visible in both captures. self-managed gitlab with ports is covered by the existing focused test, not a live instance. native desktop, ios and android were not exercised on this linux web pass.