[saphid]

Problem

Find in thread (Cmd+F, or the thread title menu on phones) treats a straight apostrophe ' and a curly one ‘ ’ as different characters. If you type don't on a desktop keyboard, it misses don’t in a message. If you type don’t on an iPhone or iPad, where smart punctuation inserts ’, it misses don't. Either way you see "no results" for text that is plainly on screen.

The command palette and message search already treat the two as equal (foldCharacter in paletteSearch.ts: "A typed straight apostrophe finds a curly one: iOS keyboards type ’"), and the server message index stores apostrophes straight. Find in thread does not.

Change

foldThreadSearchCase in packages/shared/src/threadSearch.ts already folds Greek final sigma. It now also folds ‘ and ’ to ' in the same place. Each replacement swaps one UTF-16 unit for one unit, so match offsets and highlight ranges stay valid. The server match count (ThreadFind.ts) and the web highlights (threadFindHighlights.ts) both use this function, so they stay in agreement.

Scope and approval

Very small, focused fix for an obvious bug, so no prior issue: find in thread disagrees with the app's own search on a rule the code already states, and the fix copies the sigma fold right next to it (7 non-test lines, one test case).

Overlap search: #27267 (open) fixes curly apostrophes in the server's message-search scan path and #22553 (open) changes the message index. Neither touches threadSearch.ts or find in thread.

Verification

• Red on main: packages/shared vp test run src/threadSearch.test.ts: AssertionError: expected [ 6 ] to deeply equal [ +0, 6 ]
• Green: threadSearch.test.ts 3/3 passed. apps/server vp test run src/orchestration-v2/ThreadFind.test.ts 17/17 passed.
• vp run check:changed: passed (format, lint, knip, typecheck of 34 packages, tests).
• Not checked: a manual pass in a real client. The change is a one-character fold in shared logic, and the test covers both directions plus offsets after a character whose lowercase is longer.

Reviewed with sol-loop: 1 round with GPT-6.1 Sol on high. Sol verdict: approved.

Created with Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at fa0d37b

Macroscope's review found this PR approvable — Thread search now treats straight and curly apostrophes equivalently for match counts and highlights while preserving source offsets. The change is limited to search behavior and does not alter stored content or product defaults.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 5b9731c
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: e1267d60-1c94-426e-beb4-24c9011ca5e1

Commits

Reviewing files that changed from the base of the PR and between 5b9731c and fa0d37b.

Files selected for processing: 2

• packages/shared/src/threadSearch.test.ts
• packages/shared/src/threadSearch.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

Walkthrough

Thread search now normalizes final sigma and curly single quotes during case folding. A new test checks matching apostrophe variants and verifies source offsets, including when a Unicode character precedes the match.

Changes: Thread search folding

Layer / File(s)	Summary
Character folding and offset tests packages/shared/src/threadSearch.ts, packages/shared/src/threadSearch.test.ts	The case-folding function maps final sigma to sigma and curly single quotes to straight apostrophes. Tests check matches and source offsets, including after a Unicode character.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to fa0d3

No actionable merge-blocking risk was identified in this focused search-folding change.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main change: Find in thread now matches a word typed with a curly apostrophe. It follows the conventional commit format and matches the raw summary (folding curly single quotes to …
Description check		The description covers the problem, the change, scope and approval, and verification. The Problem section gives the reproduction cases for straight and curly apostrophes. The Change section names the …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: Find in thread now matches a word typed with a curly apostrophe. It follows the conventional commit format and matches the raw summary (folding curly single quotes to straight apostrophes in foldThreadSearchCase) and the PR objectives.

Full details: Description check

Explanation

The description covers the problem, the change, scope and approval, and verification. The Problem section gives the reproduction cases for straight and curly apostrophes. The Change section names the function and explains why offsets stay valid. The Scope section explains why no prior issue is needed for a small obvious bug, and cites related open PRs. The Verification section lists the failing test before the fix, the passing tests after it, and what was not checked. The template's optional metadata line about the agent model is present. The description meets the template's requirements.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified exact head fa0d37bf4170582a6b8b5276487caf79aa1ced73 against github/main at 61c3794c32 on linux. used the repo's playwright dependency with /usr/bin/google-chrome against real background dev servers, one at a time.

created a project pointing at a real git repository through the app, then sent a real codex gpt-6.1-sol turn containing straight, left-curly, and right-curly apostrophes. preserved that conversation for the comparison. a fresh codex follow-up also completed on the pr head.

• main: each of don't, don’t, and don‘t found only its own form, showing 1/2.
• pr: all three queries and uppercase DON’T showed 1/6, with six correct source highlights across user and provider messages. text following İ retained correct highlight offsets.
• next/previous visited all six occurrences and wrapped correctly. enter, shift+enter, clearing, escape, ctrl+f, and the thread title menu worked.
• neighboring behavior: greek sigma variants still matched six occurrences; plain neighbor needle matched two; an absent query showed 0/0 and disabled navigation.
• observed the real client's orchestration.searchThreadStream websocket requests. existing shared-search and server-find tests passed through blacksmith: 2 files, 20 tests. existing ci checks are green. no code changes were needed.

before, main:

after, pr with the same conversation:

Not verified

native ios/android clients and their smart-punctuation keyboards, the electron shell, remote/relay/tunnel connections, and other providers were not exercised. this pass covered the local web client, running server, and real codex provider on linux.