Skip to content

fix(server): integrate main into snapshot timeout diagnostics - #1

Closed
ElliotDrel wants to merge 246 commits into
Wosca:fix/preview-snapshot-timeout-reportingfrom
ElliotDrel:fix/preview-timeout-main-integration
Closed

ElliotDrel wants to merge 246 commits into
Wosca:fix/preview-snapshot-timeout-reportingfrom
ElliotDrel:fix/preview-timeout-main-integration

Conversation

@ElliotDrel

@ElliotDrel ElliotDrel commented Nov 5, 2026 •

Copy link
Copy Markdown

What Changed and Why

Issue: Upstream PR #24130 conflicts with current main in apps/server/src/preview/ServerBrowserPage.ts.

Why this change was necessary: Main migrated ServerBrowserOperationError to a schema error with object arguments. The contributor's snapshot/frame timeout helpers still used positional arguments. This merge adapts both helpers, preserving the 10,000 ms capture deadline, 1,000 ms frame deadline, pending-stage diagnostics, and current preview features.

New status quo: Merge commit 88363b39f4bed41a6b3f8c049074b2a1b9da68f4 preserves owner head 3f8949a4204ea2211c6a34b93da2ff5a07e40d22 and main 298cb24140fdddebfbfaedad3a097e86ff3d9d04 as parents. This PR targets the owner's branch so the original upstream PR remains the delivery vehicle. The owner-relative diff includes main's history; review the diagnostic-only diff against main separately (five files, 294 additions/30 deletions).

Verification

At 88363b39f4bed41a6b3f8c049074b2a1b9da68f4, Windows/Codex:

  • Broker tests: 27 passed.
  • Snapshot deadline diagnostics: 7 passed; 24 browser-backed cases excluded by the test-name filter.
  • Affected server package typecheck: exit 0 (Effect suggestions only).
  • Targeted lint and formatting: passed on the five diagnostic/test files.
  • git diff origin/main --check: passed.

No browser, dev server, or live provider was run. Earlier provider/client evidence in the upstream verification comment applies to 71dd2616b70e3242257bfe7264f1e73f4c6c1cc7, not this integration head. Background-tab capture failures are outside this conflict-resolution change.

Implemented by GPT-6.1 Sol (gpt-6.1-sol) using the Codex harness in T3 Code.

Hosted checks

The CI, fingerprint, mobile-preview and context-budget runs are approval-gated with zero executed jobs; they are not passing test results or executed test failures. The separate size-label job executed and failed with spawnSync git ENOBUFS while handling the accumulated main-history diff. No CI configuration, labels or history were changed to bypass it. Local verification above remains the available execution evidence; owner approval/incorporation and resulting-head upstream CI are still required.

t3dotgg and others added 30 commits November 2, 2026 22:56
…29909)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…arent's turn (pingdotgg#29752)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…and longer fences (pingdotgg#29755)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ts or subagents (pingdotgg#29917)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… without raw provider text (pingdotgg#29877)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ect under diff.relative (pingdotgg#29879)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…in a subagent or side chat (pingdotgg#29891)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#28684)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…squash-merged (pingdotgg#29919)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ointed parent run (pingdotgg#25662)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
pingdotgg#29580)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
… the project folder (pingdotgg#29908)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Maria <maria-rcks@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…oading it (pingdotgg#29893)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
shivamhwp and others added 25 commits November 5, 2026 06:44
…0085)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gdotgg#28622)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#29044)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ders (pingdotgg#24904)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…0421)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Elliot Drel <elliotdrel@gmail.com>
…gg#28928)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…dotgg#30704)

Co-authored-by: Maxime Cathala <84846651+mcathala@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…onnection in a loop (pingdotgg#23758)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
… it (pingdotgg#24946)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…7935)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…otgg#26464)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Albert Li <albertli_042@hotmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…wake (pingdotgg#28204)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…29838)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#25341)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…ironment disconnects (pingdotgg#31269)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pingdotgg#29639)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…ve Error (pingdotgg#31216)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Merge origin/main at 298cb24, preserving contributor history and current preview behavior. Adapt snapshot and frame timeout helpers to the schema error constructor while retaining the 10-second deadline and pending-stage details.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T04:24:41.773380Z 88363b3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Nov 5, 2026
@ElliotDrel ElliotDrel closed this Nov 6, 2026
@ElliotDrel
ElliotDrel deleted the fix/preview-timeout-main-integration branch November 6, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.