fix(web): keep chat from jumping when the scroll-to-end pill mounts - #12317
Conversation
- Measuring the overlay when the pill mounts reused a stale height against the new resting flag - Reuse the last published overlay height so only clearance updates
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This comment has been minimized.
This comment has been minimized.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused one-file fix that separates composer height measurement from scroll-to-end pill clearance, preventing pill mount/unmounts from disturbing the chat timeline. Its runtime impact is limited to localized scroll and overlay positioning behavior. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthrough
ChangesComposer clearance publishing
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The updated clearance flow preserves the published composer height when the scroll-to-end control changes visibility; no actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
## What's Changed * fix(web): keep PR panel actions in the current thread by @Bil0000 in pingdotgg/t3code#12320 * fix(web): keep browser pages aligned during panel animations by @juliusmarminge in pingdotgg/t3code#12329 * fix(server): bound provider event log records before serialization by @juliusmarminge in pingdotgg/t3code#12305 * fix(server): reject file rewind in shared workspaces by @juliusmarminge in pingdotgg/t3code#12306 * fix(server): capture checkpoints when baseline lookup fails by @juliusmarminge in pingdotgg/t3code#12307 * fix(server): refresh file search outside checkpoint processing by @juliusmarminge in pingdotgg/t3code#12308 * fix(web): keep chat from jumping when the scroll-to-end pill mounts by @Yash-Singh1 in pingdotgg/t3code#12317 * fix(server): checkpoint workspaces with empty nested repositories by @saphid in pingdotgg/t3code#12181 * chore(review): keep review bots out of the vendored .repos references by @juliusmarminge in pingdotgg/t3code#12333 * fix(server): pass Codex image attachments by path to avoid oversized requests by @saphid in pingdotgg/t3code#11050 * feat(web): filter sidebar from thread menu by @saphid in pingdotgg/t3code#8719 * feat(web): open diff files from a right-click context menu by @saphid in pingdotgg/t3code#11842 * fix(web): keep numbered jumps from stealing browser tabs by @Yash-Singh1 in pingdotgg/t3code#12315 * fix(mobile): define Clerk colors in every Uniwind theme by @juliusmarminge in pingdotgg/t3code#12344 * refactor(web): reuse searchable picker inputs by @juliusmarminge in pingdotgg/t3code#12353 * fix(web): share touch-visible pull request edit actions by @juliusmarminge in pingdotgg/t3code#12370 * fix(mobile): share accessible connection trace controls by @juliusmarminge in pingdotgg/t3code#12371 * fix(mobile): share settings control row layout by @juliusmarminge in pingdotgg/t3code#12356 * refactor(web): share diagnostic process actions by @juliusmarminge in pingdotgg/t3code#12358 * refactor(mobile): share Android toolbar search fields by @juliusmarminge in pingdotgg/t3code#12359 * refactor(web): share settings group surfaces by @juliusmarminge in pingdotgg/t3code#12360 * refactor(web): reuse inline settings actions by @juliusmarminge in pingdotgg/t3code#12362 * refactor(mobile): share thread list section controls by @juliusmarminge in pingdotgg/t3code#12363 * refactor(mobile): share connection form fields by @juliusmarminge in pingdotgg/t3code#12364 * refactor(mobile): share local environment lists by @juliusmarminge in pingdotgg/t3code#12365 * refactor(mobile): share file preview feedback by @juliusmarminge in pingdotgg/t3code#12368 * refactor(web): share standalone page layout by @juliusmarminge in pingdotgg/t3code#12354 * fix(mobile): share settings action row defaults by @juliusmarminge in pingdotgg/t3code#12369 * fix(mobile): share request action button defaults by @juliusmarminge in pingdotgg/t3code#12366 * fix(web): share accessible color picker controls by @juliusmarminge in pingdotgg/t3code#12355 **Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260917.1880...v0.0.43-nightly.20260918.1895 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260918.1895
Merges `pingdotgg/t3code` `6d1d549441..9946541` (50 commits) into the fork. Landed 304 files against 303 in the upstream range — the extra one is `docs/fork/inventory.json`. Fork delta is 777 files, unchanged from the last merge. Everything upstream changed landed. Six conflicts, each resolved with the verdict `preflight.mjs` printed; five were a single hunk. Details and reasoning are in [the merge tracker](docs/fork/upstream-merge-log.md). The two worth reading here: - **`ChatView.tsx`** — pingdotgg#12306 added `activeWorktreePath !== null` to the "Revert files too" button, on the line the fork gates with `FEATURES.checkpointFileRestore`. Kept both as a conjunction: upstream's condition is about a shared workspace, the fork's is about what Moatless serves, and they answer different questions. - **`FilePreviewPanel.tsx`** (the one `decide`) — pingdotgg#10909 restructured the file read so a folder is knowable as a folder, adding `isDirectory` / `previewPath`. Took that whole and re-stated the fork's `onRetargetFile` effect on top. `apps/web/src/routeTree.gen.ts` was regenerated rather than hand-resolved. One judgement call: pingdotgg#11598's new `/settings/storage` page is deliberately **not** given a `FEATURES` gate. It self-gates on two new capability booleans Moatless does not report and renders an explanatory notice, so a fork flag would duplicate a decision the wire already makes — and would have to be deleted again the day the capability is reported. ## Usable as-is - Diff files open from a right-click context menu (pingdotgg#11842). - Sidebar filtering from the thread menu (pingdotgg#8719). - Command palette matches thread IDs (pingdotgg#11185). - Mobile settings are easier to navigate and scope (pingdotgg#12272); favorites in the mobile model picker (pingdotgg#12231). - Thoughts collapse within tool groups (pingdotgg#12302); thoughts and failed tool calls stay in one activity row (pingdotgg#12270). - Folder links from chat open the file tree instead of a broken preview (pingdotgg#10909). - Chat no longer jumps when the scroll-to-end pill mounts (pingdotgg#12317); numbered jumps no longer steal browser tabs (pingdotgg#12315); composer banners stay compact (pingdotgg#12166). - A large batch of shared-component refactors across web and mobile (pingdotgg#12353–pingdotgg#12371). ## Unsupported in Moatless / needs implementation - **Pull request files marked as viewed** (pingdotgg#7721) — adds `pullRequests.filesViewed` and `pullRequests.setFilesViewed`, which record which files a reviewer has checked off, persisted server-side. Both declare `PullRequestRpcError` and so arrived already refusing; `unsupported-methods.mjs` reported ADD 0 / DROP 0 as a result. Closes with the rest of the `pullRequests.*` group, not separately. - **Multi-model threads in separate worktrees** (pingdotgg#12179) — one prompt starts a thread per selected model, each in its own worktree. The model picker is the same `worktree` send-mode control `FEATURES.worktreeSelection` already gates, so the fan-out is simply not offered. The same commit adds a `requiredWorktreeBootstrap` capability the backend does not report. - **Automatic storage cleanup settings** (pingdotgg#11598) — the `/settings/storage` page, gated by the backend's absent `storageCleanup` and `projectWorktreeCleanup` capabilities. Needs the sweeper below before the page means anything. - **Command palette entries for the pull requests and usage pages** (pingdotgg#12211) — the PR half is covered by `FEATURES.pullRequestSurface`. ## Backend behavior to consider reproducing in Moatless Eight items, recorded in full in [the gaps register](docs/fork/gaps.md) under _Runtime fixes upstream made to its own server_. Five are on the checkpoint and usage paths the previous merge already opened: - **Reject a file rewind on a shared or nested-owner cwd** (pingdotgg#12306, `CheckpointReactor.ts`) — a checkpoint holds the whole checkout, so restoring one erases a sibling's uncommitted work. Moatless isolates by sandbox, but a workspace with nested repositories has the same overlap inside one task. - **Capture a checkpoint when the baseline lookup fails** (pingdotgg#12307) — the case that silently leaves a turn with no restore point. - **Move the file-search refresh off the checkpoint path** (pingdotgg#12308) — it extended every capture by an index walk. - **Survive an empty nested repository, and clear a stale index lock** (pingdotgg#12181, `GitVcsDriver.ts`) — git cannot stage an embedded repository until it has a commit. The lock half matters most here: forced termination is the normal end of a sandboxed task. - **Bound the provider event log before serialization** (pingdotgg#12305, `EventNdjsonLogger.ts`) — otherwise it grows proportionally to tokens streamed. - **Keep usage totals across transcript cleanup** (pingdotgg#12304, `UsageService.ts`) and **resolve a contested fingerprint to the newest scan** (pingdotgg#10315, `usageMerge.ts`). Moatless serves `server.getUsageSummary` itself. - **Pass provider image attachments by path** (pingdotgg#11050, `CodexAdapter.ts`) — the turn/start request stops scaling with attachment size. A sandbox adds a hop, so an oversized request costs more there. - **Sweep stale worktrees and transcripts against retention rules** (pingdotgg#11598, `storageCleanup.ts`, with a workspace lease so two servers cannot sweep the same directory). A sandbox per task bounds the worktree half; transcripts outlive the sandbox. ## Verification `verify.mjs` — all 9 checks green on the first full pass, tests included (333 test files, 5071 tests). No flaky retries and no caveats. Contract drift: ADD 0 / DROP 0, so `packages/contracts/src/rpc.ts` needed no change. The `orchestration-decode-boilerplate` duplicate-add exception went stale — the colliding line is gone — and was deleted from `inventory.json` in this merge. Owned-concern sweep: the three new `apps/mobile/src/features/connection/` files are false positives, all upstream extracting shared mobile components out of files it already owned, with no fork delta in any of them. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- Moatless task: https://moatless.soaplabstest.com/tasks/c83db5aa-7c47-47c6-93f4-fe2f6f9f548e
What Changed
Chat no longer remeasures the composer overlay when the scroll-to-end pill mounts. Overlay height stays whatever the composer last published; the pill only refreshes its clearance from that height.
Usage scans no longer keep aggregating cached records after a transcript file is gone.
pruneScanCachenow drops in-window entries under roots the walk actually completed, and leaves entries outside that window (and under unwalked roots) in place. The extra source-volume identity cache and Codex same-timestamp occurrence keys went with the old “keep usage after cleanup” path.Why
The pill mounts and unmounts in the same commits that expand or rest the composer. A fast fling can land there while the overlay is still pinned at the previous tween height. Measuring then published that stale height against the new resting flag, dropped the timeline inset, and yanked scroll. The pill only needs clearance, so it should not drive overlay height.
Absence from a walk only proves a file is gone inside the requested window. Treating missing transcripts as still live inflated totals and needed extra identity/dedupe machinery. Evicting everything the walk did not see would also wipe 30-day cache entries whenever someone opened 7 days.
UI Changes
Fast-fling to the bottom should keep the thread still when the scroll-to-end pill appears while the composer is settling. This is a motion/layout bug; a short recording of that fling is the right evidence. None is attached here.
Checklist
Cursor Grok 4.6
Summary by CodeRabbit