feat(web): command palette search matches thread IDs - #11185
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The PR adds thread IDs to the existing command-palette search terms with no changes to schemas, workflows, or production defaults. Its small, isolated runtime change is covered by a focused ranking and matching test. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThread action items now include thread IDs in their search terms. Tests verify ID-based matching and preserve title-match ordering. ChangesThread ID command palette search
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to Thread IDs are searchable in the web command palette with title-first ordering preserved. No merge-blocking risk was identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
On the docstring-coverage warning: this repo's convention is no per-function docstrings; intent lives in the test name and the code comment on the searchTerms ordering. Leaving as-is to match upstream style. |
## What's Changed * fix(server): settle cancelled worktree setup before rollback by @juliusmarminge in pingdotgg/t3code#12176 * feat(mobile): port worktree setup progress and agent handoff by @juliusmarminge in pingdotgg/t3code#12177 * fix(server): flush checkpoint objects and refs before publishing them by @Mnigos in pingdotgg/t3code#10944 * fix(server): keep ready checkpoints when a later placeholder arrives by @Adolanium in pingdotgg/t3code#8432 * fix(server): keep VCS waits from blocking turn completion by @Vrtak-CZ in pingdotgg/t3code#11970 * fix(web): keep header spacing stable when sidebar drawer opens by @flamboh in pingdotgg/t3code#12162 * fix(web): fall back when pull request avatars fail by @tastelessjolt in pingdotgg/t3code#11728 * feat(web): enable rich text composer by default by @juliusmarminge in pingdotgg/t3code#12160 * feat(web): make keybindings searchable from settings search by @maria-rcks in pingdotgg/t3code#12175 * fix(web): preserve thread reading positions by @maria-rcks in pingdotgg/t3code#12144 * fix(diff): collapse files by default by @maria-rcks in pingdotgg/t3code#12190 * fix(web): folder links from chat open the file tree instead of a broken preview by @pc-style in pingdotgg/t3code#10909 * feat(web): command palette search matches thread IDs by @saphid in pingdotgg/t3code#11185 * fix(web): align notification icons with titles by @maria-rcks in pingdotgg/t3code#12202 * fix(skills): support unicode currency symbols as skill aliases by @WilgotM in pingdotgg/t3code#12098 * feat(settings): add automatic storage cleanup per machine and project by @maria-rcks in pingdotgg/t3code#11598 * feat(web): command palette finds the pull requests and usage pages by @flamboh in pingdotgg/t3code#12211 * feat(web): start new threads with multiple models in separate worktrees by @maria-rcks in pingdotgg/t3code#12179 ## New Contributors * @Adolanium made their first contribution in pingdotgg/t3code#8432 * @Vrtak-CZ made their first contribution in pingdotgg/t3code#11970 * @pc-style made their first contribution in pingdotgg/t3code#10909 **Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260917.1837...v0.0.43-nightly.20260917.1851 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260917.1851
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merges `pingdotgg/t3code` `6d1d549441..9946541` (50 commits) into the fork. Landed 304 files against 303 in the upstream range — the extra one is `docs/fork/inventory.json`. Fork delta is 777 files, unchanged from the last merge. Everything upstream changed landed. Six conflicts, each resolved with the verdict `preflight.mjs` printed; five were a single hunk. Details and reasoning are in [the merge tracker](docs/fork/upstream-merge-log.md). The two worth reading here: - **`ChatView.tsx`** — pingdotgg#12306 added `activeWorktreePath !== null` to the "Revert files too" button, on the line the fork gates with `FEATURES.checkpointFileRestore`. Kept both as a conjunction: upstream's condition is about a shared workspace, the fork's is about what Moatless serves, and they answer different questions. - **`FilePreviewPanel.tsx`** (the one `decide`) — pingdotgg#10909 restructured the file read so a folder is knowable as a folder, adding `isDirectory` / `previewPath`. Took that whole and re-stated the fork's `onRetargetFile` effect on top. `apps/web/src/routeTree.gen.ts` was regenerated rather than hand-resolved. One judgement call: pingdotgg#11598's new `/settings/storage` page is deliberately **not** given a `FEATURES` gate. It self-gates on two new capability booleans Moatless does not report and renders an explanatory notice, so a fork flag would duplicate a decision the wire already makes — and would have to be deleted again the day the capability is reported. ## Usable as-is - Diff files open from a right-click context menu (pingdotgg#11842). - Sidebar filtering from the thread menu (pingdotgg#8719). - Command palette matches thread IDs (pingdotgg#11185). - Mobile settings are easier to navigate and scope (pingdotgg#12272); favorites in the mobile model picker (pingdotgg#12231). - Thoughts collapse within tool groups (pingdotgg#12302); thoughts and failed tool calls stay in one activity row (pingdotgg#12270). - Folder links from chat open the file tree instead of a broken preview (pingdotgg#10909). - Chat no longer jumps when the scroll-to-end pill mounts (pingdotgg#12317); numbered jumps no longer steal browser tabs (pingdotgg#12315); composer banners stay compact (pingdotgg#12166). - A large batch of shared-component refactors across web and mobile (pingdotgg#12353–pingdotgg#12371). ## Unsupported in Moatless / needs implementation - **Pull request files marked as viewed** (pingdotgg#7721) — adds `pullRequests.filesViewed` and `pullRequests.setFilesViewed`, which record which files a reviewer has checked off, persisted server-side. Both declare `PullRequestRpcError` and so arrived already refusing; `unsupported-methods.mjs` reported ADD 0 / DROP 0 as a result. Closes with the rest of the `pullRequests.*` group, not separately. - **Multi-model threads in separate worktrees** (pingdotgg#12179) — one prompt starts a thread per selected model, each in its own worktree. The model picker is the same `worktree` send-mode control `FEATURES.worktreeSelection` already gates, so the fan-out is simply not offered. The same commit adds a `requiredWorktreeBootstrap` capability the backend does not report. - **Automatic storage cleanup settings** (pingdotgg#11598) — the `/settings/storage` page, gated by the backend's absent `storageCleanup` and `projectWorktreeCleanup` capabilities. Needs the sweeper below before the page means anything. - **Command palette entries for the pull requests and usage pages** (pingdotgg#12211) — the PR half is covered by `FEATURES.pullRequestSurface`. ## Backend behavior to consider reproducing in Moatless Eight items, recorded in full in [the gaps register](docs/fork/gaps.md) under _Runtime fixes upstream made to its own server_. Five are on the checkpoint and usage paths the previous merge already opened: - **Reject a file rewind on a shared or nested-owner cwd** (pingdotgg#12306, `CheckpointReactor.ts`) — a checkpoint holds the whole checkout, so restoring one erases a sibling's uncommitted work. Moatless isolates by sandbox, but a workspace with nested repositories has the same overlap inside one task. - **Capture a checkpoint when the baseline lookup fails** (pingdotgg#12307) — the case that silently leaves a turn with no restore point. - **Move the file-search refresh off the checkpoint path** (pingdotgg#12308) — it extended every capture by an index walk. - **Survive an empty nested repository, and clear a stale index lock** (pingdotgg#12181, `GitVcsDriver.ts`) — git cannot stage an embedded repository until it has a commit. The lock half matters most here: forced termination is the normal end of a sandboxed task. - **Bound the provider event log before serialization** (pingdotgg#12305, `EventNdjsonLogger.ts`) — otherwise it grows proportionally to tokens streamed. - **Keep usage totals across transcript cleanup** (pingdotgg#12304, `UsageService.ts`) and **resolve a contested fingerprint to the newest scan** (pingdotgg#10315, `usageMerge.ts`). Moatless serves `server.getUsageSummary` itself. - **Pass provider image attachments by path** (pingdotgg#11050, `CodexAdapter.ts`) — the turn/start request stops scaling with attachment size. A sandbox adds a hop, so an oversized request costs more there. - **Sweep stale worktrees and transcripts against retention rules** (pingdotgg#11598, `storageCleanup.ts`, with a workspace lease so two servers cannot sweep the same directory). A sandbox per task bounds the worktree half; transcripts outlive the sandbox. ## Verification `verify.mjs` — all 9 checks green on the first full pass, tests included (333 test files, 5071 tests). No flaky retries and no caveats. Contract drift: ADD 0 / DROP 0, so `packages/contracts/src/rpc.ts` needed no change. The `orchestration-decode-boilerplate` duplicate-add exception went stale — the colliding line is gone — and was deleted from `inventory.json` in this merge. Owned-concern sweep: the three new `apps/mobile/src/features/connection/` files are false positives, all upstream extracting shared mobile components out of files it already owned, with no fork delta in any of them. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- Moatless task: https://moatless.soaplabstest.com/tasks/c83db5aa-7c47-47c6-93f4-fe2f6f9f548e
What Changed
The command palette (⌘K) now matches threads by their ID. Pasting a thread ID from "Copy thread ID" into the palette search surfaces that thread directly, which previously returned nothing unless the ID happened to appear in the title, branch, or message content.
Scope: web client only (
apps/webcommand palette). Mobile's thread search screens, the server-side content search (searchThreads), and wire contracts are unchanged. Desktop inherits the change through its bundled web UI.Why
Thread IDs are already a first-class user-facing handle (the thread action menu exposes "Copy thread ID"), and support workflows revolve around pasting an ID to find a thread. The palette's
buildThreadActionItemsbuilds its search haystack from title, PR relations, project title, branch, and content snippets, but never the ID, so an exact ID query missed every thread.The fix is one line plus a test: add
thread.idto the search terms, last so pasted IDs never outrank title matches for shared substrings. No upstream issue or Ideas discussion exists for this; this PR body carries the motivation.Verification
surfaces threads when the query is their ID, without outranking title matchesinapps/web/src/components/CommandPalette.logic.test.ts: builds two threads where one matches by ID and the other by a title that embeds that ID, queries with an uppercase, whitespace-padded ID, and asserts both surface with the title match ranked first.pnpm exec vp test run apps/web/src/components/CommandPalette.logic.test.ts: 29 passed, 0 failed.pnpm run typecheckinapps/web: passed (0 errors).No screenshots: this changes which results a query returns, not any layout or styling. A live client capture pass was attempted in an isolated environment but the fresh-install web client could not establish its connection on either this branch or the merge-base, so evidence is the focused test above.
Checklist
Implementation used enablers/xlarge (GLM) in T3 Code. Independent review used GPT 6 Astra (high) via CLIProxyAPI (the configured Fable 5.1 reviewer was unavailable at the gateway; its one test-coverage suggestion is applied in 415f4a5).
Summary by CodeRabbit
New Features
Tests