refactor(mobile): share connection form fields

[juliusmarminge]

Targets main independently. This PR has no dependency on V2 or another UI audit PR.

New-connection and edit-connection fields repeated labels and input layout with different padding and native wrapper behavior. ConnectionFormField owns field geometry, label accessibility, and the retained native view. Consumers keep values, keyboard settings, normalization, and submission.

Validation: pairing and environmentSections tests, affected client typecheck, scoped lint, and React Doctor review. React Doctor’s existing consumer findings remain documented from the original audit; no new component findings were identified.

Code-only verification was requested; no browser/device pass or before/after screenshots are included. This remains a draft for visual review. No wire contracts, persisted data, or upgrade migrations change.

Model: GPT-6. Harness: Codex.

Summary by CodeRabbit

• Refactor
  • Standardized connection form fields across the mobile app with a shared labeled input component.
  • Preserved existing labels, values, placeholders, input behavior, and change handling for connection details.
  • Improved consistency and accessibility of connection form inputs.

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	−1 B (−0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	+5 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.4 KiB	−6 B (−0.1%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.3 KiB	56.3 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	−5 B (−0.0%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	+5 B (+0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−10 B (−0.2%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	9	9	0 (0.0%)	21	✅

Baseline: 53510d4 · PR result: e6bbe15 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.9 KiB
• Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at e6bbe15

Macroscope's review found this PR approvable — The PR consolidates duplicated connection-form markup into a small shared component while preserving input behavior and business logic. Its only runtime differences are minor field styling, native-wrapper behavior, and improved accessibility labeling.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 818a2514-e004-4354-81b7-ef605179b922

📥 Commits

Reviewing files that changed from the base of the PR and between 53510d4 and e6bbe15.

📒 Files selected for processing (3)

• apps/mobile/src/features/connection/ConnectionEnvironmentRow.tsx
• apps/mobile/src/features/connection/ConnectionFormField.tsx
• apps/mobile/src/features/connection/ConnectionsNewRouteScreen.tsx

Limit details: You’ve used all 10 included reviews currently available.

---

📝 Walkthrough

Walkthrough

The change adds a shared ConnectionFormField component and replaces duplicated input markup in the connection environment and new connection screens. Existing field values, handlers, labels, placeholders, and input settings remain unchanged.

Changes

Connection form field reuse

Layer / File(s)	Summary
Shared field component apps/mobile/src/features/connection/ConnectionFormField.tsx	Adds ConnectionFormField with typed input props, label rendering, merged wrapper styling, accessibility labeling, and forwarded AppTextInput props.
Connection form integrations apps/mobile/src/features/connection/ConnectionEnvironmentRow.tsx, apps/mobile/src/features/connection/ConnectionsNewRouteScreen.tsx	Replaces duplicated input markup with ConnectionFormField for environment label and URL fields, plus host and pairing code fields. Existing input configuration and handlers remain in place.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to e6bbe

The shared form field refactor does not show an actionable regression in the reviewed connection flows and is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: sharing connection form fields in the mobile app.
Description check	✅ Passed	The description explains what changed, why the shared component is needed, validation performed, scope, and the draft visual-review status. It does not use the template headings or include the checkli…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 3
• Charged: $0.75
• View usage details

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

---

_{Comment @coderabbitai help to get the list of available commands.}