refactor(mobile): share local environment lists

[juliusmarminge]

Targets main independently. This PR has no dependency on V2 or another UI audit PR.

Connections and environment settings duplicated local environment cards, separators, empty states, and row wiring. LocalEnvironmentList owns that shared presentation while preserving native wrappers, expansion state, callbacks, navigation, and cloud discovery.

Validation: environmentSections tests, affected client typecheck, scoped lint, and React Doctor review. React Doctor’s existing consumer findings remain documented from the original audit; no new component findings were identified.

Code-only verification was requested; no browser/device pass or before/after screenshots are included. This remains a draft for visual review. No wire contracts, persisted data, or upgrade migrations change.

Model: GPT-6. Harness: Codex.

Summary by CodeRabbit

• UI Improvements
  • Standardized connected-environment lists across connection and settings screens.
  • Added a consistent empty state when no local environments are connected.
  • Preserved environment expansion, toggling, row actions, and showcase URL handling.

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	+21 B (+0.2%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.1 KiB	7.1 KiB	+6 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+15 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	56.3 KiB	56.3 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	−20 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.1 KiB	−2 B (−0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−18 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	9	9	0 (0.0%)	21	✅

Baseline: 53510d4 · PR result: 1bab55e · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 114.0 KiB
• Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at 1bab55e

Macroscope's review found this PR approvable — This is a focused mobile refactor that consolidates identical local-environment list and empty-state rendering without changing data flow, callbacks, navigation, or persisted behavior. The new production component is organizational only and introduces no new user-facing capability or sensitive configuration change.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 87ba8b19-ca3b-47f8-8050-7bddd0c39c8a

📥 Commits

Reviewing files that changed from the base of the PR and between 53510d4 and 1bab55e.

📒 Files selected for processing (3)

• apps/mobile/src/features/connection/ConnectionsRouteScreen.tsx
• apps/mobile/src/features/connection/LocalEnvironmentList.tsx
• apps/mobile/src/features/settings/SettingsEnvironmentsRouteScreen.tsx

Limit details: You’ve used all 10 included reviews currently available.

---

📝 Walkthrough

Walkthrough

The change adds a shared LocalEnvironmentList component and replaces duplicated local environment rendering in two mobile screens. The component handles empty states, environment rows, expansion, toggles, actions, and separators.

Changes

Local environment rendering

Layer / File(s)	Summary
Shared list component apps/mobile/src/features/connection/LocalEnvironmentList.tsx	LocalEnvironmentList renders the empty state or environment rows. It forwards row actions, handles expansion and toggles, and adds separators.
Screen integrations apps/mobile/src/features/connection/ConnectionsRouteScreen.tsx, apps/mobile/src/features/settings/SettingsEnvironmentsRouteScreen.tsx	Both screens now pass environment data, expansion state, and callbacks to LocalEnvironmentList. Inline rendering and unused derived values were removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Refactor

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to 1bab5

The refactor preserves the local-environment behavior in both mobile screens, with no actionable regression identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: sharing local environment lists across mobile screens.
Description check	✅ Passed	The description explains the refactor, rationale, preserved behavior, validation, and UI-review limitations. It does not use the template headings or checklist, but it provides the required informatio…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 3
• Charged: $0.75
• View usage details

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

---

_{Comment @coderabbitai help to get the list of available commands.}