fix(web): share touch-visible pull request edit actions - #12370
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
f5cdbad to
f613f9c
Compare
d6f4a91 to
ca81d9e
Compare
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, isolated web UI fix that centralizes existing pull-request edit buttons and makes them visible on touch devices without changing permissions, handlers, data contracts, or other production workflows. The runtime impact is limited to presentation and accessibility behavior. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughThe pull request adds a shared ChangesPull request edit controls
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The edit controls retain their existing actions and remain available through hover, focus, and coarse-pointer interactions; no merge-blocking regression was identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Usage-based review receipt
Note This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing. Comment |
## What's Changed * fix(web): keep PR panel actions in the current thread by @Bil0000 in pingdotgg/t3code#12320 * fix(web): keep browser pages aligned during panel animations by @juliusmarminge in pingdotgg/t3code#12329 * fix(server): bound provider event log records before serialization by @juliusmarminge in pingdotgg/t3code#12305 * fix(server): reject file rewind in shared workspaces by @juliusmarminge in pingdotgg/t3code#12306 * fix(server): capture checkpoints when baseline lookup fails by @juliusmarminge in pingdotgg/t3code#12307 * fix(server): refresh file search outside checkpoint processing by @juliusmarminge in pingdotgg/t3code#12308 * fix(web): keep chat from jumping when the scroll-to-end pill mounts by @Yash-Singh1 in pingdotgg/t3code#12317 * fix(server): checkpoint workspaces with empty nested repositories by @saphid in pingdotgg/t3code#12181 * chore(review): keep review bots out of the vendored .repos references by @juliusmarminge in pingdotgg/t3code#12333 * fix(server): pass Codex image attachments by path to avoid oversized requests by @saphid in pingdotgg/t3code#11050 * feat(web): filter sidebar from thread menu by @saphid in pingdotgg/t3code#8719 * feat(web): open diff files from a right-click context menu by @saphid in pingdotgg/t3code#11842 * fix(web): keep numbered jumps from stealing browser tabs by @Yash-Singh1 in pingdotgg/t3code#12315 * fix(mobile): define Clerk colors in every Uniwind theme by @juliusmarminge in pingdotgg/t3code#12344 * refactor(web): reuse searchable picker inputs by @juliusmarminge in pingdotgg/t3code#12353 * fix(web): share touch-visible pull request edit actions by @juliusmarminge in pingdotgg/t3code#12370 * fix(mobile): share accessible connection trace controls by @juliusmarminge in pingdotgg/t3code#12371 * fix(mobile): share settings control row layout by @juliusmarminge in pingdotgg/t3code#12356 * refactor(web): share diagnostic process actions by @juliusmarminge in pingdotgg/t3code#12358 * refactor(mobile): share Android toolbar search fields by @juliusmarminge in pingdotgg/t3code#12359 * refactor(web): share settings group surfaces by @juliusmarminge in pingdotgg/t3code#12360 * refactor(web): reuse inline settings actions by @juliusmarminge in pingdotgg/t3code#12362 * refactor(mobile): share thread list section controls by @juliusmarminge in pingdotgg/t3code#12363 * refactor(mobile): share connection form fields by @juliusmarminge in pingdotgg/t3code#12364 * refactor(mobile): share local environment lists by @juliusmarminge in pingdotgg/t3code#12365 * refactor(mobile): share file preview feedback by @juliusmarminge in pingdotgg/t3code#12368 * refactor(web): share standalone page layout by @juliusmarminge in pingdotgg/t3code#12354 * fix(mobile): share settings action row defaults by @juliusmarminge in pingdotgg/t3code#12369 * fix(mobile): share request action button defaults by @juliusmarminge in pingdotgg/t3code#12366 * fix(web): share accessible color picker controls by @juliusmarminge in pingdotgg/t3code#12355 **Full Changelog**: pingdotgg/t3code@v0.0.43-nightly.20260917.1880...v0.0.43-nightly.20260918.1895 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.43-nightly.20260918.1895
Targets
mainindependently. This PR has no dependency on V2 or another UI audit PR.Five pull-request edit buttons duplicated hover-only visibility and remained hidden on touch screens. PullRequestEditButton now owns the pencil icon, focus behavior, motion defaults, and coarse-pointer visibility. Permissions, edit targets, handlers, and local placement remain with each consumer.
Validation: focused pull-request component tests, affected client typecheck, scoped lint, and React Doctor review. React Doctor’s existing consumer findings remain documented from the original audit; no new component findings were identified.
Code-only verification was requested; no browser/device pass or before/after screenshots are included. This remains a draft for visual review. No wire contracts, persisted data, or upgrade migrations change.
Model: GPT-6. Harness: Codex.
Summary by CodeRabbit