fix(signals): classify Java gRPC service stubs as generated - #3580
fix(signals): classify Java gRPC service stubs as generated#3580luciferlive112116 wants to merge 1 commit into
Conversation
Recognize grpc-java *Grpc.java protoc output in isGeneratedFile, matching the existing Swift/Kotlin gRPC stub conventions. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 311 311
Lines 31702 31702
Branches 11579 11579
=======================================
Hits 29533 29533
Misses 1517 1517
Partials 652 652
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 18:08:15 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (conflicts with the base branch — resolve and open a fresh PR). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
Extend
isGeneratedFileto recognize grpc-java service stubs (*Grpc.java), matching the existing Swift.grpc.swiftand KotlinGrpcKt.ktconventions. Includes positive/negativeisGeneratedFile/classifyChangedFileassertions and a classification-table entry.Fixes #561
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run typechecknpx vitest run test/unit/path-matchers.test.ts(45/45 pass)npm run test:coveragelocally; codecov/patch requires >=99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
Safety
UI Evidence
N/A — signals-only change with no visible UI.
Notes
Incremental maintenance parity for the path-matcher slop signals from #561. Supersedes closed #3572 (auto-closed due to duplicate #561 overlap with #3549; neither PR merged). Only this PR links #561 while open.
Made with Cursor