fix(review): skip bytecode paths in grounding and diff priority - #3592
Closed
jimcody1995 wants to merge 2 commits into
Closed
fix(review): skip bytecode paths in grounding and diff priority#3592jimcody1995 wants to merge 2 commits into
jimcody1995 wants to merge 2 commits into
Conversation
Avoid fetching Java .class/.jar and Python .pyc/.pyo as full file text during review grounding — they carry no review signal and waste tokens. Co-authored-by: Cursor <cursoragent@cursor.com>
Extend SKIP_EXT and diffFilePriority to treat Java .class/.jar and Python .pyc/.pyo as non-reviewable noise so grounding fetch and diff budget ordering stay aligned. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Owner
|
Please work on new/open issues, not closed issues. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3592 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 313 313
Lines 31874 31874
Branches 11666 11666
=======================================
Hits 29705 29705
Misses 1517 1517
Partials 652 652
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKIP_EXTinreview-grounding.tssofetchFullFileContentsskips Java bytecode (.class,.jar) and Python bytecode (.pyc,.pyo).diffFilePriorityinreview-grounding.tsandreview-diff.tsso those paths rank as noise(4) under a tight diff budget — same tier as lockfiles/minified/source maps.getFileContentcalls and assert bytecode paths are never requested, plus directdiffFilePriorityassertions for all four extensions.Fixes #561
Scope
CONTRIBUTING.md.Validation
git diff --checknpm run test:cion Node 22npm audit --audit-level=moderate— 0 vulnerabilitiesSafety
UI Evidence
N/A — backend review grounding only.
Notes
Conflict avoidance: Touches only
src/review/review-grounding.ts,src/review/review-diff.ts, and their unit tests. Zero overlap with open PRs (#3580 path-matchers Java gRPC, #3585 enrichment binary-extensions, #3586 hardcoded-URL, #3584/#3582 unused-export, #3577 suggested-change blocks, #3550 manual-review label).Supersedes closed #3588 (same change; added linked issue + diffFilePriority parity per bot review).
Made with Cursor