fix(review): skip bytecode and JAR paths in grounding fetch - #3588
fix(review): skip bytecode and JAR paths in grounding fetch#3588jimcody1995 wants to merge 1 commit into
Conversation
Avoid fetching Java .class/.jar and Python .pyc/.pyo as full file text during review grounding — they carry no review signal and waste tokens. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-05 18:05:42 UTC
🛑 Suggested Action - Reject/Close
Review summary Nits — 4 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (No linked issue detected; Maintainer requires a linked issue). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3588 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 312 312
Lines 31864 31864
Branches 11661 11661
=======================================
Hits 29695 29695
Misses 1517 1517
Partials 652 652
🚀 New features to boost your workflow:
|
Summary
SKIP_EXTinreview-grounding.tssofetchFullFileContentsskips Java bytecode (.class,.jar) and Python bytecode (.pyc,.pyo) alongside existing binary/lockfile extensions.getFileContentcalls and asserts these paths are never requested — same proven pattern as fix(review): skip additional binary extensions in full-file grounding #3404.Scope
CONTRIBUTING.md.Validation
git diff --checknpm run test:cion Node 22npm audit --audit-level=moderate— 0 vulnerabilitiesreadsexcludes all binary paths before fetchSafety
UI Evidence
N/A — backend review grounding only.
Notes
Conflict avoidance: Touches only
src/review/review-grounding.tsandtest/unit/review-grounding.test.ts. Zero overlap with open PRs (#3580 path-matchers Java gRPC, #3585 enrichment binary-extensions, #3586 hardcoded-URL, #3584/#3582 unused-export, #3577 suggested-change blocks, #3550 manual-review label).Made with Cursor