fix(signals): classify Java gRPC service stubs as generated - #3572
fix(signals): classify Java gRPC service stubs as generated#3572luciferlive112116 wants to merge 1 commit into
Conversation
Extend isGeneratedFile to recognize grpc-java *Grpc.java stubs, matching the existing GrpcKt.kt coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-05 17:33:11 UTC
🛑 Suggested Action - Reject/Close
Review summary Nits — 3 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (Linked issue overlaps another open PR; duplicate of another open PR). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3572 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 305 305
Lines 31532 31532
Branches 11509 11509
=======================================
Hits 29361 29361
Misses 1517 1517
Partials 654 654
🚀 New features to boost your workflow:
|
Summary
Extend
isGeneratedFileto recognize grpc-java service stubs (*Grpc.java), matching the existing.pb.ktmessage-stub and*GrpcKt.ktcoroutine-stub coverage. Includes directisGeneratedFile/classifyChangedFileassertions and a hand-authored.javanegative case.Fixes #561
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run typechecknpx vitest run test/unit/path-matchers.test.ts(45/45 pass)npm run test:coverage— changed lines covered by new positive/negativeisGeneratedFileandclassifyChangedFilecasesnpm run test:workers— not applicable (signals-only)npm run build:mcp— not applicablenpm run test:mcp-pack— not applicablenpm run ui:openapi:check— not applicablenpm run ui:lint— not applicablenpm run ui:typecheck— not applicablenpm run ui:build— not applicablenpm audit --audit-level=moderate— not applicableIf any required check was skipped, explain why:
test:coverageruns on CI. Local validation:npm run typecheck+ targeted vitest file above.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — signals-only change with no visible UI.
Notes
grpc.javasuffix (parallel togrpckt.kt).