fix(signals): classify grpc-node JS/TS protobuf stubs as generated - #3549
fix(signals): classify grpc-node JS/TS protobuf stubs as generated#3549jimcody1995 wants to merge 1 commit into
Conversation
Recognize grpc-node *_pb.js/ts and *_grpc_pb.js/ts output in isGeneratedFile alongside the existing .pb.js/.pb.ts dot-form protoc plugin coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3549 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 302 302
Lines 31504 31504
Branches 11504 11504
=======================================
Hits 29333 29333
Misses 1517 1517
Partials 654 654
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 16:53:21 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
JSONbored
left a comment
There was a problem hiding this comment.
Farming already closed issues, please focus on new/currently open issues.
Summary
Extend
isGeneratedFileto recognize grpc-node message/service stubs (*_pb.js,*_pb.ts,*_grpc_pb.js,*_grpc_pb.ts), matching the existing.pb.js/.pb.tsdot-form protoc coverage. Includes directisGeneratedFile/classifyChangedFileassertions and hand-authored.js/.tsnegative cases.Fixes #561
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — signals-only change with no visible UI.
Notes
Incremental maintenance parity for the path-matcher slop signals from #561. Supports generated-file classification work tracked in #2279.
Made with Cursor