Skip to content

Add a paragraph and a screenshot for the Interactive features in readme.md#1496

Closed
ronglums wants to merge 12 commits intoDonJayamanne:masterfrom
microsoft:ronglu_edit
Closed

Add a paragraph and a screenshot for the Interactive features in readme.md#1496
ronglums wants to merge 12 commits intoDonJayamanne:masterfrom
microsoft:ronglu_edit

Conversation

@ronglums
Copy link
Copy Markdown
Contributor

Add a paragraph and a gif screenshot for the Data Science Interactive features so they are covered on the main Python extension marketplace page.

d3r3kk and others added 12 commits March 14, 2019 06:50
* Add Copyright/license header to testing_tools
* Add some tests against the pythonFiles
* Corrected tooltip for folders

* fix CI

* updated icons

* corrected tooltip

* round time to 3 decimal places
This PR cleans up our nightly build. Some issues remains as there is not a reliable fix yet (#4760).
- skip flaky tests
- remove mocha-vsts-reporter from use
- update build badges to point to new AzDO
Pushing over spurious Windows - Debugger failure.
* Fixes to running of tests
* News entry
* Added tests
* Strong typing for commands
* Strong typing for command handlers
* Change property from focus to focus_code
* Move old PR + CI definition into CI-only file.
  - Make way for the new PR validation build def
  - Update triggers to only be for CI
- Now documented more completely.
- simplified steps to run, and adding new steps should be straightforward.
- Removed tests from PR validation to speed it up (Windows system tests are really the big ones)
- Fix some unit tests
Allows user to always use the light theme in the
Python Interactive Window

For #4640

<!--
  If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.:
    - [x] ~Has unit tests & system/integration tests~
-->
- [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
- [x] Title summarizes what is changing
- [x] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!)
- [ ] Has sufficient logging.
- [ ] Has telemetry for enhancements.
- [x] Unit tests & system/integration tests are added/updated
- [ ] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate
- [ ] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed)
- [ ] The wiki is updated with any design decisions/details.
(for #4035)

We are moving to a relatively flat format that captures parent "nodes", in addition to tests. The new format looks like this:

```json
[{
    "rootid": ".",
    "root": "/x/y/z",
    "parents": [{
        "id": "./test_spam.py",
        "kind": "file",
        "name": "test_spam.py",
        "parentid": "."
    }, {
        "id": "./test_spam.py::SpamTests",
        "kind": "suite",
        "name": "SpamTests",
        "parentid": "./test_spam.py"
    },
    "tests" [{
        "id": "./test_spam.py::test_all",
        "name": "test_all",
        "source": "test_spam.py:11",
        "markers": ["skip", "expected-failure"],
        "parentid": "./test_spam.py"
    }, {
        "id": "./test_spam.py::SpamTests::test_spam1",
        "name": "test_spam1",
        "source": "test_spam.py:23",
        "markers": ["skip"],
        "parentid": "./test_spam.py::SpamTests"
    }]
```

This also fixes a couple of bugs that I found while working on the change.
* Fix liveshare failure when run without variables.
Add more logging

* Actually add the 'toConsole' option

* Run just the functional tests

* Make just windows test run

* Some fixes for cancel tests failing.

* Fix unit test failure

* Fix failing functional tests on real jupyter

* Fix hygiene

* Fix unit tests

* Try to fix restart problems by skipping waiting.

* Fix wait for idle to not wait for the ready signal.

* Put jobs back for full test

* Add functional to PR validation

* Update pr yaml and add news entries.

* Review feedback
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2019

Codecov Report

Merging #1496 into master will increase coverage by 1%.
The diff coverage is 59%.

@@          Coverage Diff           @@
##           master   #1496   +/-   ##
======================================
+ Coverage      62%     62%   +1%     
======================================
  Files         373     373           
  Lines       14652   14687   +35     
  Branches     1161    1167    +6     
======================================
+ Hits         9005    9038   +33     
- Misses       5446    5447    +1     
- Partials      201     202    +1

Copy link
Copy Markdown
Owner

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants