Skip to content

Fixes to test execution with strong typing of commands#4729

Merged
DonJayamanne merged 13 commits intomicrosoft:masterfrom
DonJayamanne:issue4713
Mar 15, 2019
Merged

Fixes to test execution with strong typing of commands#4729
DonJayamanne merged 13 commits intomicrosoft:masterfrom
DonJayamanne:issue4713

Conversation

@DonJayamanne
Copy link
Copy Markdown

@DonJayamanne DonJayamanne commented Mar 12, 2019

For #4713

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.
    https://github.com/Microsoft/vscode-python/wiki/Commands

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2019

Codecov Report

Merging #4729 into master will increase coverage by 1%.
The diff coverage is 70%.

@@          Coverage Diff           @@
##           master   #4729   +/-   ##
======================================
+ Coverage      77%     77%   +1%     
======================================
  Files         449     450    +1     
  Lines       21650   21649    -1     
  Branches     3552    3553    +1     
======================================
+ Hits        16617   16631   +14     
+ Misses       5029    5014   -15     
  Partials        4       4
Flag Coverage Δ
#Linux 66% <38%> (+1%) ⬆️
#Windows 66% <38%> (ø) ⬇️
#macOS 66% <38%> (+1%) ⬆️

Copy link
Copy Markdown

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne DonJayamanne marked this pull request as ready for review March 13, 2019 17:16
@DonJayamanne DonJayamanne reopened this Mar 13, 2019
@DonJayamanne DonJayamanne merged commit 086dd85 into microsoft:master Mar 15, 2019
@DonJayamanne DonJayamanne deleted the issue4713 branch May 24, 2019 20:25
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants