Add test coverage: normalizeForInterpreter.py#4680
Merged
d3r3kk merged 4 commits intomicrosoft:masterfrom Mar 14, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4680 +/- ##
========================================
+ Coverage 62% 77% +16%
========================================
Files 371 447 +76
Lines 14486 21343 +6857
Branches 1148 3491 +2343
========================================
+ Hits 8878 16344 +7466
+ Misses 5407 4995 -412
+ Partials 201 4 -197
|
Member
|
Before even looking at your code I'm going to tell you your file name is named incorrectly. 😉 |
brettcannon
suggested changes
Mar 11, 2019
- basic tests for the normalization script
Codecov Report
@@ Coverage Diff @@
## master #4680 +/- ##
======================================
Coverage 62% 62%
======================================
Files 371 371
Lines 14486 14486
Branches 1148 1148
======================================
Hits 8878 8878
Misses 5407 5407
Partials 201 201 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4680 +/- ##
======================================
Coverage 62% 62%
======================================
Files 371 371
Lines 14486 14486
Branches 1148 1148
======================================
Hits 8878 8878
Misses 5407 5407
Partials 201 201 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #N/A (improving our test coverage)
Create basic unit tests for the
normalizeForInterpreter.py.Has a news entry file (remember to thank yourself!)Has sufficient logging.Has telemetry for enhancements.Test plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)The wiki is updated with any design decisions/details.