Skip to content

Azure DevOps Nightly CI fixes#4761

Merged
d3r3kk merged 4 commits intomicrosoft:masterfrom
d3r3kk:4336_azdo_ci_fixes
Mar 14, 2019
Merged

Azure DevOps Nightly CI fixes#4761
d3r3kk merged 4 commits intomicrosoft:masterfrom
d3r3kk:4336_azdo_ci_fixes

Conversation

@d3r3kk
Copy link
Copy Markdown

@d3r3kk d3r3kk commented Mar 14, 2019

For #4336

This PR cleans up our nightly build. Some issues remains as there is not a reliable fix yet (#4760).

  • skip flaky tests
  • remove mocha-vsts-reporter from use
  • update build badges to point to new AzDO

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

d3r3kk added 2 commits March 14, 2019 06:46
For microsoft#4336

This PR cleans up our nightly build. Some issues remains as there is not a reliable fix yet (microsoft#4760).

- skip flaky tests
- remove mocha-vsts-reporter from use
- update build badges to point to new AzDO
@d3r3kk d3r3kk changed the title 4336 azdo ci fixes Azure DevOps Nightly CI fixes Mar 14, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2019

Codecov Report

Merging #4761 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4761    +/-   ##
=======================================
- Coverage      77%     77%   -<1%     
=======================================
  Files         449     449            
  Lines       21650   21650            
  Branches     3552    3552            
=======================================
- Hits        16617   16606    -11     
- Misses       5029    5040    +11     
  Partials        4       4
Flag Coverage Δ
#Linux 66% <ø> (ø) ⬇️
#Windows 66% <ø> (ø) ⬇️
#macOS 65% <ø> (ø) ⬇️

Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3r3kk d3r3kk merged commit 6e746c6 into microsoft:master Mar 14, 2019
@d3r3kk d3r3kk deleted the 4336_azdo_ci_fixes branch March 14, 2019 18:00
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants