run modules plain if running as jupyter modules doesn't work#4763
Merged
IanMatthewHuff merged 1 commit intomicrosoft:masterfrom Mar 14, 2019
Merged
Conversation
IanMatthewHuff
commented
Mar 14, 2019
| } | ||
|
|
||
| private doesModuleExist = async (module: string, interpreter: PythonInterpreter, cancelToken?: CancellationToken): Promise<boolean> => { | ||
| private doesModuleExist = async (moduleName: string, interpreter: PythonInterpreter, cancelToken?: CancellationToken): Promise<ModuleExistsResult> => { |
Member
Author
There was a problem hiding this comment.
just swapped moduleName as module shows up as keyword coloring.
rchiodo
reviewed
Mar 14, 2019
| // Our command args are different based on the command. ipykernel is not a jupyter command | ||
| const args = command === JupyterCommands.KernelCreateCommand ? ['-m', command] : ['-m', 'jupyter', command]; | ||
| return this.commandFactory.createInterpreterCommand(args, interpreter); | ||
| if (exists === ModuleExistsResult.FoundJupyter) { |
There was a problem hiding this comment.
=== [](start = 23, length = 3)
Nice. This is way simpler than I thought it was going to be.
Codecov Report
@@ Coverage Diff @@
## master #4763 +/- ##
======================================
+ Coverage 77% 77% +1%
======================================
Files 449 449
Lines 21650 21708 +58
Branches 3552 3572 +20
======================================
+ Hits 16608 16668 +60
+ Misses 5038 5036 -2
Partials 4 4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #4306
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)