fix(web): let the PR reviewer and label search boxes take keystrokes

[juliusmarminge]

The reviewer and label pickers on the PR summary were built on a Base UI `Menu`, whose typeahead claims every printable key to jump between rows. Typing into the search box never reached the input: pressing `t` highlighted `t3dotgg` instead of filtering.

The shared picker shell now sits on the same `Combobox` wrapper the sidebar project picker and the branch picker use, with the same search-box treatment, so the three read as one control. The input owns typing, arrow keys and Enter still walk and pick rows, the popover stays open after a pick so a second reviewer or label can follow, and the loading, error, empty, and truncated states are unchanged. Both the reviewer picker and the label picker share this shell, so one change fixes both.

Before (pressed `t`, `3`)	After (opened)	After (pressed `t`, `3`)

Verified in a local dev environment against a real PR: the input takes focus on open, typing filters the list, backspacing widens it again, and the labels picker filters the same way.

Made with Claude Fable 5.1 in Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
Localized UI primitive swap in a shared picker shell with no auth or data-layer changes; main risk is combobox keyboard/focus edge cases in reviewer and label pickers.

Overview
Replaces the shared PR reviewer/label picker shell (PullRequestCandidatePicker) from a Menu + plain Input to the same Combobox stack used by the project and branch pickers, with a search-icon input styling that matches those controls.

Search now works: menu typeahead no longer steals printable keys, so filtering goes through the caller-controlled query while arrow keys/Enter still navigate rows. The combobox is configured with filter={null} and caller-supplied filteredItems so filtering behavior stays unchanged.

Selection UX: picking a row still calls onSelect, but closes from item-press are cancelled so the popover stays open (and focus/query behavior stays in the search box) for adding multiple reviewers or labels. Loading, error, empty, and truncated messaging are unchanged.

^{Reviewed by Cursor Bugbot for commit 12fc9a9. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix PR reviewer and label search boxes to accept keystrokes

Replaces the menu-based picker in PullRequestCandidatePicker with shared combobox primitives so the search input receives keyboard focus and typing. Candidate filtering stays with the caller; combobox-owned filtering is disabled. Selecting a candidate no longer closes the picker, while other open-state changes still propagate through onOpenChange.

^{Macroscope summarized 12fc9a9.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.5 KiB	−72 B (−0.5%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−3 B (−0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.6 KiB	6.5 KiB	−69 B (−1.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	57.0 KiB	−88 B (−0.2%)	66.4 KiB	✅
Codex	Live turn messages	10	8	−2 (−20.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.8 KiB	+186 B (+1.3%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	0 B (0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.7 KiB	+186 B (+2.8%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	59.3 KiB	+1.5 KiB (+2.5%)	66.4 KiB	✅
Claude	Live turn messages	9	10	+1 (+11.1%)	21	✅

Baseline: d2b6f3b · PR result: 12fc9a9 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at 12fc9a9

Macroscope's review found this PR approvable — This is a localized UI bug fix that switches the existing PR reviewer and label picker to the established Combobox primitive, allowing search keystrokes while preserving their existing data and selection flows. No schema, infrastructure, security, billing, default, or static-analysis configuration is changed.

^{You can add or adjust custom eligibility rules. Learn more.}

[macroscopeapp]

Composable components: this search header is a byte-for-byte copy of the same block in Sidebar.tsx (project picker), BranchToolbarBranchSelector.tsx, and settings/FontFamilyPicker.tsx — same wrapper classes, same absolutely positioned SearchIcon, and the same unstyled + [&_input]:… / inputClassName overrides of the input's height, radius, padding, and background. That treatment belongs in apps/web/src/components/ui/combobox.tsx as a slot (e.g. ComboboxSearchHeader, or a search variant of ComboboxInput using its existing startAddon prop) rather than a fourth copy at this call site.

^{Posted via Macroscope — UI Consistency}

[juliusmarminge]

Agreed the search header is repeated; it's copied on purpose here so this picker matches the project and branch pickers exactly. Lifting all four into a ComboboxSearchHeader slot is a separate refactor across unrelated call sites, so keeping it out of this bug fix.

[macroscopeapp]

Fair point; this can remain scoped to the bug fix. Would you like me to prepare the shared extraction as a separate PR against main?

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit eb4f6e8. Configure here.}