Skip to content

fix(server): full-access OpenCode threads no longer ask for approvals - #9282

Merged
juliusmarminge merged 9 commits into
pingdotgg:mainfrom
shivamhwp:t3code/check-opencode-full-access-approvals
Sep 3, 2026
Merged

fix(server): full-access OpenCode threads no longer ask for approvals#9282
juliusmarminge merged 9 commits into
pingdotgg:mainfrom
shivamhwp:t3code/check-opencode-full-access-approvals

Conversation

@shivamhwp

@shivamhwp shivamhwp commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

A user reported that OpenCode threads set to full access still pop approval dialogs. I reproduced it live against OpenCode 1.18.26 with a ChatGPT subscription. Ordinary tool calls are fine, but two paths in OpenCode ignore the session-level allow we send:

  • Doom loop. When the model repeats the same tool call three times, OpenCode evaluates the ask against the agent ruleset only, so our wildcard allow is never consulted. This showed up in the UI as an "unknown" approval.
  • Subagents. Child sessions spawned by the task tool keep only deny and external-directory rules from the parent, so a subagent reading *.env or hitting any agent default prompts. Since fix(opencode): handle child approvals, stops, and model catalogs #8480 routes child asks to the thread, this also shows a dialog.

Both are upstream OpenCode behavior, and full access means the user already said yes. The adapter now answers any permission ask that arrives while the session is in full access, and swallows the matching replied event so nothing reaches the UI. If the reply call fails, it falls back to showing the approval as before. Other modes are untouched.

The reply is "once", not "always". OpenCode stores "always" grants per directory, so on a shared external server an "always" from a full-access thread would widen what a supervised thread on the same directory is allowed to do.

Product note. Auto-answering the doom-loop ask means a full-access thread can repeat the same tool call without a guard. That matches what the docs promise for full access ("runs unattended") and what Codex and Claude do today, so it is intentional.

Tests cover the doom-loop ask on the parent session, a child-session ask, the failed-reply fallback, and a failed reply whose terminal event landed while the reply was in flight. The final ordering change (no yield between the terminal check and the publish) is a scheduler-interleaving race that the mock cannot reproduce deterministically, so it has no dedicated test.

Work done by Claude Fable 5.1 via Claude Code.

🤖 Generated with Claude Code


Note

Medium Risk
Changes permission handling and event emission for full-access OpenCode sessions; incorrect suppression or fallback could hide needed approvals or leave stuck dialogs, though other runtime modes are unchanged and tests cover key races.

Overview
Full-access OpenCode threads no longer surface approval dialogs for permission asks that upstream ignores the session ruleset on—doom-loop detection and subagent sessions. The adapter calls permission.reply with once (not always, to avoid widening grants for other threads on a shared directory), tracks auto-replied IDs, and suppresses matching request.opened / request.resolved UI events. If the SDK reply fails, behavior falls back to showing the approval dialog; failed in-flight replies after a terminal event must not reopen the request.

Implementation adds autoReplyFullAccess, autoRepliedRequestIds, and emitUnsafe so request.opened is not published after a terminal permission.replied lands between an async check and enqueue. Tests extend the mock with a configurable permission-reply hook and cover auto-approve (parent doom-loop + child session), reply failure fallback, and terminal/reply ordering. Docs note why full-access auto-answers these asks and why replies use once.

Reviewed by Cursor Bugbot for commit 4d250db. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix full-access OpenCode threads to auto-approve permissions without dialogs

  • Full-access sessions now automatically reply once to permission asks (doom-loop and subagent) instead of surfacing an approval dialog, using a one-time grant rather than a persistent directory-scoped grant
  • A synchronous enqueue helper (emitUnsafe) prevents an async gap between the terminal-event check and publishing request.opened, eliminating a race where a terminal reply arrives during event construction
  • Failed auto-replies remove the auto-reply marker but keep a resolved marker so the request falls through to the dialog without reopening from recovered duplicate asks; terminal events for successful auto-replies are swallowed (no request.resolved)
  • Behavioral Change: emitTerminalOpenCodeRequest now suppresses terminal events for request IDs in the auto-reply set; reviewers should verify that no request.resolved or request.opened is emitted for successfully auto-replied asks in OpenCodeAdapter.ts
  • Documents full-access adapter behavior in providers.md

Macroscope summarized 4d250db.

OpenCode ignores the session ruleset for doom-loop checks and drops the
parent's wildcard allow when it spawns subagent sessions, so full-access
threads still surfaced approval dialogs for those asks. Auto-reply
"always" to any permission ask while the session is in full access and
swallow the matching replied event, falling back to the dialog if the
reply call fails.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 2, 2026
Comment thread apps/server/src/provider/Layers/OpenCodeAdapter.ts Outdated
@macroscopeapp

macroscopeapp Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The server now automatically grants and suppresses OpenCode permission requests in full-access sessions, including requests that bypass upstream rules and the doom-loop safeguard. This is a localized, tested change, but it materially alters production authorization behavior and its side effects warrant human review.

You can add or adjust custom eligibility rules. Learn more.

A retry or recovery fiber could re-enter the pending-request path, or the
matching permission.replied could land, while the auto-reply SDK call was
still in flight. That raced to emit a duplicate request.opened or a stray
request.resolved. Record the resolved and auto-replied ids synchronously
before awaiting, and roll them back if the reply fails.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Sep 2, 2026
Comment thread apps/server/src/provider/Layers/OpenCodeAdapter.ts Outdated
Comment thread apps/server/src/provider/Layers/OpenCodeAdapter.ts Outdated
shivamhwp and others added 3 commits September 2, 2026 23:25
… resolved

If the auto-reply SDK call fails locally but OpenCode still resolved the
permission, the terminal permission.replied lands and is swallowed while the
reply is in flight, consuming the terminal slot. The failure path then rolled
back and opened a dialog that could never resolve. Guard the fallback: if the
terminal event already landed, keep the request resolved and do not reopen it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Guard against a regression where the fallback retries the reply instead of
surfacing the dialog.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ace0116. Configure here.

Comment thread apps/server/src/provider/Layers/OpenCodeAdapter.ts
shivamhwp and others added 2 commits September 3, 2026 04:57
…its terminal check

On a retry or recovery fiber, the event pump can deliver the terminal
permission.replied between the emittedTerminalRequestIds check and the
request.opened offer, so request.resolved lands first and the fallback
dialog can never close. Build the event first, then check and offer in one
synchronous step. The failed auto-reply also keeps the id in
resolvedRequestIds: pendingPermissions already gates re-asks while the
dialog is open.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…o-reply path

OpenCode stores "always" grants per directory, not per session. On a shared
external server an "always" from a full-access thread would silently widen
what a supervised thread on the same directory is allowed to do, so reply
"once" instead. Every ask in full access is auto-answered anyway.

Also extract the full-access branch into autoReplyFullAccess so the id
bookkeeping has a name and a boundary, add an emitUnsafe sibling next to
emit for the one publish that must not yield after its terminal check,
collapse the two identical auto-approve tests into one parameterized case,
and note the upstream ruleset quirk in the provider internals doc.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@shivamhwp

Copy link
Copy Markdown
Collaborator Author

Addressed the review in 605dcff.

  1. Reply is now "once". Confirmed against upstream Permission.reply: it returns before touching the per-directory approved list on "once" and appends to it on "always".
  2. Full-access branch extracted into autoReplyFullAccess returning replied | fallback | already-terminal. Added emitUnsafe next to emit with the one-line reason. Comments trimmed to the why.
  3. Tests 1 and 2 collapsed into one it.effect.each case. Sentinel is commented. The blind yieldNow pair in test 4 is replaced with a single microtask drain. PR body now says the final ordering change has no dedicated test.
  4. One line added to docs/internals/providers.md on the upstream ruleset quirk.

PR body rewritten: bot summary blocks removed, doom-loop product decision stated explicitly.

shivamhwp and others added 2 commits September 3, 2026 13:26
…back

autoReplyFullAccess returned a tri-state whose "already-terminal" branch
duplicated the emittedTerminalRequestIds check the caller performs right
before publishing. Only the publish-site check is load-bearing, since it
must sit next to the enqueue with no yield in between, so the helper now
returns whether the reply landed and the caller keeps the one guard.

Also moves the internals note out of "Attachment access", where it was
tacked onto a paragraph about attachment directories, into the OpenCode
section beside the existing per-directory MCP note, and records the
"once" rationale there.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 20:37
@juliusmarminge
juliusmarminge merged commit d2b6f3b into pingdotgg:main Sep 3, 2026
25 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 4, 2026
## What's Changed
* fix(web): make right panel tabs easier to scroll by @maria-rcks in pingdotgg/t3code#9461
* fix(web): render transparent previews on white by @UtkarshUsername in pingdotgg/t3code#9463
* fix(mobile): show loading and syncing in the working pill by @juliusmarminge in pingdotgg/t3code#9466
* fix(server): keep a/ and b/ prefixes in rendered git patches by @Mnigos in pingdotgg/t3code#9438
* fix(server): full-access OpenCode threads no longer ask for approvals by @shivamhwp in pingdotgg/t3code#9282
* fix(web): reuse pull request list data while loading by @maria-rcks in pingdotgg/t3code#9467
* feat(web): let users turn off composer collapse on blur and scroll by @juliusmarminge in pingdotgg/t3code#9469

## New Contributors
* @Mnigos made their first contribution in pingdotgg/t3code#9438

**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1272...v0.0.39-nightly.20260903.1273

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1273
sheehanmunim added a commit to munimtechnologies/mtcode that referenced this pull request Sep 4, 2026
…ity ACP, browser import, settings reorg, limits tab)

Brings the fork up to upstream/main fee2e0f. Highlights: Google Antigravity
via the official ACP agent (pingdotgg#9348) + model manifest refreshes, browser-cookie
import (Chrome/Edge/Brave/Firefox, pingdotgg#7255/pingdotgg#7260/pingdotgg#7261), settings page reorg
(pingdotgg#9354), Codex/Claude subscription Limits tab (pingdotgg#9507, pingdotgg#9534), context
compaction command (pingdotgg#9293), async Codex questions (pingdotgg#9512), full-access
OpenCode threads skip approvals (pingdotgg#9282), project icons default (pingdotgg#9457).

Unification decisions (keep-both unless noted):
- BrowserImport: upstream implementation wins (Linux libsecret, Windows DPAPI
  unwrap, writeCookies); fork's Safari engine ported in (jar definition,
  candidate path, profile listing, running check, count skip, import branch,
  FullDiskAccess wizard step + SafariCookies kept, domain widened only for
  dotted hosts).
- Antigravity: upstream ACP provider/adapter/driver/textgen win; fork branding
  ported (providerDisabledMessage), AntigravitySettings unified (fork fields +
  upstream auth fields; enabled stays default-on).
- contracts/model: Antigravity defaults follow upstream's manifest model.
- ClaudeAdapter compact_boundary: fork's resolve helper kept, renamed to
  upstream's compactedUsage to match downstream.
- Claude capabilities probe: fork's timeout races kept; upstream's raw usage
  fetch added under the same timeout so stalled usage still degrades.
- Codex provider: upstream's withCodexAppServerClient + enriched rate-limits
  probe win (fork title branding already inside buildCodexInitializeParams).
- ProviderCommandReactor: fork goal-continuation + correction-aware first-turn
  kept; upstream compact-command exclusion added.
- OpenCodeAdapter ask path: fork's pendingGate/acceptingRequests gate kept;
  upstream full-access autoReply + terminal guard + emitUnsafe added.
- makeManagedServerProvider: fork probe-timeout protection kept; upstream
  usage-limits reconciliation applied to the checked snapshot.
- Manager.ts preview CDP: fork reuse-if-attached + detach resilience kept;
  upstream wcDebugger hardening applied.
- mobile threadSyncPhase pill dropped (upstream ThreadDetail redesign covers
  loading/sync presentation); outbox deliveryMode + goal handling kept.
- Usage: fork client-version projection kept; upstream pricing()/refreshRates
  adopted on both clients.
- Settings: fork sections (MT Teams+badge, voice, notifications, account
  sign-in) kept; upstream reorg (ids, submenus, behaviour section) adopted.
- README: fork copy kept; Antigravity added to provider lists.
- Cursor skill test macOS /var-vs-/private/var path failure is pre-existing
  upstream breakage, unrelated to this merge.

Fork guard script OK.
henrychu04 added a commit to henrychu04/t3code-coder that referenced this pull request Sep 5, 2026
* fix(web): send cited messages with Cmd+Enter (pingdotgg#9307)

* fix(web): preserve explicit preview navigation URLs (pingdotgg#8902)

* fix(web): prevent loading ssh environments from overriding navigation (pingdotgg#9168)

* fix(mobile): skip unsupported shared settings targets (pingdotgg#9381)

* fix(web): avoid duplicate Antigravity install status (pingdotgg#9419)

* fix(composer): mute fast icon when collapsed (pingdotgg#9451)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): unify skeleton loading animations on one pulse (pingdotgg#9448)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): prioritize authored pull requests (pingdotgg#9453)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): make project icons the default (pingdotgg#9457)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(server): reuse pr state when settling threads (pingdotgg#9459)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): keep agent images collapsed (pingdotgg#9460)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): banner buttons no longer expand the resting composer (pingdotgg#9452)

* fix(web): stop clipping the traits chevron on long Codex effort labels (pingdotgg#9433)

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(web): make right panel tabs easier to scroll (pingdotgg#9461)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): render transparent previews on white (pingdotgg#9463)

* fix(mobile): show loading and syncing in the working pill (pingdotgg#9466)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(server): keep a/ and b/ prefixes in rendered git patches (pingdotgg#9438)

* fix(server): full-access OpenCode threads no longer ask for approvals (pingdotgg#9282)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>

* fix(web): reuse pull request list data while loading (pingdotgg#9467)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* feat(web): let users turn off composer collapse on blur and scroll (pingdotgg#9469)

Co-authored-by: Claude Code <noreply@anthropic.com>

* fix(web): move workflow approval beside checks (pingdotgg#9465)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(desktop): refresh generated annotation styles (pingdotgg#9488)

* fix(web): let the PR reviewer and label search boxes take keystrokes (pingdotgg#9479)

Co-authored-by: Claude Code <noreply@anthropic.com>

* fix(web): dont collapse composer when interacting with bottom row (pingdotgg#9490)

* fix(desktop): restore second-press quit fallback (pingdotgg#9485)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): keep opencode icon hollow in collapsed composer (pingdotgg#9492)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): keep agent browser preview visible (pingdotgg#9484)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(mobile): keep the machine glyph next to the environment label (pingdotgg#9486)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(mobile): let back swipe pop from horizontal scroll edges (pingdotgg#9493)

Co-authored-by: Claude Code <noreply@anthropic.com>

* fix(antigravity): discover legacy workspace skills (pingdotgg#9410)

Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>

* fix(mobile): resolve Antigravity provider icon and normalize driver matching (pingdotgg#9495)

* fix(antigravity): forward Google sign-in URLs from browser helper (pingdotgg#9425)

* feat(desktop): import browser cookies into a profile (pingdotgg#7255)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(desktop): import from Chrome, Edge, Brave, Vivaldi, Opera, Arc and Firefox (pingdotgg#7260)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

* feat(desktop): resolve Chromium cookie keys on Linux (pingdotgg#7261)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(antigravity): allow slow runtime startup during setup (pingdotgg#9510)

* fix(antigravity): keep model choices up to date (pingdotgg#9511)

* fix(antigravity): handle native sign-in URLs on stderr (pingdotgg#9514)

* fix(antigravity): update managed runtime to 1.1.1 (pingdotgg#9509)

* fix(desktop): address the browser import review left over from the stack (pingdotgg#9516)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>

* feat(antigravity): show subagent calls and results (pingdotgg#9515)

* fix(web): let paste expand a resting composer (pingdotgg#9498)

Co-authored-by: Claude Code <noreply@anthropic.com>

* fix(web): keep the composer open while selecting timeline text (pingdotgg#9499)

Co-authored-by: Claude Code <noreply@anthropic.com>

* fix(web): return focus to the composer after closing a media preview (pingdotgg#9513)

Co-authored-by: Claude Code <noreply@anthropic.com>

* fix(server): keep events during thread subscription startup (pingdotgg#9521)

* chore: forward issue/PR/discussion events to Cursor hygiene (pingdotgg#9518)

Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com>

* fix(auth): keep pairing credentials out of access read models (pingdotgg#9523)

* chore: drop comment events from Cursor hygiene forwarder (pingdotgg#9527)

* feat(codex): support async questions (pingdotgg#9512)

* fix(web): keep right panel controls clickable (pingdotgg#9517)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* feat(usage): show Codex and Claude subscription limits on a Limits tab (pingdotgg#9507)

Users on Codex or Claude Code subscriptions could not see how much quota was left or when it resets without leaving T3 Code. A user whose CLIs route through a CLIProxyAPI hub could not see it at all.

Each driver now returns `usageLimits` on its own snapshot (Codex from `account/rateLimits/read`, Claude from the SDK's `get_usage`), adapters normalise turn-driven rate-limit events at the boundary, and a driver-blind ingestion layer folds them onto the owning instance. The Usage page gains a Limits tab (mobile a card) with a bar per window, elapsed marker, pace, and reset countdown. CLIProxyAPI hubs can be added as read-only usage-limit sources; their accounts show badged "via CLIProxyAPI" with emails blurred.

Distilled from pingdotgg#1732 (server model, provider rows) and pingdotgg#9421 (Limits tab, window bars, pace maths). Closes pingdotgg#228.

Co-authored-by: Aditya Mer <101453576+Aditya190803@users.noreply.github.com>
Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com>
Co-authored-by: Claude Code <noreply@anthropic.com>

* feat(web): reorganize settings pages (pingdotgg#9354)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(server): settle branch threads immediately on pull request merge (pingdotgg#9528)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(server): back off relay client restarts after rapid exits (pingdotgg#8788)

* fix(codex): accept rate limit errors on thread resume (pingdotgg#8897)

* fix(desktop): preview CDP sessions no longer hard-crash the app (pingdotgg#9068)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* Fix worktree removal timing out on large install trees (pingdotgg#3902)

* fix(web): settle the resting composer layout with a pixel of slack (pingdotgg#9482)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(web): keep automatic project icons consistent (pingdotgg#9535)

* fix(server): include SQLite conditions in persistence errors

Include SQLite conditions and schema issue tags without copying query data.

Continue @Sy-D's [pingdotgg#4837](pingdotgg#4837). Add the missing Bun error codes and test the real SQL client.

Created with GPT-6 Astra (preview) in Codex.

Co-authored-by: Sy-D <8460326+Sy-D@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

* fix(dev): keep shared dev reloads and hot updates working (pingdotgg#9543)

* feat(providers): add context compaction command (pingdotgg#9293)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(mobile): keep store screenshots free of system banners and show dictation (pingdotgg#9548)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(web): restore composer controls as space becomes available (pingdotgg#9539)

* fix(web): measure collapsed model labels at their visible width (pingdotgg#9540)

* fix(web): close composer menus when their controls hide (pingdotgg#9541)

* fix(web): thread error banner no longer shifts the chat (pingdotgg#9473)

* fix(server): reveal normalized paths in File Explorer (pingdotgg#9551)

* feat(marketing): fresh screenshot and floating marks on the homepage (pingdotgg#9547)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

* feat(usage): redeem Codex reset credits from the Limits tab (pingdotgg#9534)

Follow-up to pingdotgg#9507, carrying over the reset-credit redemption from pingdotgg#9421.

Codex grants a reset credit when it has rate-limited an account unfairly (`"Thanks for using Codex! You've been granted one free rate limit reset."`). Redeeming one clears the current 5h/weekly windows. The Limits tab now shows how many are banked and when the next expires, with a confirmed **Use a reset credit** action.

## How it works

- `ServerProviderUsageLimits.resetCredits` carries the count and soonest expiry; the Codex probe reads it from the same `account/rateLimits/read` it already makes.
- `ProviderInstance.consumeResetCredit` is a new optional hook — account-level, so it sits beside `refreshModels` rather than on the thread-routed adapter. The Codex driver implements it over a short-lived app-server (via `withCodexAppServerClient`, factored out of the status and skills probes which duplicated the setup), then re-probes.
- Single-flight per instance with one idempotency key kept until Codex reports an outcome, so a retry after a timeout does not open a second attempt.
- New `provider.consumeResetCredit` RPC under the operate scope; the outcome (`reset` / `nothingToReset` / `noCredit` / `alreadyRedeemed`) is shown inline.

Only Codex reports credits today. A provider without the hook gets a clear "does not bank reset credits" error; one without credits shows nothing.

## Screenshots

The local Codex row with one banked credit (the same account via the CLIProxyAPI hub above it shows no credit, as expected — the hub does not relay them):

![Limits tab with the Codex row showing "1 reset credit banked · next expires in 16d 22h" and a "Use a reset credit" button](https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/2897db5e357f12b3/credits-tab.png)

Close-up of the row:

![Codex row: Weekly 25% used bar, then "1 reset credit banked · next expires in 16d 22h" with the "Use a reset credit" button](https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/0e80f9114cab8f36/credits-row.png)

Clicking it opens the confirmation; nothing is sent until **Use credit**:

![Confirm dialog: "Use a reset credit? This redeems one credit on your account and clears the current rate-limit windows. It cannot be undone." with Cancel and Use credit](https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/dc728580889ef1fe/credits-confirm.png)

## Verification

- Mapper tests for the credit summary; provider, contract, and Usage page suites pass; typecheck clean.
- Verified against a real Codex Pro account holding one credit: summary and expiry render, the confirm dialog opens. **Not redeemed** — that would spend the credit.

Written by Claude Fable 5 via Claude Code; design and single-flight approach from @StiensWout's pingdotgg#9421.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Redemption spends real account credits over a new RPC; correctness depends on per-account locking and idempotency, though disabled instances and non-Codex providers are rejected explicitly.
> 
> **Overview**
> Adds **end-to-end redemption of banked Codex rate-limit reset credits** from the Limits UI on web and mobile, backed by a new operate-scoped `provider.consumeResetCredit` RPC.
> 
> **Contracts and server:** `ServerProviderUsageLimits` can include `resetCredits` (count + next expiry). Codex probes attach that from `account/rateLimits/read`. Optional `ProviderInstance.consumeResetCredit` is implemented for Codex via a scoped app-server call to `account/rateLimitResetCredit/consume`, then a limits refresh. `CodexResetCreditCoordinator` serializes redemptions per Codex account directory, reuses one idempotency key until Codex returns an outcome, and times out hung requests. `withCodexAppServerClient` is extracted so status, skills, and redemption share the same short-lived app-server setup.
> 
> **Clients:** Limits rows show banked credits and a confirmed **Use a reset credit** action that calls `serverEnvironment.consumeResetCredit` and surfaces outcomes (`reset`, `nothingToReset`, etc.) or errors.
> 
> **Web usage sources (same PR):** Adding/removing CLIProxyAPI hubs and the add dialog target a **selected connected environment** (with picker when several are connected), gated by operate access—not only the primary environment.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 98f32e6. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->


Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com>
Co-authored-by: Claude Code <noreply@anthropic.com>

* fix(server): find newly opened pull requests after agent turns (pingdotgg#9125)

Refresh missing PR associations after agent turns on the thread's current branch. Preserve background policy, known PR caches, and failed-lookup backoff. Serialize status loads and refreshes to prevent stale responses from hiding a PR. Find branches pushed under their own name while still tracking the default branch.

Original work by Theo Browne with Claude Fable 5.1 in Claude Code. Takeover fixes created with GPT-6 Astra (preview) in Codex.

Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

* ci: add on-demand Windows test workflow (pingdotgg#9538)

Co-authored-by: Claude Code <noreply@anthropic.com>

* fix(web): simplify expanded tool details (pingdotgg#9549)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): keep the last message visible when the resting composer expands (pingdotgg#9553)

Scrolling a long thread to the end with the composer at rest landed flush
against the short composer. The expansion that followed then covered the
last rows, because the timeline reserves only the live overlay height and
does not move for footer growth.

The timeline now keeps the expanded composer's height clear while the
composer rests, so expanding it again changes nothing above the composer.
The composer reports its resting flag from a layout effect and publishes a
fresh overlay height whenever that flag changes, so the reservation is
always computed from a height that belongs to the same layout.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* test(web): fix flaky startup and Tailwind tests (pingdotgg#9558)

* fix(web): keep codex restart responses continuous (pingdotgg#9560)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): make settings sidebar sub-section buttons full width (pingdotgg#9562)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(web): render settings sidebar immediately (pingdotgg#9563)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* chore: vouch august contributors (pingdotgg#9557)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): stabilize right panel transitions (pingdotgg#9554)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix: better shell syntax handling for labels (pingdotgg#9371)

* fix(web): align the sidebar wordmark by baseline (pingdotgg#9578)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(antigravity): keep subagent batches active after launch (pingdotgg#9579)

* fix(mobile): render workspace images in markdown file previews (pingdotgg#8769)

* fix(usage): deduplicate CLI proxy subscription accounts (pingdotgg#9584)

* fix(web): bound disconnected send toasts (pingdotgg#9592)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(desktop): restore panel titlebar interactions (pingdotgg#9591)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(connect): refresh authorization without disconnecting (pingdotgg#9582)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): show context meter in compact composer (pingdotgg#9430)

* fix(pull-requests): refresh data after thread turns (pingdotgg#9496)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web): render draft PRs in gray (pingdotgg#9537)

* refactor(web): move usage provider controls to settings (pingdotgg#9599)

* fix: show idle subagent batches without completion marks (pingdotgg#9616)

* fix(web): group image views like other tool calls (pingdotgg#9597)

Co-authored-by: Claude Code <noreply@anthropic.com>

* fix: preserve tool icons on failed calls (pingdotgg#9606)

* fix(connect): diagnose incomplete headless server setup (pingdotgg#9602)

* fix(web): keep command palette above composer menus (pingdotgg#9613)

* fix(web): snooze menu no longer overlaps thread details (pingdotgg#9601)

* fix(web): match composer pull request state icons (pingdotgg#9375)

* fix(server): load OpenCode workspace skills via SDK to avoid 64KB CLI pipe truncation (pingdotgg#9585)

* fix(web): mute sidebar branch name to match worktree icon (pingdotgg#9622)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* fix(web,mobile): fold context compaction under settled turn folds (pingdotgg#9623)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* feat(mobile): make chat text selectable on Android (pingdotgg#8779)

Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>

* fix(web): toggle a single stashed prompt with Cmd+S (pingdotgg#9644)

Cmd+S opened the stash menu even when the composer was empty and only one prompt was stashed. It now restores that prompt directly, so repeated presses toggle between the draft and stash.

Multiple entries and images that are still saving open the menu. The stash badge still opens the menu.

Validation: 94 focused stash, shortcut, and attachment tests pass. Web typecheck and formatting pass. Targeted lint has no new warnings or errors. Browser checks were skipped at Theo's request.

Original implementation by Theo Browne. No code changes were needed during the takeover audit.

Audited with GPT-6 Astra (preview) in Codex.

* fix(server): prevent duplicate desktop clients after restart

Replace stale local desktop sessions in one transaction. Preserve paired clients and browser sessions, and keep the previous credential valid if replacement fails.

Closes pingdotgg#6283.

Original implementation by seeb1337. Reviewed and verified with GPT-6 Astra (preview) in Codex.

Co-authored-by: seeb1337 <63622047+seeb1337@users.noreply.github.com>
Co-authored-by: Theo Browne <me@t3.gg>

* fix(web): resume Antigravity threads without repeated sign-in (pingdotgg#9647)

Allow Antigravity threads to resume while saved Google sign-in is unchecked after a server restart. Keep confirmed authentication failures and installation errors visible.

Validated with 136 focused tests, web typecheck, targeted lint, and CI. Browser verification was omitted at the maintainer's request.

Created with GPT-6 Astra (preview) in Codex.

* feat(mobile): paste the phone clipboard into the terminal (pingdotgg#9199)

Co-authored-by: Jake Leventhal <jakeleventhal@me.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>

* feat(web): show which sidebar threads hold an unsent draft (pingdotgg#9658)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

* fix(server): unblock OpenCode approvals and stop (pingdotgg#9653)

OpenCode could show an Approval badge with no controls, appear stuck on TodoWrite, and keep showing a running turn after Stop.

- Show every permission, including old saved requests. Keep failed replies retryable and close completed requests even when reply events are lost.
- Keep OpenCode output pipes drained and automatic replies out of the event loop. Handle disconnects, reconnects, and confirmed stops without stale requests or running states.
- Show native task progress and command results. Do not treat TodoWrite or approval history as file edits or executed commands.
- Ignore late aborts and task updates after a turn finishes.

Fixes pingdotgg#4795
Fixes pingdotgg#7113
Fixes pingdotgg#5760

Created with GPT-6 Astra (preview) in Codex. Reviewed and merged with Claude Fable 5.1 in Claude Code.

* fix(desktop): quit immediately on a second shortcut press (pingdotgg#9657)

* fix(server): update Claude Agent SDK to 0.3.260 (pingdotgg#9135)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

* perf(server): stop loading message bodies for thread summaries (pingdotgg#9662)

* perf(web): speed up terminal snapshots (pingdotgg#9663)

* Complete upstream sync adaptations and validate Claude authentication

* Fix reviewed Coder sync regressions and add focused coverage

* Include orchestration regression suites in Coder tests

---------

Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
Co-authored-by: Yukun Shan <92423096+nateEc@users.noreply.github.com>
Co-authored-by: oliver <97427849+flamboh@users.noreply.github.com>
Co-authored-by: Simone <lucenz@proton.me>
Co-authored-by: Rakshith Bhat <88523594+RakshithBhat03@users.noreply.github.com>
Co-authored-by: maria <maria@kuuro.net>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Zortos <zortosdev@proton.me>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Igor Makowski <56691628+Mnigos@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Invictine <72551038+Invictine@users.noreply.github.com>
Co-authored-by: WellyngtonF <59291417+WellyngtonF@users.noreply.github.com>
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com>
Co-authored-by: Aditya Mer <101453576+Aditya190803@users.noreply.github.com>
Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com>
Co-authored-by: Derek Trimm <275381468+derektrimm@users.noreply.github.com>
Co-authored-by: Seth Webster <sethwebster@gmail.com>
Co-authored-by: Jake Leventhal <jakeleventhal@me.com>
Co-authored-by: Matheus Timbó Pereira <matheusfild4@hotmail.com>
Co-authored-by: Sy-D <8460326+Sy-D@users.noreply.github.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
Co-authored-by: Dara Adedeji <76637177+SunkenInTime@users.noreply.github.com>
Co-authored-by: Guilherme Vieira <46866023+GuilhermeVieiraDev@users.noreply.github.com>
Co-authored-by: Guillermo Casanova <75276669+Gigioxx@users.noreply.github.com>
Co-authored-by: Barry <43803274+BarryHenryJr@users.noreply.github.com>
Co-authored-by: seeb1337 <63622047+seeb1337@users.noreply.github.com>
Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants