fix(web): thread error banner no longer shifts the chat - #9473
Merged
maria-rcks merged 1 commit intoSep 4, 2026
Conversation
The thread error banner rendered in normal flow between the workspace header and the timeline, so showing or dismissing it moved the whole chat column by the banner height. It now lives in the same absolutely positioned overlay as the provider status banner and uses the glass surface, so the timeline keeps its height.
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This narrowly scoped UI fix moves the existing thread error banner into the established overlay pattern so it no longer changes the chat timeline’s layout. Its runtime effects are limited to positioning, stacking, pointer handling, and existing styling, with no schema, configuration, or sensitive-area changes. You can add or adjust custom eligibility rules. Learn more. |
henrychu04
added a commit
to henrychu04/t3code-coder
that referenced
this pull request
Sep 5, 2026
* fix(web): send cited messages with Cmd+Enter (pingdotgg#9307) * fix(web): preserve explicit preview navigation URLs (pingdotgg#8902) * fix(web): prevent loading ssh environments from overriding navigation (pingdotgg#9168) * fix(mobile): skip unsupported shared settings targets (pingdotgg#9381) * fix(web): avoid duplicate Antigravity install status (pingdotgg#9419) * fix(composer): mute fast icon when collapsed (pingdotgg#9451) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): unify skeleton loading animations on one pulse (pingdotgg#9448) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): prioritize authored pull requests (pingdotgg#9453) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): make project icons the default (pingdotgg#9457) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(server): reuse pr state when settling threads (pingdotgg#9459) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): keep agent images collapsed (pingdotgg#9460) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): banner buttons no longer expand the resting composer (pingdotgg#9452) * fix(web): stop clipping the traits chevron on long Codex effort labels (pingdotgg#9433) Co-authored-by: Cursor <cursoragent@cursor.com> * fix(web): make right panel tabs easier to scroll (pingdotgg#9461) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): render transparent previews on white (pingdotgg#9463) * fix(mobile): show loading and syncing in the working pill (pingdotgg#9466) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(server): keep a/ and b/ prefixes in rendered git patches (pingdotgg#9438) * fix(server): full-access OpenCode threads no longer ask for approvals (pingdotgg#9282) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix(web): reuse pull request list data while loading (pingdotgg#9467) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * feat(web): let users turn off composer collapse on blur and scroll (pingdotgg#9469) Co-authored-by: Claude Code <noreply@anthropic.com> * fix(web): move workflow approval beside checks (pingdotgg#9465) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(desktop): refresh generated annotation styles (pingdotgg#9488) * fix(web): let the PR reviewer and label search boxes take keystrokes (pingdotgg#9479) Co-authored-by: Claude Code <noreply@anthropic.com> * fix(web): dont collapse composer when interacting with bottom row (pingdotgg#9490) * fix(desktop): restore second-press quit fallback (pingdotgg#9485) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): keep opencode icon hollow in collapsed composer (pingdotgg#9492) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): keep agent browser preview visible (pingdotgg#9484) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(mobile): keep the machine glyph next to the environment label (pingdotgg#9486) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(mobile): let back swipe pop from horizontal scroll edges (pingdotgg#9493) Co-authored-by: Claude Code <noreply@anthropic.com> * fix(antigravity): discover legacy workspace skills (pingdotgg#9410) Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com> * fix(mobile): resolve Antigravity provider icon and normalize driver matching (pingdotgg#9495) * fix(antigravity): forward Google sign-in URLs from browser helper (pingdotgg#9425) * feat(desktop): import browser cookies into a profile (pingdotgg#7255) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(desktop): import from Chrome, Edge, Brave, Vivaldi, Opera, Arc and Firefox (pingdotgg#7260) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(desktop): resolve Chromium cookie keys on Linux (pingdotgg#7261) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(antigravity): allow slow runtime startup during setup (pingdotgg#9510) * fix(antigravity): keep model choices up to date (pingdotgg#9511) * fix(antigravity): handle native sign-in URLs on stderr (pingdotgg#9514) * fix(antigravity): update managed runtime to 1.1.1 (pingdotgg#9509) * fix(desktop): address the browser import review left over from the stack (pingdotgg#9516) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> * feat(antigravity): show subagent calls and results (pingdotgg#9515) * fix(web): let paste expand a resting composer (pingdotgg#9498) Co-authored-by: Claude Code <noreply@anthropic.com> * fix(web): keep the composer open while selecting timeline text (pingdotgg#9499) Co-authored-by: Claude Code <noreply@anthropic.com> * fix(web): return focus to the composer after closing a media preview (pingdotgg#9513) Co-authored-by: Claude Code <noreply@anthropic.com> * fix(server): keep events during thread subscription startup (pingdotgg#9521) * chore: forward issue/PR/discussion events to Cursor hygiene (pingdotgg#9518) Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com> * fix(auth): keep pairing credentials out of access read models (pingdotgg#9523) * chore: drop comment events from Cursor hygiene forwarder (pingdotgg#9527) * feat(codex): support async questions (pingdotgg#9512) * fix(web): keep right panel controls clickable (pingdotgg#9517) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * feat(usage): show Codex and Claude subscription limits on a Limits tab (pingdotgg#9507) Users on Codex or Claude Code subscriptions could not see how much quota was left or when it resets without leaving T3 Code. A user whose CLIs route through a CLIProxyAPI hub could not see it at all. Each driver now returns `usageLimits` on its own snapshot (Codex from `account/rateLimits/read`, Claude from the SDK's `get_usage`), adapters normalise turn-driven rate-limit events at the boundary, and a driver-blind ingestion layer folds them onto the owning instance. The Usage page gains a Limits tab (mobile a card) with a bar per window, elapsed marker, pace, and reset countdown. CLIProxyAPI hubs can be added as read-only usage-limit sources; their accounts show badged "via CLIProxyAPI" with emails blurred. Distilled from pingdotgg#1732 (server model, provider rows) and pingdotgg#9421 (Limits tab, window bars, pace maths). Closes pingdotgg#228. Co-authored-by: Aditya Mer <101453576+Aditya190803@users.noreply.github.com> Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Co-authored-by: Claude Code <noreply@anthropic.com> * feat(web): reorganize settings pages (pingdotgg#9354) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(server): settle branch threads immediately on pull request merge (pingdotgg#9528) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(server): back off relay client restarts after rapid exits (pingdotgg#8788) * fix(codex): accept rate limit errors on thread resume (pingdotgg#8897) * fix(desktop): preview CDP sessions no longer hard-crash the app (pingdotgg#9068) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * Fix worktree removal timing out on large install trees (pingdotgg#3902) * fix(web): settle the resting composer layout with a pixel of slack (pingdotgg#9482) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(web): keep automatic project icons consistent (pingdotgg#9535) * fix(server): include SQLite conditions in persistence errors Include SQLite conditions and schema issue tags without copying query data. Continue @Sy-D's [pingdotgg#4837](pingdotgg#4837). Add the missing Bun error codes and test the real SQL client. Created with GPT-6 Astra (preview) in Codex. Co-authored-by: Sy-D <8460326+Sy-D@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * fix(dev): keep shared dev reloads and hot updates working (pingdotgg#9543) * feat(providers): add context compaction command (pingdotgg#9293) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(mobile): keep store screenshots free of system banners and show dictation (pingdotgg#9548) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(web): restore composer controls as space becomes available (pingdotgg#9539) * fix(web): measure collapsed model labels at their visible width (pingdotgg#9540) * fix(web): close composer menus when their controls hide (pingdotgg#9541) * fix(web): thread error banner no longer shifts the chat (pingdotgg#9473) * fix(server): reveal normalized paths in File Explorer (pingdotgg#9551) * feat(marketing): fresh screenshot and floating marks on the homepage (pingdotgg#9547) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> * feat(usage): redeem Codex reset credits from the Limits tab (pingdotgg#9534) Follow-up to pingdotgg#9507, carrying over the reset-credit redemption from pingdotgg#9421. Codex grants a reset credit when it has rate-limited an account unfairly (`"Thanks for using Codex! You've been granted one free rate limit reset."`). Redeeming one clears the current 5h/weekly windows. The Limits tab now shows how many are banked and when the next expires, with a confirmed **Use a reset credit** action. ## How it works - `ServerProviderUsageLimits.resetCredits` carries the count and soonest expiry; the Codex probe reads it from the same `account/rateLimits/read` it already makes. - `ProviderInstance.consumeResetCredit` is a new optional hook — account-level, so it sits beside `refreshModels` rather than on the thread-routed adapter. The Codex driver implements it over a short-lived app-server (via `withCodexAppServerClient`, factored out of the status and skills probes which duplicated the setup), then re-probes. - Single-flight per instance with one idempotency key kept until Codex reports an outcome, so a retry after a timeout does not open a second attempt. - New `provider.consumeResetCredit` RPC under the operate scope; the outcome (`reset` / `nothingToReset` / `noCredit` / `alreadyRedeemed`) is shown inline. Only Codex reports credits today. A provider without the hook gets a clear "does not bank reset credits" error; one without credits shows nothing. ## Screenshots The local Codex row with one banked credit (the same account via the CLIProxyAPI hub above it shows no credit, as expected — the hub does not relay them):  Close-up of the row:  Clicking it opens the confirmation; nothing is sent until **Use credit**:  ## Verification - Mapper tests for the credit summary; provider, contract, and Usage page suites pass; typecheck clean. - Verified against a real Codex Pro account holding one credit: summary and expiry render, the confirm dialog opens. **Not redeemed** — that would spend the credit. Written by Claude Fable 5 via Claude Code; design and single-flight approach from @StiensWout's pingdotgg#9421. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Redemption spends real account credits over a new RPC; correctness depends on per-account locking and idempotency, though disabled instances and non-Codex providers are rejected explicitly. > > **Overview** > Adds **end-to-end redemption of banked Codex rate-limit reset credits** from the Limits UI on web and mobile, backed by a new operate-scoped `provider.consumeResetCredit` RPC. > > **Contracts and server:** `ServerProviderUsageLimits` can include `resetCredits` (count + next expiry). Codex probes attach that from `account/rateLimits/read`. Optional `ProviderInstance.consumeResetCredit` is implemented for Codex via a scoped app-server call to `account/rateLimitResetCredit/consume`, then a limits refresh. `CodexResetCreditCoordinator` serializes redemptions per Codex account directory, reuses one idempotency key until Codex returns an outcome, and times out hung requests. `withCodexAppServerClient` is extracted so status, skills, and redemption share the same short-lived app-server setup. > > **Clients:** Limits rows show banked credits and a confirmed **Use a reset credit** action that calls `serverEnvironment.consumeResetCredit` and surfaces outcomes (`reset`, `nothingToReset`, etc.) or errors. > > **Web usage sources (same PR):** Adding/removing CLIProxyAPI hubs and the add dialog target a **selected connected environment** (with picker when several are connected), gated by operate access—not only the primary environment. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 98f32e6. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Co-authored-by: Claude Code <noreply@anthropic.com> * fix(server): find newly opened pull requests after agent turns (pingdotgg#9125) Refresh missing PR associations after agent turns on the thread's current branch. Preserve background policy, known PR caches, and failed-lookup backoff. Serialize status loads and refreshes to prevent stale responses from hiding a PR. Find branches pushed under their own name while still tracking the default branch. Original work by Theo Browne with Claude Fable 5.1 in Claude Code. Takeover fixes created with GPT-6 Astra (preview) in Codex. Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> * ci: add on-demand Windows test workflow (pingdotgg#9538) Co-authored-by: Claude Code <noreply@anthropic.com> * fix(web): simplify expanded tool details (pingdotgg#9549) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): keep the last message visible when the resting composer expands (pingdotgg#9553) Scrolling a long thread to the end with the composer at rest landed flush against the short composer. The expansion that followed then covered the last rows, because the timeline reserves only the live overlay height and does not move for footer growth. The timeline now keeps the expanded composer's height clear while the composer rests, so expanding it again changes nothing above the composer. The composer reports its resting flag from a layout effect and publishes a fresh overlay height whenever that flag changes, so the reservation is always computed from a height that belongs to the same layout. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test(web): fix flaky startup and Tailwind tests (pingdotgg#9558) * fix(web): keep codex restart responses continuous (pingdotgg#9560) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): make settings sidebar sub-section buttons full width (pingdotgg#9562) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(web): render settings sidebar immediately (pingdotgg#9563) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * chore: vouch august contributors (pingdotgg#9557) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): stabilize right panel transitions (pingdotgg#9554) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix: better shell syntax handling for labels (pingdotgg#9371) * fix(web): align the sidebar wordmark by baseline (pingdotgg#9578) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(antigravity): keep subagent batches active after launch (pingdotgg#9579) * fix(mobile): render workspace images in markdown file previews (pingdotgg#8769) * fix(usage): deduplicate CLI proxy subscription accounts (pingdotgg#9584) * fix(web): bound disconnected send toasts (pingdotgg#9592) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(desktop): restore panel titlebar interactions (pingdotgg#9591) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(connect): refresh authorization without disconnecting (pingdotgg#9582) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): show context meter in compact composer (pingdotgg#9430) * fix(pull-requests): refresh data after thread turns (pingdotgg#9496) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web): render draft PRs in gray (pingdotgg#9537) * refactor(web): move usage provider controls to settings (pingdotgg#9599) * fix: show idle subagent batches without completion marks (pingdotgg#9616) * fix(web): group image views like other tool calls (pingdotgg#9597) Co-authored-by: Claude Code <noreply@anthropic.com> * fix: preserve tool icons on failed calls (pingdotgg#9606) * fix(connect): diagnose incomplete headless server setup (pingdotgg#9602) * fix(web): keep command palette above composer menus (pingdotgg#9613) * fix(web): snooze menu no longer overlaps thread details (pingdotgg#9601) * fix(web): match composer pull request state icons (pingdotgg#9375) * fix(server): load OpenCode workspace skills via SDK to avoid 64KB CLI pipe truncation (pingdotgg#9585) * fix(web): mute sidebar branch name to match worktree icon (pingdotgg#9622) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(web,mobile): fold context compaction under settled turn folds (pingdotgg#9623) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * feat(mobile): make chat text selectable on Android (pingdotgg#8779) Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com> * fix(web): toggle a single stashed prompt with Cmd+S (pingdotgg#9644) Cmd+S opened the stash menu even when the composer was empty and only one prompt was stashed. It now restores that prompt directly, so repeated presses toggle between the draft and stash. Multiple entries and images that are still saving open the menu. The stash badge still opens the menu. Validation: 94 focused stash, shortcut, and attachment tests pass. Web typecheck and formatting pass. Targeted lint has no new warnings or errors. Browser checks were skipped at Theo's request. Original implementation by Theo Browne. No code changes were needed during the takeover audit. Audited with GPT-6 Astra (preview) in Codex. * fix(server): prevent duplicate desktop clients after restart Replace stale local desktop sessions in one transaction. Preserve paired clients and browser sessions, and keep the previous credential valid if replacement fails. Closes pingdotgg#6283. Original implementation by seeb1337. Reviewed and verified with GPT-6 Astra (preview) in Codex. Co-authored-by: seeb1337 <63622047+seeb1337@users.noreply.github.com> Co-authored-by: Theo Browne <me@t3.gg> * fix(web): resume Antigravity threads without repeated sign-in (pingdotgg#9647) Allow Antigravity threads to resume while saved Google sign-in is unchecked after a server restart. Keep confirmed authentication failures and installation errors visible. Validated with 136 focused tests, web typecheck, targeted lint, and CI. Browser verification was omitted at the maintainer's request. Created with GPT-6 Astra (preview) in Codex. * feat(mobile): paste the phone clipboard into the terminal (pingdotgg#9199) Co-authored-by: Jake Leventhal <jakeleventhal@me.com> Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com> * feat(web): show which sidebar threads hold an unsent draft (pingdotgg#9658) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> * fix(server): unblock OpenCode approvals and stop (pingdotgg#9653) OpenCode could show an Approval badge with no controls, appear stuck on TodoWrite, and keep showing a running turn after Stop. - Show every permission, including old saved requests. Keep failed replies retryable and close completed requests even when reply events are lost. - Keep OpenCode output pipes drained and automatic replies out of the event loop. Handle disconnects, reconnects, and confirmed stops without stale requests or running states. - Show native task progress and command results. Do not treat TodoWrite or approval history as file edits or executed commands. - Ignore late aborts and task updates after a turn finishes. Fixes pingdotgg#4795 Fixes pingdotgg#7113 Fixes pingdotgg#5760 Created with GPT-6 Astra (preview) in Codex. Reviewed and merged with Claude Fable 5.1 in Claude Code. * fix(desktop): quit immediately on a second shortcut press (pingdotgg#9657) * fix(server): update Claude Agent SDK to 0.3.260 (pingdotgg#9135) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> * perf(server): stop loading message bodies for thread summaries (pingdotgg#9662) * perf(web): speed up terminal snapshots (pingdotgg#9663) * Complete upstream sync adaptations and validate Claude authentication * Fix reviewed Coder sync regressions and add focused coverage * Include orchestration regression suites in Coder tests --------- Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com> Co-authored-by: Yukun Shan <92423096+nateEc@users.noreply.github.com> Co-authored-by: oliver <97427849+flamboh@users.noreply.github.com> Co-authored-by: Simone <lucenz@proton.me> Co-authored-by: Rakshith Bhat <88523594+RakshithBhat03@users.noreply.github.com> Co-authored-by: maria <maria@kuuro.net> Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Zortos <zortosdev@proton.me> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Igor Makowski <56691628+Mnigos@users.noreply.github.com> Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com> Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com> Co-authored-by: Invictine <72551038+Invictine@users.noreply.github.com> Co-authored-by: WellyngtonF <59291417+WellyngtonF@users.noreply.github.com> Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com> Co-authored-by: Aditya Mer <101453576+Aditya190803@users.noreply.github.com> Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Co-authored-by: Derek Trimm <275381468+derektrimm@users.noreply.github.com> Co-authored-by: Seth Webster <sethwebster@gmail.com> Co-authored-by: Jake Leventhal <jakeleventhal@me.com> Co-authored-by: Matheus Timbó Pereira <matheusfild4@hotmail.com> Co-authored-by: Sy-D <8460326+Sy-D@users.noreply.github.com> Co-authored-by: Yash Singh <saiansh2525@gmail.com> Co-authored-by: Dara Adedeji <76637177+SunkenInTime@users.noreply.github.com> Co-authored-by: Guilherme Vieira <46866023+GuilhermeVieiraDev@users.noreply.github.com> Co-authored-by: Guillermo Casanova <75276669+Gigioxx@users.noreply.github.com> Co-authored-by: Barry <43803274+BarryHenryJr@users.noreply.github.com> Co-authored-by: seeb1337 <63622047+seeb1337@users.noreply.github.com> Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Fable 5.1 on behalf of Oliver
Problem
ThreadErrorBannerrendered in normal flow between the workspace header and the timeline. When a thread error appeared, the whole chat column shifted down by the banner's height, and shifted back on dismiss. Any thread error triggers it; it's most noticeable with long-lived errors like a provider auth failure.Fix
The banner now lives in the same absolutely positioned,
pointer-events-noneoverlay at the top of the chat column thatProviderStatusBanneralready uses, so the timeline keeps its height. The container stacks the two banners vertically when both are visible. The banner re-enables pointer events on its wrapper and uses the existingalert-glasssurface withdata-variant="error"for the tint, matching the provider banner.Like the provider banner, the overlay covers the top of the timeline instead of pushing it down. That is the same tradeoff the provider status banner already makes.
Mobile has no equivalent thread error banner, so nothing changes there.
UI Changes
Before
After
Changes made by Fable 5.1 running in Claude Code via T3 Code.
Note
Fix thread error banner shifting chat in
ChatViewContentMoves the thread error banner into the existing top-of-timeline overlay in ChatView.tsx. The overlay now uses a vertical flex layout so the provider-status and thread-error banners stack without reserving layout height above the chat content.
Macroscope summarized e662ad0.