fix(web): scheduled task model picker no longer shifts the dialog

[flamboh]

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Problem

Opening the Model picker in the scheduled task editor makes the dialog grow by about 5px and re-center, so every field jumps. While a Base UI popover is open, it inserts hidden focus guards right after its trigger. The picker was the last child of a space-y-1.5 field, so it stopped being the last child, picked up that spacing, and pushed everything below it.

Fix

The picker gets its own <div>, so the guards land inside it. The closed layout stays exactly the same.

The other fields in that dialog are Selects and a Combobox. Their hidden form input always renders after the trigger, so they were never affected.

Before

https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/144f82e053cfed9e/scheduled-task-model-picker-before.mp4

After

https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/295e09c6f8559fea/scheduled-task-model-picker-after.mp4

Validation

Measured every label's position in the dialog with headless Chromium. Before, each one moved 2.5px when the picker opened. After, none moved, and the closed positions match main exactly. A lint rule for this pattern is in a separate PR, #18943.

Made with Claude Opus 5.5 in Claude Code, running in T3 Code.

[macroscopeapp]

🟡 Medium rules/no-popup-last-in-spaced-container.ts:126

A popup rendered inside a direct JSX fragment is not reported, so <div className="space-y-3"><><Menu /></></div> escapes the rule even though <Menu /> is the last rendered child. possiblyLast passes the fragment itself to elementName, which cannot identify its nested Menu; expand direct fragments with renderedBy before checking popup names.

Suggested change

	...(child.type === "JSXExpressionContainer" ? renderedBy(child.expression) : [child]),
	...(child.type === "JSXExpressionContainer"
	? renderedBy(child.expression)
	: child.type === "JSXFragment"
	? possiblyLast(child.children)
	: [child]),

🤖 Copy this AI Prompt to have your agent fix this:

In file @oxlint-plugin-t3code/rules/no-popup-last-in-spaced-container.ts around line 126:

A popup rendered inside a direct JSX fragment is not reported, so `<div className="space-y-3"><><Menu /></></div>` escapes the rule even though `<Menu />` is the last rendered child. `possiblyLast` passes the fragment itself to `elementName`, which cannot identify its nested `Menu`; expand direct fragments with `renderedBy` before checking popup names.

[macroscopeapp]

🟡 Medium rules/no-popup-last-in-spaced-container.ts:106

A trailing {null} makes the rule miss <Menu /> as the last rendered child, so the spacing hazard goes unreported. mayRenderNothing recognizes null only inside a ternary, while renderedBy returns a standalone null literal and possiblyLast stops there; treat a null Literal as non-rendering too.

   if (expression.type === "LogicalExpression" || expression.type === "CallExpression") return true;
+  if (expression.type === "Literal" && expression.value === null) return true;

🤖 Copy this AI Prompt to have your agent fix this:

In file @oxlint-plugin-t3code/rules/no-popup-last-in-spaced-container.ts around line 106:

A trailing `{null}` makes the rule miss `<Menu />` as the last rendered child, so the spacing hazard goes unreported. `mayRenderNothing` recognizes null only inside a ternary, while `renderedBy` returns a standalone null literal and `possiblyLast` stops there; treat a null `Literal` as non-rendering too.

[macroscopeapp]

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This one-file change is a contained layout fix that prevents hidden popup focus guards from shifting the scheduled-task dialog, without changing model-picker behavior or closed-state layout. Separate unresolved Medium-severity findings in the supplied review comments remain blocking issues for the repository, although they concern a different lint-rule file.

Not approved because:

• 2 blocking correctness issues found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: b3d222a5-1d28-49d8-b96e-22a8f581742f

📥 Commits

Reviewing files that changed from the base of the PR and between bbd98a5 and 1d4fc3f.

📒 Files selected for processing (5)

• apps/web/src/components/settings/ScheduledTasksSettings.tsx
• oxlint-plugin-t3code/index.ts
• oxlint-plugin-t3code/rules/no-popup-last-in-spaced-container.test.ts
• oxlint-plugin-t3code/rules/no-popup-last-in-spaced-container.ts
• vite.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The pull request adds an Oxlint rule that detects popup roots that may render last in containers with spacing utilities. It registers and enables the rule, adds tests, and wraps the scheduled-task model picker in a div.

Changes: Popup spacing detection

Layer / File(s)	Summary
Detect popups in spaced containers oxlint-plugin-t3code/rules/no-popup-last-in-spaced-container.ts	The new rule analyzes popup imports, local components, JSX children, and spacing utilities. It reports popup roots that may render last in a spaced container.
Register, enable, and test the rule oxlint-plugin-t3code/index.ts, vite.config.ts, oxlint-plugin-t3code/rules/no-popup-last-in-spaced-container.test.ts	The plugin registers the rule, the web-source lint override enables it as an error, and tests cover valid and invalid cases.
Wrap the scheduled-task model picker apps/web/src/components/settings/ScheduledTasksSettings.tsx	The editor wraps ProviderModelPicker in a div. Its props and selection-update behavior remain unchanged.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 1d4fc

The popup-spacing rule and scheduled-task picker change are mergeable after normal checks; no actionable issue was established.

Pre-merge checks · 4

Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely describes the primary UI fix. It uses a conventional commit format and matches the scheduled task model picker change.
Description check		The description clearly explains the problem, fix, affected behavior, and detailed verification with before-and-after evidence. It does not include a dedicated Scope and approval section, and it incor…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}