fix(mobile): pull requests load from another environment when theirs is offline

[juliusmarminge]

When the environment a pull request was opened from goes offline, mobile kept showing that environment's cached copy and never sent a request. This happened even when another connected environment had the same repository with working GitHub auth. The GitHub routing setting didn't help, because it only reroutes requests that leave a connected environment.

Fix

• Detail screen: while the pull request's environment isn't connected, the screen looks for another connected environment holding the same repository (matched by host plus owner/repo against the project's canonical repository key). If it finds one, it moves the route's environmentId/projectId there. The files, reviewers and review screens opened from it follow the new params.
• List: when two environments list the same pull request, the de-dupe used to keep the first one in environment-id order, which could be an offline environment's cached row. It now prefers a connected environment's row. Order is unchanged while both are connected.

Limits

• The fallback needs another environment with a checkout of the repository. Without one, the cached data still shows, marked Offline.
• The route doesn't switch back when the original environment reconnects.
• Review drafts are keyed by environment, so a draft started against the offline copy doesn't carry over.

Verification

• vp test run src/features/pull-requests/pullRequestEnvironmentFallback.test.ts src/features/pull-requests/pullRequestList.test.ts passes.
• Mobile tsc-rs --noEmit passes.
• Not yet tried on a device or simulator.

Done with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

---

[macroscopeapp]

🟠 High pull-requests/pullRequestEnvironmentFallback.ts:30

A connected Forgejo checkout on a non-default HTTP port is never selected, so the pull request detail screen stays offline despite an available copy. The route host forge.example:3000 is compared directly with the canonical key forge.example/team/repo, which omits the port; match using the project's provider-aware host and repository instead.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @apps/mobile/src/features/pull-requests/pullRequestEnvironmentFallback.ts around line 30:

A connected Forgejo checkout on a non-default HTTP port is never selected, so the pull request detail screen stays offline despite an available copy. The route host `forge.example:3000` is compared directly with the canonical key `forge.example/team/repo`, which omits the port; match using the project's provider-aware host and repository instead.

[macroscopeapp]

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a localized mobile bug fix with focused runtime changes and targeted tests for selecting connected pull-request data. A concrete high-severity finding remains around Forgejo repositories using non-default HTTP ports, which independently blocks clean approval until addressed.

Not approved because:

• 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.9 KiB	20.9 KiB	0 B (0.0%)	29.3 KiB	✅
Codex	Live turn messages	2	2	0 (0.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	+24 B (+0.5%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+24 B (+2.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	+41 B (+0.2%)	29.3 KiB	✅
Claude	Live turn messages	1	2	+1 (+100.0%)	8	✅

Baseline: 701fc83 · PR result: bdbdd70 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 2c4cfc12-7569-41b4-8582-b51ba5eba8cd

---

📥 Commits

Reviewing files that changed from the base of the PR and between 701fc83 and bdbdd70.

---

📒 Files selected for processing (7)

• apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx
• apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx
• apps/mobile/src/features/pull-requests/pullRequestEnvironmentFallback.test.ts
• apps/mobile/src/features/pull-requests/pullRequestEnvironmentFallback.ts
• apps/mobile/src/features/pull-requests/pullRequestList.test.ts
• apps/mobile/src/features/pull-requests/pullRequestList.ts
• apps/mobile/src/features/pull-requests/usePullRequestEnvironmentFallback.ts

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

---

📝 Walkthrough

Walkthrough

Pull-request routes can switch to a connected project with the same repository identity. The pull-request list can prefer a connected environment when duplicate entries share a repository.

Changes

Pull request environment selection

Layer / File(s)	Summary
Route environment fallback apps/mobile/src/features/pull-requests/pullRequestEnvironmentFallback.ts, apps/mobile/src/features/pull-requests/usePullRequestEnvironmentFallback.ts, apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx, apps/mobile/src/features/pull-requests/pullRequestEnvironmentFallback.test.ts	The route checks for a connected project with a matching repository identity and updates its navigation parameters when a fallback is found. Tests cover matching projects, connected targets, and host derivation.
Connected pull-request list entries apps/mobile/src/features/pull-requests/pullRequestList.ts, apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx, apps/mobile/src/features/pull-requests/pullRequestList.test.ts	The list filter accepts connected environment IDs and prefers a connected entry among duplicate pull requests. The screen recomputes entries when connected targets change. Tests cover connected and disconnected duplicates.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant PullRequestRouteScreen
  participant usePullRequestEnvironmentFallback
  participant pullRequestFallbackEnvironment
  participant Navigation
  PullRequestRouteScreen->>usePullRequestEnvironmentFallback: pass route parameters
  usePullRequestEnvironmentFallback->>pullRequestFallbackEnvironment: pass target, projects, and connected environment IDs
  pullRequestFallbackEnvironment-->>usePullRequestEnvironmentFallback: return fallback or null
  usePullRequestEnvironmentFallback->>Navigation: set fallback route parameters

Loading

---

Merge Risk: ⚪ Minimal · up to bdbdd

No confirmed issue prevents merging. Hostless deep links on a cold start remain worth checking on a device.

Pre-merge checks | 3 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check		The description explains the problem, implementation, limitations, and verification results. It does not include the required Scope and approval section or explain why the focused fix qualifies withou…	Add a Scope and approval section. Link the triaged issue or maintainer approval, including the approval comment. If no prior issue or approval exists, explain why this focused fix addresses an obvious bug and qualifies for the exception.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main mobile pull-request fallback behavior when the original environment is offline.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

Full details: Description check

Explanation

The description explains the problem, implementation, limitations, and verification results. It does not include the required Scope and approval section or explain why the focused fix qualifies without prior issue or maintainer approval.

---

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

---

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}