Skip to content

feat(server): rename built-in models from settings - #18840

Merged
t3dotgg merged 1 commit into
mainfrom
t3/model-display-name-overrides
Oct 12, 2026
Merged

t3dotgg merged 1 commit into
mainfrom
t3/model-display-name-overrides

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Oct 12, 2026

Copy link
Copy Markdown
Member

There was no way to change the display name of a built-in model. Provider names could be overridden (providerInstances.<id>.displayName), but a customModels entry that reused a built-in slug was silently dropped.

Now a named customModels entry whose slug matches a built-in renames that model on the server. Every client (web, desktop, mobile) gets the new name from the provider snapshot.

"providerInstances": {
  "codex": {
    "driver": "codex",
    "config": { "customModels": [{ "slug": "gpt-5.5", "name": "Team GPT" }] }
  }
}
  • providerModelsFromSettings applies the rename and drops the built-in shortName so compact UI does not show the old name. Codex now uses this helper instead of its own copy.
  • Applies to every provider that merges custom models: Codex, Claude, Cursor, Grok, OpenCode, Muse, Pi, ACP. Antigravity has no custom models.
  • The settings card no longer shows a duplicate custom row for an override. The settings file is the way in and the way out.
  • Added a user doc example and one focused test.

🤖 Generated with Claude Code (Claude Opus 5.5)

A named customModels entry whose slug matches a built-in model now
renames that model in the provider snapshot, so every client shows the
new name. Codex reuses the shared merge helper.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Oct 12, 2026
@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 12, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds an opt-in capability for renaming built-in model labels across provider snapshots and clients, with limited implementation scope and no product-default or sensitive-data changes. Because it modifies shared provider infrastructure and introduces cross-provider user-visible behavior in areas historically maintained by another contributor, human review is recommended.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB +24 B (+0.5%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB +24 B (+2.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB +41 B (+0.2%) 29.3 KiB ✅
Claude Live turn messages 1 2 +1 (+100.0%) 8 ✅

Baseline: a3c4e9e · PR result: 10ef9b6 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Team
  • Run ID: b68cdf32-ad3d-4f7b-b518-0b5aac06112a
📥 Commits

Reviewing files that changed from the base of the PR and between a3c4e9e and 10ef9b6.

📒 Files selected for processing (5)
  • apps/server/src/provider/CodexProvider.ts
  • apps/web/src/components/settings/ProviderInstanceCard.tsx
  • docs/user/composer.md
  • packages/provider-core/src/server/snapshotProbe.test.ts
  • packages/provider-core/src/server/snapshotProbe.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

Custom model settings can rename built-in models that have matching slugs. The Codex provider now uses shared model composition, and the settings display omits matching custom entries. Documentation and a test describe and verify the updated behavior.

Changes

Custom model naming

Layer / File(s) Summary
Built-in model name overrides
packages/provider-core/src/server/snapshotProbe.ts, packages/provider-core/src/server/snapshotProbe.test.ts
providerModelsFromSettings accepts nullable fallback capabilities and applies a differing custom name to a built-in model with the same slug. The override removes the built-in model’s shortName. The test checks the name, custom status, and capabilities.
Provider and settings integration
apps/server/src/provider/CodexProvider.ts, apps/web/src/components/settings/ProviderInstanceCard.tsx, docs/user/composer.md
The Codex provider delegates model composition to the shared helper. The settings display excludes custom entries whose slugs match built-in models. The documentation shows a settings.json example for renaming a built-in model.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 10ef9

The reported naming concern does not require a change. No merge-blocking issue is established.

Pre-merge checks · Passed 3 · Failed 1

Failed Failed checks (1 warning)

Check name Status Explanation Resolution
Description check Warning The description clearly explains the problem and implementation, but it does not follow the required section structure. It omits scope and approval details, focused verification results, and any UI ev… Add the required Problem, Change, Scope and approval, and Verification sections. Link the triaged issue or maintainer approval, or explain why approval is not required. Document the exact tests or manual checks run and their observed result…
Passed Passed checks (3 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: renaming built-in models through server settings.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the problem and implementation, but it does not follow the required section structure. It omits scope and approval details, focused verification results, and any UI evidence for the settings-card change.

Resolution

Add the required Problem, Change, Scope and approval, and Verification sections. Link the triaged issue or maintainer approval, or explain why approval is not required. Document the exact tests or manual checks run and their observed results. Include before and after screenshots for the UI change, if applicable.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@t3dotgg
t3dotgg merged commit ffb4af8 into main Oct 12, 2026
33 checks passed
@t3dotgg
t3dotgg deleted the t3/model-display-name-overrides branch October 12, 2026 23:30
aorwall added a commit to aorwall/t3code that referenced this pull request Oct 13, 2026
Merges upstream `pingdotgg/t3code` `5070a83a32` (48 commits, base
`e688034b5f`) into the fork. It does not stack on another PR.

## Merge
- 240 of 240 upstream-range files landed. Fork delta: 775 files.
- One conflict: `apps/web/src/routeTree.gen.ts`, regenerated for
upstream's new `/_chat/new` route. The other 18 files both sides touched
auto-merged: `duplicate-adds` and `resolution-check` are clean, and
every delta guard holds.
- `pnpm-lock.yaml` was re-derived by install, and `verify --only
lockfile` passes.
- Sweep: `promptLinks/HostedPromptLinkLanding.tsx` renders only in the
`hosted-static` auth state, which Moatless never reaches. Taken as
upstream's.
- Unsupported methods: ADD 0, DROP 0.

## Verification
`verify.mjs` passes duplicate-adds, tripwires, resolution-check,
unsupported-methods, lockfile, fmt, lint, typecheck and build. `test`
fails only on files that fail alone and failed the same way on the last
three merges, because of the sandbox: shared `AgentScope`
(`oom_score_adj` is 935 here), server `ServerBrowserPage` (no Playwright
browser), `AcpAdapterV2`, `OrchestratorReplayFixtures`, and
provider-opencode `OpenCodeServerLedger`.

## Usable as-is
- Prompt links (pingdotgg#18454): `/new?prompt=…`, `ThreadLinkPrompt` on thread
routes, and copy-prompt-link from messages and the command palette.
Choosing a project and placing the prompt work against Moatless.
- Terminal colors (pingdotgg#17168), context meter rounding (pingdotgg#17539), stable
button text (pingdotgg#18866), setup wizards follow themes (pingdotgg#18725), Git actions
follow the selected thread (pingdotgg#18862), dropped threads attach to pending
answers (pingdotgg#18789), the compact merge-button second click (pingdotgg#18878), a
numeric `q` on pull requests (pingdotgg#18666), the home-page bounce fix
(pingdotgg#18672), running terminals shown in the sidebar (pingdotgg#18740), and
computer-use titles (pingdotgg#18865).
- Mobile and desktop fixes (theme contrast, settings rows, the PR action
bar, image caching, the iOS 27.2 black screen, Hyprland, updater
diagnostics).
- "Update everything" sidebar pill (pingdotgg#18053): inert against Moatless,
which advertises no `serverSelfUpdate` or `versionAdvisory`.

## Unsupported in Moatless / needs implementation
- Prompt-link "clone this repository"
(`NewThreadLinkView.cloneRepository`): needs `projectClone.start` and
the `projectCloneTracking` capability. It refuses with a message today.
Added to gaps.md under *Project and repository management*.
- Renaming built-in models (pingdotgg#18840): saves through
`server.updateSettings` (custom model entry with a built-in slug). It
stays behind `FEATURES.providerConfiguration`, under the existing
settings gap.
- Provider secret settings (pingdotgg#18505, `secretSetting` and
`isSecretSetting` in contracts): stored on the host, so they fall under
the same settings gap.

## Backend behavior to consider reproducing in Moatless
Recorded in gaps.md under *Runtime fixes upstream made to its own
server*:
- A confirmed Claude subagent outcome settles that task and its child
work (pingdotgg#18778, the new `subagent` target on
`thread.background-work.settle`).
- Claude thinking before a tool call stays a collapsed Thought (pingdotgg#18887).
- Codex title and branch-name generation no longer starts the user's MCP
servers (pingdotgg#17058).
- The event store resyncs a thread holding an event type from a newer
build (pingdotgg#15937, `isKnownOrchestrationV2EventType`).
- A migration id clash stops startup with a clear error (pingdotgg#15925).
- Cached branch PR lookups start no git process (pingdotgg#17063).
- PR head commits are reported for Forgejo, GitLab and Bitbucket
(pingdotgg#18463, pingdotgg#18608, pingdotgg#18402), and PR bases resolve to branch names (pingdotgg#18754).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---
Moatless task:
https://moatless.soaplabstest.com/tasks/dcd13b46-6495-4b1d-af7c-03da83644d11
adampeterhiggins added a commit to adampeterhiggins/t3code that referenced this pull request Oct 13, 2026
* fix(gitlab): merge request details report their head commit (pingdotgg#18608)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* feat(server): rename built-in models from settings (pingdotgg#18840)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* fix(web): Git actions follow the selected thread (pingdotgg#18862)

* fix(desktop): preserve updater failure causes in diagnostics (pingdotgg#18864)

* fix(web): attach dropped threads to pending answers (pingdotgg#18789)

* fix(web): keep button text stable during press scaling (pingdotgg#18866)

* fix(bitbucket): preserve PR head commits for review guides (pingdotgg#18402)

* fix(server): return null for unresolved optional commands (pingdotgg#18871)

* fix: show computer-use action titles and align app icons (pingdotgg#18865)

* fix(server): apply confirmed Claude subagent outcomes (pingdotgg#18778)

* fix(mobile): Browser page no longer logs a duplicate key warning (pingdotgg#18776)

* fix(web): a numeric q in the pull requests URL no longer crashes the page (pingdotgg#18666)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* fix(client): T3 Connect clients reconnect once a new tunnel is ready (pingdotgg#16554)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* fix(web): leaving the home page while the app loads no longer bounces you to a new draft (pingdotgg#18672)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* fix(mobile): attachment images no longer re-download on every reconnect (pingdotgg#18824)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* fix(server): a migration id clash stops startup with a clear error instead of crash-looping (pingdotgg#15925)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: PR Batch Tester <agent@local.test>

* fix(server): a thread with an event type from a newer build can still resync after a downgrade (pingdotgg#15937)

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: PR Batch Tester <agent@local.test>

* fix(server): Codex titles and branch names no longer start the user's MCP servers (pingdotgg#17058)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>

* fix(server): Claude thinking before a tool call stays a collapsed Thought (pingdotgg#18887)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

* perf(server): cached branch PR lookups no longer start git processes (pingdotgg#17063)

* fix(web): compact merge buttons show when they need a second click (pingdotgg#18878)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* fix(mobile): pull requests load from another environment when theirs is offline (pingdotgg#18698)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* perf(web): collect active tool calls without array shifts (pingdotgg#18853)

Co-authored-by: SAPHID <saphid@users.noreply.github.com>
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>

* fix(web): center the pace icon on the limit card's "left" label (pingdotgg#18580)

* fix(web): update everything includes npm-installed servers again (pingdotgg#18709)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* fix(server): review guides find Bitbucket heads reported by short hash (pingdotgg#18900)

Co-authored-by: Pawel Mikolajczuk <pmikolajczuk@atlassian.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* fix(web): scheduled task model picker no longer shifts the dialog (pingdotgg#18940)

* fix(ci): CodeRabbit reviews no longer request changes (pingdotgg#18954)

---------

Co-authored-by: Scott Norteman <snorteman@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
Co-authored-by: Paweł Mikołajczuk <pawel@mikolajczuk.in>
Co-authored-by: Tristan Knight <admin@snappeh.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Bryce Bjork <brycedbjork@gmail.com>
Co-authored-by: maria <maria@kuuro.net>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: Dara Adedeji <76637177+SunkenInTime@users.noreply.github.com>
Co-authored-by: Antony <97451137+TonybynMp4@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Alex Southwell <saphid@gmail.com>
Co-authored-by: SAPHID <saphid@users.noreply.github.com>
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Co-authored-by: Akash Moradiya <64416825+akash3444@users.noreply.github.com>
Co-authored-by: Pawel Mikolajczuk <pmikolajczuk@atlassian.com>
Co-authored-by: oliver <97427849+flamboh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants