fix(git): preserve whitespace in file paths (#12464)

[Defmon3]

Closes #12464

Git action inputs and working-tree status results trim file paths, changing " leading.txt" into "leading.txt". Preserve the exact strings in both path fields while continuing to reject empty paths.

Verification against upstream 9ea9c3d5d: the two whitespace-preservation assertions fail without the fix and pass with it. Both empty-path rejection assertions pass in both cases, giving four passing focused tests with the fix. This verifies schema decoding; a complete staging or commit operation was not tested.

Developed with Astra 6 in Codex/T3 Code and reviewed with Fable 5.1.

[macroscopeapp]

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a small, backward-compatible Git path-validation fix with focused regression tests and no broad runtime or infrastructure changes. However, server-side path parsers still trim whitespace before these schemas receive the values, leaving the intended end-to-end fix incomplete.

Not approved because:

• 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5c3110c0-9580-476c-8be6-cd3b2e7c3467

📥 Commits

Reviewing files that changed from the base of the PR and between c616e16 and 997e18d.

📒 Files selected for processing: 2

• packages/contracts/src/git.test.ts
• packages/contracts/src/git.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The change adds a non-empty Git path schema that does not trim whitespace. Git action inputs and VCS working-tree paths use this schema. Tests cover whitespace preservation and empty-path rejection.

Changes: Git path decoding

Layer / File(s)	Summary
Path schema updates packages/contracts/src/git.ts	Adds GitFilePath and applies it to GitRunStackedActionInput.filePaths and VCS working-tree paths.
Path decoding tests packages/contracts/src/git.test.ts	Verifies that path whitespace is preserved and empty paths are rejected in both schemas.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 997e1

Git paths retain their exact whitespace while empty paths remain rejected. No actionable merge-blocking risk is established.

Security architecture risk: ⚪ Minimal · up to 997e1

The change preserves filename whitespace without changing write permissions or Git command execution controls. No material security risk introduced or worsened by this PR was found. Complete status-to-commit whitespace preservation remains unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The changed path values can affect which files an authorized Git action stages in its selected repository. The inspected flow does not give those values new environment authority, working-directory selection authority, or command interpretation.

Trust Boundaries and Controls

• observed — The stacked-action RPC requires source-control write scope. Server authorization checks the connection's scopes before allowing execution, and the workflow retains its Git repository precondition for the requested working directory.

Resilience and Maintainability Implications

• observed — The existing action lifecycle guards client state by action identity, serializes client actions per target, and invalidates server status on terminal paths. Commit-context preparation uses a temporary index with scoped cleanup; final staging intentionally changes the real index. This PR does not add transactional rollback or server-side action deduplication.

Pre-merge checks: 4

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: preserving whitespace in Git file paths.
Description check		The description explains the problem, the fix, linked issue, focused verification results, and test limitations. It does not use the template headings or explicitly describe approval scope, but the re…
Linked Issues check		The PR satisfies the coding requirements in #12464. GitFilePath preserves leading and trailing whitespace and rejects empty strings. GitRunStackedActionInput.filePaths and `VcsStatusLocalResult.wo…
Out of Scope Changes check		The changes stay within #12464. The production change updates only the two affected Git path schemas. The added tests directly verify the issue requirements. The available summary shows no unrelated f…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

_{Comment @coderabbitai help to get the list of available commands.}

[Yash-Singh1]

Note

Generated by GPT 6.1 Sol

@coderabbitai full review

The incremental review was skipped because its checkpoint could not be recovered after the merge from main. Requesting a full review of the current PR diff at 997e18def831087a1898588620855bd836d7db7b.

[coderabbitai]

✅ Action performed

Full review finished.