Skip to content

feat(enrichment): recognize more binary formats (audio/video/disk/ML) - #3585

Closed
jeffrey701 wants to merge 1 commit into
JSONbored:mainfrom
jeffrey701:feat/binary-ext-more-formats
Closed

feat(enrichment): recognize more binary formats (audio/video/disk/ML)#3585
jeffrey701 wants to merge 1 commit into
JSONbored:mainfrom
jeffrey701:feat/binary-ext-more-formats

Conversation

@jeffrey701

Copy link
Copy Markdown
Contributor

BINARY_FILE_EXTENSIONS covered many formats but missed common audio/video containers (m4a, m4v, aac, opus, wma, aiff, flv, wmv), disk images (iso, dmg), and ML artifacts (pkl, pickle, joblib, tflite, keras) — so a committed file of those types was treated as reviewable source. Adds them + extends the test. rees green (1026).

BINARY_FILE_EXTENSIONS covered many formats but missed common audio/video
containers (m4a, m4v, aac, opus, wma, aiff, flv, wmv), disk images (iso, dmg),
and ML artifacts (pkl, pickle, joblib, tflite, keras) — so a committed file of
those types was treated as reviewable source. Adds them + extends the test.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - reject/close recommended

Review updated: 2026-07-05 18:02:13 UTC

2 files · 1 AI reviewer · 2 blockers · readiness 73/100 · CI green · clean

🛑 Suggested Action - Reject/Close

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.

Review summary
Adds 15 new binary file extensions (audio/video containers, disk images, ML artifacts) to the shared BINARY_FILE_EXTENSIONS list and extends the test suite to cover representative cases for each new category. The change is a simple, low-risk data addition — no logic changes to isBinaryFileExtension or BINARY_EXT_RE, all new extensions are plain alphanumeric so the regex join by "|" builds safely, and none collide with existing entries. Tests exercise m4a/opus/flv/dmg/iso/pkl/tflite explicitly and the case-insensitivity/rejection tests continue to pass against the updated list; CI is green.

Nits — 5 non-blocking
  • Not every new extension gets a dedicated positive-match test case (e.g. m4v, aac, wma, aiff, wmv, pickle, joblib, keras are added to the array but not individually asserted in binary-extensions.test.ts) — consider adding one representative path per new extension for full coverage.
  • The comment above the new entries in binary-extensions.ts groups three unrelated categories (audio/video, disk images, ML) under one generic comment; matching the file's existing per-category comment style (e.g. separate '// Disk images' / '// ML artifacts' headers) would keep the list easier to scan.
  • review-enrichment/test/binary-extensions.test.ts: add assertions for m4v, aac, wma, aiff, wmv, pickle, joblib, and keras to match the coverage given to m4a/opus/flv/dmg/iso/pkl/tflite.
  • review-enrichment/src/analyzers/binary-extensions.ts:96-110: split the single combined comment into per-category comments consistent with the rest of the file (Images/Fonts/Media/etc.).
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.

Why this is blocked

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.
Signal Result Evidence
Code review ❌ 2 blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 74 registered-repo PR(s), 39 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jeffrey701; Gittensor profile; 74 PR(s), 0 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Review context
  • Author: jeffrey701
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: Clojure, TypeScript
  • Official Gittensor activity: 74 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Gittensory is closing this pull request on the maintainer's behalf (No linked issue detected; Maintainer requires a linked issue). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant