[juliusmarminge]

Problem

On Windows, installing Antigravity can fail with "Antigravity browser suppression could not be verified." This happens when the server inherits a stale CHROME_CRASHPAD_PIPE_NAME, for example a dead \\.\pipe\crashpad_<pid>_… carried in through an updater or installer launch chain. The browser-preflight helper is the Electron exe run as Node, and it passed that variable through. The helper then prints a Crashpad registration_protocol_win.cc … CreateFile error to stderr before the marker line, so the preflight's exact stderr match fails. The install rolls back on every retry.

Change

CHROME_CRASHPAD_PIPE_NAME is added to removedEnvironmentKeys in apps/server/src/provider/antigravityAuthSupport.ts. That list is matched case-insensitively and feeds antigravityEnvironment, which builds the environment for the browser preflight, for the ACP runtime, and for the sign-in BROWSER helper the runtime starts. None of these children need a Crashpad pipe, and T3 registers no crash reporter of its own. The strict stderr check is unchanged.

Scope and approval

Fixes #26368

Triaged via the automated issue flow.

Verification

• vp test run apps/server/src/provider/antigravityAuthSupport.test.ts: the existing test "Antigravity process environment > isolates the profile and harness after merging overrides without changing the base environment" now puts CHROME_CRASHPAD_PIPE_NAME and a lowercase alias in its base env.

  • On main (fa47d7f, before the fix): 1 failed, 25 passed. Both Crashpad keys leaked into the spawn env:

    +     "CHROME_CRASHPAD_PIPE_NAME": "\\\\.\\pipe\\crashpad_50144_ZUJNJELFHHXPBIRT",
    +     "chrome_crashpad_pipe_name": "\\\\.\\pipe\\crashpad_stale_alias",
    

  • With the fix: 26 passed.

• vp run check:changed: format, lint, knip, typecheck and tests all pass.

• Runtime transcript: buildAntigravityAcpSpawnInput with a win32 profile and the stale pipe from the report in its base env:

  $ node env-transcript.mjs  # at a4e1986585 (main)
  CHROME_CRASHPAD_PIPE_NAME in Antigravity child env: "\\\\.\\pipe\\crashpad_50144_ZUJNJELFHHXPBIRT"
  $ node env-transcript.mjs  # at b3dd8c84c6 (fix)
  CHROME_CRASHPAD_PIPE_NAME in Antigravity child env: null
  

  env-transcript.mjs (synthetic driver, not committed)

  const mod = await import(process.argv[2]); // path to antigravityAuthSupport.ts
  const env = mod.buildAntigravityAcpSpawnInput({
    installation: { executablePath: "C:\\release\\agy_acp_server.exe", harnessPath: "C:\\release\\localharness_external.exe" },
    profile: { platform: "win32", geminiHome: "C:\\p", acpDirectory: "C:\\p\\acp", tokenPath: "C:\\p\\acp\\t.json", tempDirectory: "C:\\p\\tmp", browserCommand: "helper" },
    cwd: "C:\\project",
    baseEnv: { PATH: "C:\\Windows\\system32", CHROME_CRASHPAD_PIPE_NAME: "\\\\.\\pipe\\crashpad_50144_ZUJNJELFHHXPBIRT" },
  }).env;
  console.log("CHROME_CRASHPAD_PIPE_NAME in Antigravity child env:", JSON.stringify(env.CHROME_CRASHPAD_PIPE_NAME ?? null));

• On Linux, the preflight helper source run under real Electron 44.9.3 with ELECTRON_RUN_AS_NODE=1 prints only the marker line, with or without the stale variable. The Crashpad pipe registration is Windows-only code, so the visible symptom cannot be reproduced on Linux.

• cannot-verify windows: the Crashpad stderr line and the full Antigravity install on Windows were not run. The mechanism comes from the reporter's Procmon capture and their manual re-spawn.

Claude Opus 5.5 (lead, test, implementation, review B) and GPT-6.1 Sol (review A), via Claude Code and Codex in T3 Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 7c78ead

Macroscope's review found this PR approvable — The change prevents Antigravity subprocesses from inheriting a stale Crashpad pipe that can disrupt installation. Its effect is confined to child-process environment sanitization, without changing authentication settings or stored data.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: fix/issue-26368
• File: .coderabbit.config.ts
• Commit: 7c78ead
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 32860aaf-dd40-4711-b7ca-02cf6be4556c

Commits

Reviewing files that changed from the base of the PR and between be2ea30 and 7c78ead.

Files selected for processing: 2

• apps/server/src/provider/antigravityAuthSupport.test.ts
• apps/server/src/provider/antigravityAuthSupport.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

The Antigravity child environment filter now removes CHROME_CRASHPAD_PIPE_NAME. The test environment includes uppercase and lowercase versions of the variable.

Changes: Antigravity child environment

Layer / File(s)	Summary
Filter the Crashpad pipe variable apps/server/src/provider/antigravityAuthSupport.ts, apps/server/src/provider/antigravityAuthSupport.test.ts	The removed environment key list now includes CHROME_CRASHPAD_PIPE_NAME. The test base environment includes uppercase and lowercase versions of the variable.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related PRs

• pingdotgg/t3code#26115 — Both PRs extend environment filtering for Antigravity child processes, for different variables.

Suggested reviewers: macroscopeapp

Merge Risk: Minimal · up to 7c78e

The environment filtering fix addresses the reported Antigravity preflight failure without leaving an identified merge-blocking risk.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the change and the symptom: Antigravity installs no longer fail on a stale Windows Crashpad pipe. It matches the PR, which adds CHROME_CRASHPAD_PIPE_NAME to removedEnvironmentKeys. It …
Description check		The description follows the template. It has Problem, Change, Scope and approval, and Verification sections. The Problem and Change sections are clear and detailed. Scope links the issue (#26368) and …
Linked Issues check		[#26368] The issue asks that the Antigravity browser-preflight environment stop carrying a stale CHROME_CRASHPAD_PIPE_NAME. Its suggested fix is to add that key to removedEnvironmentKeys in antigravit…
Out of Scope Changes check		The whole-PR diff against merge base be2ea30 touches two files. In antigravityAuthSupport.ts, the change adds one entry and a two-line comment to removedEnvironmentKeys. In antigravityAuthSupport.test…

Full details: Title check

Explanation

The title names the change and the symptom: Antigravity installs no longer fail on a stale Windows Crashpad pipe. It matches the PR, which adds CHROME_CRASHPAD_PIPE_NAME to removedEnvironmentKeys. It is specific and follows conventional commit form, so it passes.

Full details: Description check

Explanation

The description follows the template. It has Problem, Change, Scope and approval, and Verification sections. The Problem and Change sections are clear and detailed. Scope links the issue (#26368) and says it was triaged through the automated issue flow. Verification lists focused test runs, before and after results, a runtime transcript, and states what could not be checked on Windows. The Scope section is thin: it does not include a maintainer approval comment or explain why the fix qualifies without prior discussion. The template asks for that explanation, so the check is marked as a pass with that gap noted.

Full details: Linked Issues check

Explanation

[#26368] The issue asks that the Antigravity browser-preflight environment stop carrying a stale CHROME_CRASHPAD_PIPE_NAME. Its suggested fix is to add that key to removedEnvironmentKeys in antigravityEnvironment. At head 7c78ead, apps/server/src/provider/antigravityAuthSupport.ts adds "CHROME_CRASHPAD_PIPE_NAME" to removedEnvironmentKeys. antigravityEnvironment drops any base env key whose key.toUpperCase() is in that set, so the variable and its case aliases are removed. prepareAntigravityProfile builds the preflight spawn env from antigravityEnvironment, so the preflight child no longer inherits the stale pipe. The test file adds the uppercase key and a lowercase alias to the base env of the existing isolation test, which covers the case-insensitive removal. The optional stderr tolerance in the issue is not a requirement. The PR keeps the strict stderr check, which the PR description states explicitly. The change does not alter the 5 s timeout or the compiled-binary variants that the issue lists as related. Live Windows reproduction was not run, so the Crashpad stderr behavior is not verified on Windows. The source-level requirement is met.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff against merge base be2ea30 touches two files. In antigravityAuthSupport.ts, the change adds one entry and a two-line comment to removedEnvironmentKeys. In antigravityAuthSupport.test.ts, the change adds two base-env entries, the uppercase CHROME_CRASHPAD_PIPE_NAME key and its lowercase alias, to the existing environment-isolation test. Both edits target the same stale-Crashpad-pipe behavior described in #26368. No unrelated code, refactoring, or documentation changes appear in the reviewed diff. The PR description's build and test commands are reported as results and were not re-run here.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	+29 B (+0.6%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+29 B (+2.3%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	21.5 KiB	21.6 KiB	+41 B (+0.2%)	24.4 KiB	✅
Codex	Live turn messages	1	2	+1 (+100.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.3 KiB	1.3 KiB	0 B (0.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.9 KiB	21.9 KiB	0 B (0.0%)	24.4 KiB	✅
Claude	Live turn messages	2	2	0 (0.0%)	8	✅

Baseline: be2ea30 · PR result: 7c78ead · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.