Skip to content

i18n(ja): restore literal MySQL/TiDB privilege names - #23716

Merged
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-privilege-names
Sep 3, 2026
Merged

i18n(ja): restore literal MySQL/TiDB privilege names#23716
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-privilege-names

Conversation

@yahonda

@yahonda yahonda commented Sep 3, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Literal MySQL/TiDB SQL privilege names and identifiers (e.g. SELECT, RELOAD, SHOW DATABASES, DASHBOARD_CLIENT, information_schema.columns) were translated word-by-word into Japanese prose in privilege-requirement lists/tables, instead of being kept as the exact identifier a reader needs to write a GRANT statement or configure permissions. Same defect class as the S3 API action names fixed in #23715, found while investigating that issue; a corpus-wide follow-up search found 2 more affected files.

  • tidb-cloud/migrate-from-op-tidb.md and its sibling tidb-cloud/premium/migrate-from-op-tidb-premium.md: a "Configure privileges for Dumpling" list had all 5 entries mistranslated — SELECT→"選択", RELOAD→"リロード", LOCK TABLES→"ロックテーブル", REPLICATION CLIENT→"レプリケーションクライアント", PROCESS→"プロセス".
  • dashboard/dashboard-user.md: a "Required privileges" section listed the same privileges mistranslated in 3 places throughout the file — PROCESS/SHOW DATABASES/CONFIG/DASHBOARD_CLIENT (appearing twice), plus TiDB's dynamic privileges RESTRICTED_TABLES_ADMIN/RESTRICTED_STATUS_ADMIN/RESTRICTED_VARIABLES_ADMIN/SYSTEM_VARIABLES_ADMIN (the latter appearing twice). The file's own frontmatter summary and its GRANT ... SQL code examples already correctly kept these as literal English identifiers — only the prose bullet lists had been translated.
  • dumpling-overview.md: a "Required privileges" list had PROCESS→"プロセス", LOCK TABLES→"テーブルのロック", REPLICATION CLIENT→"レプリケーションクライアント", SHOW VIEW→"ビューの表示" (while SELECT and RELOAD in the same list were already correct).
  • tidb-lightning/tidb-lightning-requirements.md: the entire "Required privilege" column of the target-database privilege table was affected — CREATE, SELECT, INSERT, UPDATE, DELETE, DROP, ALTER, CREATE, SELECT (×2), SUPER (mistranslated as "素晴らしい", literally "wonderful" — a striking false-friend), RESTRICTED_VARIABLES_ADMIN, RESTRICTED_TABLES_ADMIN, and SELECT, INSERT, UPDATE, DELETE, CREATE, DROP (×3 rows). Also fixed information_schema.columns (a literal system-table reference in the "Scope" column) which had been translated as "情報スキーマ列".

Searched the rest of the corpus (privilege-management.md, all sql-statement-grant/create-role/create-user/show-grants/revoke pages, column-privilege-management.md, role-based-access-control.md, user-account-management.md, all dm/*, tidb-lightning/*, br/* pages, and TiDB Cloud migration/import/backup guides) — no further instances of this defect found; all other privilege/identifier mentions are already correctly kept literal.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 0b699c4e-9577-49df-8ce9-63fd183828b1

📥 Commits

Reviewing files that changed from the base of the PR and between 0cc9783 and 3b8ea57.

📒 Files selected for processing (5)
  • dashboard/dashboard-user.md
  • dumpling-overview.md
  • tidb-cloud/migrate-from-op-tidb.md
  • tidb-cloud/premium/migrate-from-op-tidb-premium.md
  • tidb-lightning/tidb-lightning-requirements.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yahonda
yahonda marked this pull request as ready for review September 3, 2026 02:47
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 3, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 3, 2026
@qiancai
qiancai merged commit a82e814 into pingcap:i18n-ja-release-8.5 Sep 3, 2026
5 of 9 checks passed
@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-03 03:40:01.207199918 +0000 UTC m=+1337036.378294073: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants