i18n(ja): restore literal MySQL/TiDB privilege names - #23716
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
Literal MySQL/TiDB SQL privilege names and identifiers (e.g.
SELECT,RELOAD,SHOW DATABASES,DASHBOARD_CLIENT,information_schema.columns) were translated word-by-word into Japanese prose in privilege-requirement lists/tables, instead of being kept as the exact identifier a reader needs to write aGRANTstatement or configure permissions. Same defect class as the S3 API action names fixed in #23715, found while investigating that issue; a corpus-wide follow-up search found 2 more affected files.tidb-cloud/migrate-from-op-tidb.mdand its siblingtidb-cloud/premium/migrate-from-op-tidb-premium.md: a "Configure privileges for Dumpling" list had all 5 entries mistranslated —SELECT→"選択",RELOAD→"リロード",LOCK TABLES→"ロックテーブル",REPLICATION CLIENT→"レプリケーションクライアント",PROCESS→"プロセス".dashboard/dashboard-user.md: a "Required privileges" section listed the same privileges mistranslated in 3 places throughout the file —PROCESS/SHOW DATABASES/CONFIG/DASHBOARD_CLIENT(appearing twice), plus TiDB's dynamic privilegesRESTRICTED_TABLES_ADMIN/RESTRICTED_STATUS_ADMIN/RESTRICTED_VARIABLES_ADMIN/SYSTEM_VARIABLES_ADMIN(the latter appearing twice). The file's own frontmatter summary and itsGRANT ...SQL code examples already correctly kept these as literal English identifiers — only the prose bullet lists had been translated.dumpling-overview.md: a "Required privileges" list hadPROCESS→"プロセス",LOCK TABLES→"テーブルのロック",REPLICATION CLIENT→"レプリケーションクライアント",SHOW VIEW→"ビューの表示" (whileSELECTandRELOADin the same list were already correct).tidb-lightning/tidb-lightning-requirements.md: the entire "Required privilege" column of the target-database privilege table was affected —CREATE, SELECT, INSERT, UPDATE, DELETE, DROP, ALTER,CREATE,SELECT(×2),SUPER(mistranslated as "素晴らしい", literally "wonderful" — a striking false-friend),RESTRICTED_VARIABLES_ADMIN, RESTRICTED_TABLES_ADMIN, andSELECT, INSERT, UPDATE, DELETE, CREATE, DROP(×3 rows). Also fixedinformation_schema.columns(a literal system-table reference in the "Scope" column) which had been translated as "情報スキーマ列".Searched the rest of the corpus (privilege-management.md, all
sql-statement-grant/create-role/create-user/show-grants/revokepages, column-privilege-management.md, role-based-access-control.md, user-account-management.md, alldm/*,tidb-lightning/*,br/*pages, and TiDB Cloud migration/import/backup guides) — no further instances of this defect found; all other privilege/identifier mentions are already correctly kept literal.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?