i18n(ja): restore literal config-key identifiers and filename templates - #23726
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThis documentation update replaces selected Japanese labels with English configuration names, standardizes export filename placeholders, corrects one schema filename pattern, and updates terminology in comparison and benchmark tables. Existing anchors, descriptions, values, and links remain unchanged. ChangesDocumentation terminology alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change standardizes Japanese table and update-event terminology without altering documented behavior, configuration, links, or values. No current merge-readiness risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the changes, affected files, target version, and AI involvement. The related-link fields are empty, but they are non-critical because no source or reference links are required to understand this documentation-only change. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
missing-translation-status
34262fe to
a8d0873
Compare
TOML config-section headings, dotted config keys, and filename-template
placeholders are literal strings users type into config files or match
against tool output — translating them breaks that exact-match property.
- tiflash/tiflash-configuration.md: 15 heading identifiers (e.g. flash,
security.encryption.master-key) rendered in katakana/kanji instead of
literal, inconsistent with correctly-untouched sibling headings like
storage.main in the same file.
- ticdc/ticdc-changefeed-config.md: 3 heading identifiers (filter.event-filters,
sink.open, sink.debezium).
- tidb-lightning/tidb-lightning-requirements.md: checkpoint.driver config
value in a privilege table.
- releases/release-6.2.0.md: 2 log-backup.* config-key link texts.
- tidb-cloud/premium/premium-export.md: filename-template placeholders
({database}, {table}, compression-type) in a naming-convention table.
a8d0873 to
d9b5dd9
Compare
…er gap - Unify "Item" table-header translation to 項目 across 4 files (was アイテム, an inconsistent minority form vs the dominant convention once compared across the corpus). - premium-export.md/serverless-export.md: also fix 圧縮/圧縮されている header pair not being grammatically parallel with 圧縮されていない. - serverless-export.md: same literal-identifier defect as premium-export.md's naming-convention table (missed by the earlier scan since this sibling file wasn't in its initial file list).
The table row translated "Workloada" (the literal go-ycsb benchmark
workload name referenced two paragraphs earlier) as the generic noun
作業負荷 ("workload"), losing the fact that it names one specific
benchmark preset.
Same defect as the table row fixed in the previous commit: the link text "go-ycsb workloada" (matching the URL's own /workloads/workloada path) was genericized to "go-ycsbワークロード", losing the specific benchmark identifier.
Missing connector between the identifier and 追加パラメーター made the sentence read as an unnatural direct juxtaposition; EN's "has an extra `X` parameter" needs という to connect the identifier to the noun phrase naturally.
EN consistently says "Event of Update Type"; JA had split into タイプ (heading, one bullet) and 種類 (table row, one paragraph) within the same file.
qiancai
added
translation/no-need
[LGTM Timeline notifier]Timeline:
|
2 participants
What is changed, added or deleted? (Required)
Found while sweeping for the "literal identifier translated into Japanese" defect class corpus-wide, extending previous sweeps (dotted config/API identifiers, S3 API action names, MySQL/TiDB privilege names — see prior PRs #23617-#23623, #23715, #23716). This round specifically targeted fully-katakana-translated dotted identifiers, a shape invisible to the ASCII-vs-katakana regex used in earlier sweeps.
tiflash/tiflash-configuration.md: 15####heading identifiers (literal TOML config-section names users type intotiflash.toml/tiflash-learner.toml, e.g.flash,security.encryption.master-key) were rendered in katakana/kanji instead of literal — inconsistent with correctly-untouched sibling headings likestorage.mainin the same file.ticdc/ticdc-changefeed-config.md: 3 heading identifiers (filter.event-filters,sink.open,sink.debezium).tidb-lightning/tidb-lightning-requirements.md:checkpoint.driver = "mysql"config value in a privilege-requirement table.releases/release-6.2.0.md: 2log-backup.*config-key link texts.tidb-cloud/premium/premium-export.md: filename-template placeholders ({database},{table},.{compression-type}) in a naming-convention table — these are substituted literally by the export tool.Each fix verified against the EN source (
release-8.5) at the same location.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
go-ycsb workloadareference and updated its comparison table.