Fix missing references in doc type map - #64872
Merged
Merged
Conversation
A few of these were lost in recent refactorings, and some never existed at all. Signed-off-by: Tim Perry <pimterry@gmail.com>
pimterry
force-pushed
the
fix-h2-docs-header-links
branch
from
July 31, 2026 13:47
f64dd78 to
a30b72a
Compare
cjihrig
approved these changes
Jul 31, 2026
avivkeller
approved these changes
Jul 31, 2026
jakecastelli
approved these changes
Jul 31, 2026
jakecastelli
added
the
author ready
4 tasks
lpinca
approved these changes
Jul 31, 2026
jasnell
approved these changes
Aug 2, 2026
pimterry
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 80c57e4 |
aduh95
pushed a commit
that referenced
this pull request
Aug 3, 2026
A few of these were lost in recent refactorings, and some never existed at all. Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: #64872 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each addition here is an existing reference that currently doesn't work. Most of these were correctly linked originally but they seem to have been lost during the migration from
tools/doc/type-parser.mjstodoc/type-map.jsonin #57343.I noticed this because of the HTTP/2 raw header case but it turns out there was a broader issue, presumably because the PR was open for nearly a year, so lots of opportunity for conflict resolution to miss things.
A few of the references here are new and never linked correctly, but have an obvious target that's unambiguous so I've included them.